AkkomaGang/akkoma-fe

Fork 64

lists #4

Merged

floatingghost merged 17 commits from :lists into develop

2022-06-20 13:10:01 +00:00

Ghost commented

2022-06-15 16:19:07 +00:00

First-time contributor

the API supports them, they just need to be added to the FE

render list timeline
- display the list title (requires fancy shenanigans that i'm too tired to do)
list available lists
- make it look nice
edit and delete lists
create lists
tests

the API supports them, they just need to be added to the FE - [x] render list timeline - [x] display the list title (requires fancy shenanigans that i'm too tired to do) - [x] list available lists - [x] make it look nice - [x] edit and delete lists - [x] create lists - [x] tests

22-06-15-191239.png

96 KiB

22-06-15-191208.png

14 KiB

Ghost force-pushed lists from f931b5de8b to 4e7c1f7ed3

2022-06-15 17:34:09 +00:00

Compare

Ghost commented

2022-06-15 17:36:45 +00:00

Author

First-time contributor

this is how /lists looks now:

this is how `/lists` looks now: ![lists](https://snug.moe/files/5cea2f3b-3795-40f7-a98f-108313ed7b3a)

Ghost force-pushed lists from 4e7c1f7ed3 to 9ad2809b41

2022-06-15 22:57:06 +00:00

Compare

Ghost commented

2022-06-15 22:58:46 +00:00

Author

First-time contributor

added a list creation screen:

added a list creation screen: ![](https://snug.moe/files/b6a6c20f-ba84-401b-8de2-c5da563c9062)

Ghost force-pushed lists from 3b80b4d275 to 349eb516d1

2022-06-16 07:07:32 +00:00

Compare

Ghost commented

2022-06-16 07:14:55 +00:00

Author

First-time contributor

ok so
i'm almost done except for tests and a few annoying things, namely:

moving between lists keeps the timeline of the previous lists unless you reload. this is because the lists share a this.$store.state.statuses.timelines.list timeline.
there are two ways to fix this problem: either make it use something like this.$store.state.statuses.timelines.list.(:id) (the correct way, but also hard and annoying)
or empty the list timeline when exiting a list (it's probably going to be super slow)

(i did the easier path)
(it's not bad actually and it was very simple)

when editing a list, the existing accounts sometimes won't load. ~~my instance is really slow for some reason so it might be negligible lag for everyone else (testing appreciated),~~ (CAN REPRODUCE ON FASTER INSTANCES) but the user cards will attempt to load before the accounts have even been fetched. i've added a check for it, but it doesn't really help, it just displays nothing instead of erroring and breaking.
i don't know how async works in js so help might be needed

ok so i'm almost done except for tests and a few annoying things, namely: ~~moving between lists keeps the timeline of the previous lists unless you reload. this is because the lists share a `this.$store.state.statuses.timelines.list` timeline. there are two ways to fix this problem: either make it use something like `this.$store.state.statuses.timelines.list.(:id)` (the correct way, but also hard and annoying) or empty the list timeline when exiting a list (it's probably going to be super slow)~~ (i did the easier path) (it's not bad actually and it was very simple) when editing a list, the existing accounts sometimes won't load. ~~my instance is really slow for some reason so it might be negligible lag for everyone else (testing appreciated),~~ (CAN REPRODUCE ON FASTER INSTANCES) but the user cards will attempt to load before the accounts have even been fetched. i've added a check for it, but it doesn't really help, it just displays nothing instead of erroring and breaking. i don't know how async works in js so help might be needed

Ghost changed title from ~~WIP: lists~~ to lists

2022-06-16 10:39:58 +00:00

Ghost commented

2022-06-16 10:41:16 +00:00

Author

First-time contributor

ready for review! cc @floatingghost

i didn't write any tests because all of the test files that should have been updated are already very lacking, and also because writing tests is boring

ready for review! cc @floatingghost i didn't write any tests because all of the test files that *should* have been updated are already very lacking, and also because writing tests is boring

Ghost changed title from ~~lists~~ to WIP: lists

2022-06-17 18:48:25 +00:00

Ghost commented

2022-06-17 18:48:46 +00:00

Author

First-time contributor

WIP again, i want to rewrite this, too many API calls are done directly

Ghost force-pushed lists from 252d6fb11d to fd26a91056

2022-06-18 13:05:38 +00:00

Compare

Ghost force-pushed lists from efa5a2eef5 to ad77f4b314

2022-06-18 15:16:45 +00:00