From 2ae27483b41cbe6938f2d973b0bf55aed15ac769 Mon Sep 17 00:00:00 2001 From: Angelina Filippova Date: Fri, 22 Mar 2019 20:58:58 +0000 Subject: [PATCH] Add tests --- .babelrc | 24 +- package.json | 59 +- src/api/__mocks__/users.js | 29 + src/api/login.js | 5 +- src/api/transaction.js | 9 - src/api/users.js | 20 +- src/store/modules/user.js | 36 +- src/store/modules/users.js | 20 +- src/utils/request.js | 17 - src/views/users/index.vue | 13 +- test/views/users/index.test.js | 136 ++ test/views/users/store.conf.js | 28 + yarn.lock | 3382 +++++++++++++++++++++++--------- 13 files changed, 2798 insertions(+), 980 deletions(-) create mode 100644 src/api/__mocks__/users.js delete mode 100644 src/api/transaction.js create mode 100644 test/views/users/index.test.js create mode 100644 test/views/users/store.conf.js diff --git a/.babelrc b/.babelrc index 6c0b7f27..006f947d 100644 --- a/.babelrc +++ b/.babelrc @@ -1,17 +1,25 @@ { "presets": [ - ["env", { - "modules": false, - "targets": { - "browsers": ["> 1%", "last 2 versions", "not ie <= 8"] + [ + "@babel/preset-env", { + "modules": "auto", + "targets": { + "browsers": ["> 1%", "last 2 versions", "not ie <= 8"] + } } - }], - "stage-2" + ], + "@vue/babel-preset-jsx" + ], + "plugins": [ + "@babel/plugin-transform-runtime", + "@babel/plugin-syntax-dynamic-import" ], - "plugins": ["transform-vue-jsx", "transform-runtime"], "env": { "development":{ - "plugins": ["dynamic-import-node"] + "plugins": ["dynamic-import-node-babel-7"] + }, + "test":{ + "plugins": ["dynamic-import-node-babel-7"] } } } diff --git a/package.json b/package.json index 7dea34b2..614d010e 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,8 @@ "build:prod": "cross-env NODE_ENV=production env_config=prod node build/build.js", "build:sit": "cross-env NODE_ENV=production env_config=sit node build/build.js", "lint": "eslint --ext .js,.vue src", - "test": "npm run lint", + "test": "jest", + "test:debug": "node --inspect-brk node_modules/.bin/jest --runInBand", "precommit": "lint-staged", "svgo": "svgo -f src/icons/svg --config=src/icons/svgo.yml" }, @@ -34,6 +35,7 @@ "url": "https://github.com/PanJiaChen/vue-element-admin/issues" }, "dependencies": { + "@babel/runtime": "^7.3.4", "axios": "0.18.0", "clipboard": "1.7.1", "codemirror": "5.39.2", @@ -46,6 +48,7 @@ "js-cookie": "2.2.0", "jsonlint": "1.6.3", "jszip": "3.1.5", + "lodash": "^4.17.11", "lodash.debounce": "^4.0.8", "mockjs": "1.0.1-beta3", "normalize.css": "7.0.0", @@ -54,7 +57,7 @@ "showdown": "1.8.6", "sortablejs": "1.7.0", "tui-editor": "1.2.7", - "vue": "2.5.17", + "vue": "^2.6.8", "vue-count-to": "1.0.13", "vue-i18n": "7.3.2", "vue-router": "3.0.2", @@ -64,17 +67,20 @@ "xlsx": "^0.11.16" }, "devDependencies": { + "@babel/core": "^7.3.4", + "@babel/plugin-syntax-dynamic-import": "^7.2.0", + "@babel/plugin-transform-runtime": "^7.3.4", + "@babel/preset-env": "^7.3.4", + "@vue/babel-helper-vue-jsx-merge-props": "^1.0.0-beta.2", + "@vue/babel-preset-jsx": "^1.0.0-beta.2", + "@vue/test-utils": "^1.0.0-beta.29", "autoprefixer": "8.5.0", - "babel-core": "6.26.3", "babel-eslint": "8.2.6", "babel-helper-vue-jsx-merge-props": "2.0.3", - "babel-loader": "7.1.5", - "babel-plugin-dynamic-import-node": "2.0.0", - "babel-plugin-syntax-jsx": "6.18.0", - "babel-plugin-transform-runtime": "6.23.0", - "babel-plugin-transform-vue-jsx": "3.7.0", - "babel-preset-env": "1.7.0", - "babel-preset-stage-2": "6.24.1", + "babel-jest": "^24.1.0", + "babel-loader": "^8.0.5", + "babel-plugin-dynamic-import-node-babel-7": "^2.0.7", + "babel-plugin-transform-es2015-modules-commonjs": "^6.26.2", "chalk": "2.4.1", "compression-webpack-plugin": "2.0.0", "connect": "3.6.6", @@ -88,8 +94,10 @@ "file-loader": "1.1.11", "friendly-errors-webpack-plugin": "1.7.0", "hash-sum": "1.0.2", - "html-webpack-plugin": "4.0.0-alpha", + "html-webpack-plugin": "^3.2.0", "husky": "0.14.3", + "jest": "^24.1.0", + "jest-transform-stub": "^2.0.0", "lint-staged": "7.2.2", "mini-css-extract-plugin": "0.4.1", "node-notifier": "5.2.1", @@ -112,12 +120,13 @@ "svgo": "1.0.5", "uglifyjs-webpack-plugin": "1.2.7", "url-loader": "1.0.1", + "vue-jest": "4.0.0-beta.2", "vue-loader": "15.3.0", "vue-style-loader": "4.1.2", - "vue-template-compiler": "2.5.17", - "webpack": "4.16.5", + "vue-template-compiler": "^2.6.8", + "webpack": "^4.29.6", "webpack-bundle-analyzer": "2.13.1", - "webpack-cli": "3.1.0", + "webpack-cli": "^3.2.3", "webpack-dev-server": "3.1.14", "webpack-merge": "4.1.4" }, @@ -129,5 +138,25 @@ "> 1%", "last 2 versions", "not ie <= 8" - ] + ], + "jest": { + "moduleFileExtensions": [ + "js", + "json", + "vue" + ], + "moduleDirectories": [ + "node_modules", + "src" + ], + "transform": { + "^.+\\.vue$": "vue-jest", + "^.+\\.js$": "babel-jest", + ".+\\.(css|styl|less|sass|scss|png|jpg|ttf|woff|woff2)$'": "jest-transform-stub" + }, + "moduleNameMapper": { + "^.+.(css|styl|less|sass|scss|png|jpg|ttf|woff|woff2)$": "jest-transform-stub", + "^@/(.*)$": "/src/$1" + } + } } diff --git a/src/api/__mocks__/users.js b/src/api/__mocks__/users.js new file mode 100644 index 00000000..2e10334e --- /dev/null +++ b/src/api/__mocks__/users.js @@ -0,0 +1,29 @@ +const users = [ + { deactivated: false, id: '1', nickname: 'john', local: true }, + { deactivated: false, id: '2', nickname: 'bob', local: false }, + { deactivated: true, id: '3', nickname: 'allis', local: true } +] + +export async function fetchUsers(showLocalUsersOnly, token, page = 1) { + const filteredUsers = showLocalUsersOnly ? users.filter(user => user.local) : users + return Promise.resolve({ data: { + users: filteredUsers, + count: filteredUsers.length, + page_size: 50 + }}) +} + +export async function toggleUserActivation(nickname, token) { + const response = users.find(user => user.nickname === nickname) + return Promise.resolve({ data: { ...response, deactivated: !response.deactivated }}) +} + +export async function searchUsers(query, showLocalUsersOnly, token, page = 1) { + const filteredUsers = showLocalUsersOnly ? users.filter(user => user.local) : users + const response = filteredUsers.filter(user => user.nickname === query) + return Promise.resolve({ data: { + users: response, + count: response.length, + page_size: 50 + }}) +} diff --git a/src/api/login.js b/src/api/login.js index bc1c03ff..e3d990d1 100644 --- a/src/api/login.js +++ b/src/api/login.js @@ -26,10 +26,11 @@ export async function loginByUsername(username, password) { }) } -export function getUserInfo() { +export function getUserInfo(token) { return request({ url: '/api/account/verify_credentials', - method: 'post' + method: 'post', + headers: token ? { 'Authorization': `Bearer ${token}` } : {} }) } diff --git a/src/api/transaction.js b/src/api/transaction.js deleted file mode 100644 index dfe64392..00000000 --- a/src/api/transaction.js +++ /dev/null @@ -1,9 +0,0 @@ -import request from '@/utils/request' - -export function fetchList(query) { - return request({ - url: '/transaction/list', - method: 'get', - params: query - }) -} diff --git a/src/api/users.js b/src/api/users.js index a6023f9c..9c92532e 100644 --- a/src/api/users.js +++ b/src/api/users.js @@ -1,23 +1,27 @@ import request from '@/utils/request' +import { getToken } from '@/utils/auth' -export async function fetchUsers(page = 1, showLocalUsers) { +export async function fetchUsers(showLocalUsersOnly, token, page = 1) { return await request({ - url: `/api/pleroma/admin/users?page=${page}&local_only=${showLocalUsers}`, - method: 'get' + url: `/api/pleroma/admin/users?page=${page}&local_only=${showLocalUsersOnly}`, + method: 'get', + headers: token ? { 'Authorization': `Bearer ${getToken()}` } : {} }) } -export async function toggleUserActivation(nickname) { +export async function toggleUserActivation(nickname, token) { return await request({ url: `/api/pleroma/admin/users/${nickname}/toggle_activation`, - method: 'patch' + method: 'patch', + headers: token ? { 'Authorization': `Bearer ${getToken()}` } : {} }) } -export async function searchUsers(query, page = 1, showLocalUsers) { +export async function searchUsers(query, showLocalUsersOnly, token, page = 1) { return await request({ - url: `/api/pleroma/admin/users?query=${query}&page=${page}&local_only=${showLocalUsers}`, - method: 'get' + url: `/api/pleroma/admin/users?query=${query}&page=${page}&local_only=${showLocalUsersOnly}`, + method: 'get', + headers: token ? { 'Authorization': `Bearer ${getToken()}` } : {} }) } diff --git a/src/store/modules/user.js b/src/store/modules/user.js index 65e51cde..58aaea55 100644 --- a/src/store/modules/user.js +++ b/src/store/modules/user.js @@ -54,7 +54,7 @@ const user = { loginByUsername(username, userInfo.password).then(response => { const data = response.data commit('SET_TOKEN', data.access_token) - setToken(response.data.access_token) + setToken(data.access_token) resolve() }).catch(error => { reject(error) @@ -116,25 +116,25 @@ const user = { removeToken() resolve() }) - }, + } // 动态修改权限 - ChangeRoles({ commit, dispatch }, role) { - return new Promise(resolve => { - commit('SET_TOKEN', role) - setToken(role) - getUserInfo(role).then(response => { - const data = response.data - commit('SET_ROLES', data.roles) - commit('SET_NAME', data.name) - commit('SET_ID', data.id) - commit('SET_AVATAR', data.avatar) - commit('SET_INTRODUCTION', data.introduction) - dispatch('GenerateRoutes', data) // 动态修改权限后 重绘侧边菜单 - resolve() - }) - }) - } + // ChangeRoles({ commit, dispatch }, role) { + // return new Promise(resolve => { + // commit('SET_TOKEN', role) + // setToken(role) + // getUserInfo(role).then(response => { + // const data = response.data + // commit('SET_ROLES', data.roles) + // commit('SET_NAME', data.name) + // commit('SET_ID', data.id) + // commit('SET_AVATAR', data.avatar) + // commit('SET_INTRODUCTION', data.introduction) + // dispatch('GenerateRoutes', data) // 动态修改权限后 重绘侧边菜单 + // resolve() + // }) + // }) + // } } } diff --git a/src/store/modules/users.js b/src/store/modules/users.js index e8928334..8db05813 100644 --- a/src/store/modules/users.js +++ b/src/store/modules/users.js @@ -1,13 +1,13 @@ import { fetchUsers, toggleUserActivation, searchUsers } from '@/api/users' -const user = { +const users = { state: { fetchedUsers: [], loading: true, searchQuery: '', totalUsersCount: 0, currentPage: 1, - showLocalUsers: false + showLocalUsersOnly: false }, mutations: { SET_USERS: (state, users) => { @@ -38,23 +38,23 @@ const user = { state.searchQuery = query }, SET_LOCAL_USERS_FILTER: (state, value) => { - state.showLocalUsers = value + state.showLocalUsersOnly = value } }, actions: { - async FetchUsers({ commit, state }, { page }) { - const response = await fetchUsers(page, state.showLocalUsers) + async FetchUsers({ commit, state, getters }, { page }) { + const response = await fetchUsers(state.showLocalUsersOnly, getters.token, page) commit('SET_LOADING', true) loadUsers(commit, page, response.data) }, - async ToggleUserActivation({ commit }, nickname) { - const response = await toggleUserActivation(nickname) + async ToggleUserActivation({ commit, getters }, nickname) { + const response = await toggleUserActivation(nickname, getters.token) commit('SWAP_USER', response.data) }, - async SearchUsers({ commit, dispatch, state }, { query, page }) { + async SearchUsers({ commit, dispatch, state, getters }, { query, page }) { if (query.length === 0) { commit('SET_SEARCH_QUERY', query) dispatch('FetchUsers', page) @@ -62,7 +62,7 @@ const user = { commit('SET_LOADING', true) commit('SET_SEARCH_QUERY', query) - const response = await searchUsers(query, page, state.showLocalUsers) + const response = await searchUsers(query, state.showLocalUsersOnly, getters.token, page) loadUsers(commit, page, response.data) } @@ -82,4 +82,4 @@ const loadUsers = (commit, page, { users, count, page_size }) => { commit('SET_LOADING', false) } -export default user +export default users diff --git a/src/utils/request.js b/src/utils/request.js index e7966dc2..9de05d36 100644 --- a/src/utils/request.js +++ b/src/utils/request.js @@ -1,7 +1,5 @@ import axios from 'axios' import { Message } from 'element-ui' -import store from '@/store' -import { getToken } from '@/utils/auth' // create an axios instance const service = axios.create({ @@ -9,21 +7,6 @@ const service = axios.create({ timeout: 5000 // request timeout }) -// request interceptor -service.interceptors.request.use( - config => { - if (store.getters.token) { - config.headers['Authorization'] = `Bearer ${getToken()}` - } - return config - }, - error => { - // Do something with request error - console.log(error) // for debug - Promise.reject(error) - } -) - // response interceptor service.interceptors.response.use( response => response, diff --git a/src/views/users/index.vue b/src/views/users/index.vue index cf558fe2..111d29a2 100644 --- a/src/views/users/index.vue +++ b/src/views/users/index.vue @@ -2,7 +2,7 @@

Users

- Local users only + Local users only
@@ -20,6 +20,7 @@