slightly changed the code to have less mutations, added comments

This commit is contained in:
Henry Jameson 2018-12-14 17:33:48 +03:00
parent d7973b0b80
commit 13fbef4550

View file

@ -90,43 +90,54 @@ export default {
store.state.api.backendInteractor.followUser(this.user.id) store.state.api.backendInteractor.followUser(this.user.id)
.then((followedUser) => store.commit('addNewUsers', [followedUser])) .then((followedUser) => store.commit('addNewUsers', [followedUser]))
.then(() => { .then(() => {
// For locked users we just mark it that we sent the follow request
if (this.user.locked) {
this.followRequestInProgress = false
this.followRequestSent = true
return
}
if (this.user.following) { if (this.user.following) {
// If we get result immediately, just stop.
this.followRequestInProgress = false this.followRequestInProgress = false
return return
} }
if (!this.user.locked) {
let attemptsLeft = 3 // But usually we don't get result immediately, so we ask server
const fetchUser = () => new Promise((resolve, reject) => { // for updated user profile to confirm if we are following them
// Sometimes it takes several tries. Sometimes we end up not following
// user anyway, probably because they locked themselves and we
// don't know that yet.
// Recursive Promise, it will call itself up to 3 times.
const fetchUser = (attempt) => new Promise((resolve, reject) => {
setTimeout(() => { setTimeout(() => {
store.state.api.backendInteractor.fetchUser({ id: this.user.id }) store.state.api.backendInteractor.fetchUser({ id: this.user.id })
.then((user) => store.commit('addNewUsers', [user])) .then((user) => store.commit('addNewUsers', [user]))
.then(() => resolve(this.user.following)) .then(() => resolve([this.user.following, attempt]))
.catch((e) => reject(e)) .catch((e) => reject(e))
}, 500) }, 500)
}).then((confirmed) => { }).then(([following, attempt]) => {
if (!confirmed && attemptsLeft > 0) { if (!following && attempt <= 3) {
attemptsLeft-- // If we BE reports that we still not following that user - retry,
return fetchUser() // increment attempts by one
} else if (confirmed) { return fetchUser(++attempt)
return true
} else { } else {
return false // If we run out of attempts, just return whatever status is.
return following
} }
}) })
return fetchUser() return fetchUser(1)
.then((successfulConfirmation) => { .then((following) => {
if (successfulConfirmation) { if (following) {
// We confirmed and everything its good.
this.followRequestInProgress = false this.followRequestInProgress = false
} else { } else {
// If after all the tries, just treat it as if user is locked
this.followRequestInProgress = false this.followRequestInProgress = false
this.followRequestSent = true this.followRequestSent = true
} }
}) })
} else {
this.followRequestInProgress = false
this.followRequestSent = true
}
}) })
}, },
unfollowUser () { unfollowUser () {