[Bug?] Posts from Misskey display weird

Mergan commented

2022-09-04 06:13:36 +00:00

Member

Akkoma

Source

Is this Akkoma or them?

Akkoma ![image](/attachments/91c91183-d930-434d-816a-1d60526589bb) Source ![image](/attachments/54429836-a69e-4515-844a-384c8518aff5) Is this Akkoma or them?

image.png

16 KiB

image.png

26 KiB

Mergan commented

2022-09-04 06:17:39 +00:00

Author

Member

Post from a few days ago before I upgraded to latest dev

![image](/attachments/f851407f-dfa5-4b6b-b781-d41b8032ce6a) Post from a few days ago before I upgraded to latest dev

image.png

16 KiB

floatingghost commented

2022-09-06 16:43:28 +00:00

Owner

this is technically them - the send "markdown", but consider \n to be a newline, where in markdown \n\n should be a newline

this is technically them - the send "markdown", but consider `\n` to be a newline, where in markdown `\n\n` should be a newline

ArcanaOfSouls commented

2022-10-02 13:37:21 +00:00

By newline do you mean a paragraph break? In every Markdown spec we've heard of, \n\n is a paragraph break, not a line break, whereas

\n

(two spaces followed by a line feed) is a line break. There are definitely specs that consider a single \n to be a line break, though.

Does MFM consider a single \n to be a line break? (I'm just clarifying the reply above this one. We've tried to find an English-language version of the official MFM spec to no avail, so we don't have a good way to figure this out ourselves.) If that's the case, would a PR for the Akkoma-MFMParser be useful? We'd be happy to contribute one if that's useful.

By newline do you mean a paragraph break? In every Markdown spec we've heard of, `\n\n` is a paragraph break, not a line break, whereas ``` \n ``` (two spaces followed by a line feed) is a line break. There are definitely specs that consider a single `\n` to be a line break, though. Does MFM consider a single `\n` to be a line break? (I'm just clarifying the reply above this one. We've tried to find an English-language version of the official MFM spec to no avail, so we don't have a good way to figure this out ourselves.) If that's the case, would a PR for the Akkoma-MFMParser be useful? We'd be happy to contribute one if that's useful.

floatingghost commented

2022-10-02 13:40:41 +00:00

Owner

yep your interpretation above is correct - MFM considers \n to be a paragraph break, no spaces needed

the above discrepancy can be created by that

yep your interpretation above is correct - MFM considers `\n` to be a paragraph break, no spaces needed the above discrepancy can be created by that

ArcanaOfSouls commented

2022-10-02 13:43:47 +00:00

Thanks for confirming! Would a PR for Akkoma-MFMParser be welcomed to account for that discrepancy in the MFM Markdown spec?

floatingghost commented

2022-10-02 13:49:45 +00:00

Owner

hm, i'm unsure - akkoma uses its generic markdown processor after preprocessing MFM tags - you might be able to add an option to the markdown parser which will accept single \n being a paragraph break

if you can manage that, then go right ahead

the MFM is processed here -> https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/web/common_api/utils.ex#L290

which in turn calls Earmark here -> https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/formatter.ex#L128

you might have to fiddle with preprocessing the input, good luck though, this stuff is incredibly fiddly

hm, i'm unsure - akkoma uses its generic markdown processor after preprocessing MFM tags - you might be able to add an option to the markdown parser which will accept single `\n` being a paragraph break if you can manage that, then go right ahead the MFM is processed here -> https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/web/common_api/utils.ex#L290 which in turn calls Earmark here -> https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/formatter.ex#L128 you might have to fiddle with preprocessing the input, good luck though, this stuff is incredibly fiddly

👍 1

ArcanaOfSouls commented

2022-10-15 06:48:46 +00:00

We had some stuff come up the last few weeks that kept us busy, but we're taking a look at this now. We'll submit a PR when we have something working (hopefully by the end of this weekend) and/or let folks if it doesn't seem feasible.

Mergan added the

Bug

label 2022-11-17 23:20:36 +00:00

floatingghost referenced this issue from AkkomaGang/akkoma

2022-12-19 19:51:47 +00:00

[bug] See if we can use the content for posts, also when it's MFM. #381

ilja commented

2022-12-19 20:08:40 +00:00

Contributor

If someone wants to test it, I'm pretty sure you could fix this by changing this line to "<br>" https://akkoma.dev/AkkomaGang/mfm-parser/src/branch/akkoma/lib/encoder.ex#L47 (And ofc also fix corresponding tests)

The parser already reads newlines, but doesn't do anything with them, it just puts it back.

So if we change the newline to <br>, then the markdown parser should leave that tag alone, et voila, we have the newline.

If someone wants to test it, I'm pretty sure you could fix this by changing this line to `"<br>"` https://akkoma.dev/AkkomaGang/mfm-parser/src/branch/akkoma/lib/encoder.ex#L47 (And ofc also fix corresponding tests) The parser already reads newlines, but doesn't do anything with them, it just puts it back. So if we change the newline to `<br>`, then the markdown parser should leave that tag alone, et voila, we have the newline.

ArcanaOfSouls commented

2022-12-20 07:52:40 +00:00

I meant to write back sooner, but in short, my health has been less than great lately, and most of my energy is spent on recovering. I alluded to the same issue back in October, but unfortunately things are still nowhere near back to baseline.

I apologize for never taking care of this and never replying. On top of ongoing health issues that are just things I have to deal with, my repetitive strain injuries have flared up again and don't seem to be dying back down. So I've been in the process of learning to type by voice on a daily basis. Which, as a software developer, is not always the easiest thing.

I meant to write back sooner, but in short, my health has been less than great lately, and most of my energy is spent on recovering. I alluded to the same issue back in October, but unfortunately things are still nowhere near back to baseline. I apologize for never taking care of this and never replying. On top of ongoing health issues that are just things I have to deal with, my repetitive strain injuries have flared up again and don't seem to be dying back down. So I've been in the process of learning to type by voice on a daily basis. Which, as a software developer, is not always the easiest thing.

floatingghost referenced this issue from AkkomaGang/akkoma

2022-12-20 13:48:30 +00:00

[bug] Posts with MFM has no single newlines #383

ilja commented

2022-12-21 13:34:31 +00:00

Contributor

@ArcanaOfSouls No worries. We're all volunteers here, please don't feel pressured. Take care of yourself. You're much more important than this little bug ;)

❤️ 1

ilja referenced this issue from AkkomaGang/akkoma

2023-02-18 18:35:34 +00:00

Interpret \n as newline for MFM #478

Rows
Columns

[Bug?] Posts from Misskey display weird #155