AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 82 Pull requests 20 Projects Releases 1 Wiki Activity

Detect whether an WEBP or APNG is animated #161

Merged
floatingghost merged 2 commits from Mergan/pleroma-fe:animated-webp into develop 2022-09-23 10:27:15 +00:00
Conversation 0 Commits 2 Files changed 1 +79 -6
Mergan commented 2022-09-09 11:29:58 +00:00
Member
Copy link
No description provided.
Mergan added 2 commits 2022-09-09 11:29:59 +00:00
Detect Animation only for mediaProxy
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
9d3a32a636 
Works without, but this should suppress CORS browser errors
floatingghost reviewed 2022-09-19 17:51:10 +00:00
src/components/still-image/still-image.js
@ -34,0 +47,4 @@
if (!this.$store.state.instance.mediaProxyAvailable) return
// Animated JPEGs?
if (!(this.src.endsWith('.webp') || this.src.endsWith('.png'))) return
// Browser Cache should ensure image doesn't get loaded twice if cache exists
floatingghost commented 2022-09-19 17:51:10 +00:00
Owner
Copy link

we can enforce this by setting cache: 'only-if-cached' in the fetch options

see: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#supplying_request_options

probably worth setting

otherwise this looks good

we can enforce this by setting `cache: 'only-if-cached'` in the fetch options see: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#supplying_request_options probably worth setting otherwise this looks good
Mergan commented 2022-09-21 09:19:43 +00:00
Author
Member
Copy link

There seemed to be no difference when I tested that, but I think I found out why

Should I still add it anyway?

There seemed to be no difference when I tested that, but I think I found out [why](https://caniuse.com/mdn-api_request_cache_only_if_cached) Should I still add it anyway?
floatingghost commented 2022-09-23 10:27:04 +00:00
Owner
Copy link

nah you're good, i didn't realise there was no support

is good as-is

thanks!

nah you're good, i didn't realise there was no support is good as-is thanks!
floatingghost marked this conversation as resolved
floatingghost merged commit 468eb12573 into develop 2022-09-23 10:27:15 +00:00
floatingghost deleted branch animated-webp 2022-09-23 10:27:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#161
No description provided.
Delete branch "Mergan/pleroma-fe:animated-webp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?