[Bug] Malformed HTTP requests causing 404 errors

solidsanek commented

2022-10-11 11:30:03 +00:00

Contributor

Steps to reproduce:

View the account of an user that has private posts (/users/:id)
Open one of their private post (/notice/:id)

Observed behaviour:
Two 404 errors appear

One on https://outerheaven.club/api/v1/accounts/:id?with_relationships=true where :id is the one of the post
One on https://outerheaven.club/api/v1/accounts/null/statuses?with_muted=true&exclude_replies=1&limit=20

Example on https://outerheaven.club/notice/AOSE9pm6Ykf152HiVM (which is a private post) where I get an error on https://outerheaven.club/api/v1/accounts/AOSE9pm6Ykf152HiVM?with_relationships=true and https://outerheaven.club/api/v1/accounts/null/statuses?with_muted=true&exclude_replies=1&limit=20

On public posts like https://outerheaven.club/notice/ANJpfDZZYs1P61EhNY the only error that appear is 1. on https://outerheaven.club/api/v1/accounts/ANJpfDZZYs1P61EhNY?with_relationships=true

The issue seems to only appear when going from viewing an user's profile to a post. Doing so on the timeline doesn't seem to result in 404s

Steps to reproduce: 1. View the account of an user that has private posts (/users/:id) 2. Open one of their private post (/notice/:id) Observed behaviour: Two 404 errors appear 1. One on https://outerheaven.club/api/v1/accounts/:id?with_relationships=true where :id is the one of the post 2. One on https://outerheaven.club/api/v1/accounts/null/statuses?with_muted=true&exclude_replies=1&limit=20 Example on https://outerheaven.club/notice/AOSE9pm6Ykf152HiVM (which is a private post) where I get an error on https://outerheaven.club/api/v1/accounts/AOSE9pm6Ykf152HiVM?with_relationships=true and https://outerheaven.club/api/v1/accounts/null/statuses?with_muted=true&exclude_replies=1&limit=20 On public posts like https://outerheaven.club/notice/ANJpfDZZYs1P61EhNY the only error that appear is 1. on https://outerheaven.club/api/v1/accounts/ANJpfDZZYs1P61EhNY?with_relationships=true The issue seems to only appear when going from viewing an user's profile to a post. Doing so on the timeline doesn't seem to result in 404s

Screenshot_2022-10-11_13-26-39.png

37 KiB

Screenshot_2022-10-11_13-29-13.png

27 KiB

floatingghost commented

2022-10-11 12:04:44 +00:00

Owner

users ANJpfDZZYs1P61EhNY and AOSE9pm6Ykf152HiVM indeed appear to not exist on your instance - it may be a deactivated account or similar

we'll have to decode the ID to do any meaningful debugging

can you run this on your db?

psql pleroma_prod -c "select nickname, is_active from users where id = '00000183-179a-e7b8-1e02-c11c29f80000' or id = '00000183-c680-143a-f4ee-9a8f43a80000';"

(obviously change the db name if you need)

users ANJpfDZZYs1P61EhNY and AOSE9pm6Ykf152HiVM indeed appear to not exist on your instance - it may be a deactivated account or similar we'll have to decode the ID to do any meaningful debugging can you run this on your db? ```sql psql pleroma_prod -c "select nickname, is_active from users where id = '00000183-179a-e7b8-1e02-c11c29f80000' or id = '00000183-c680-143a-f4ee-9a8f43a80000';" ``` (obviously change the db name if you need)

solidsanek commented

2022-10-11 17:55:14 +00:00

Author

Contributor

 nickname | is_active 
----------+-----------
(0 rows)

Welp, they don't even exist in my DB

``` nickname | is_active ----------+----------- (0 rows) ``` Welp, they don't even exist in my DB

Mergan added the

Bug

label 2022-11-17 23:16:23 +00:00

Mergan commented

2022-11-17 23:17:00 +00:00

Member

What was the conclusion 🤔?

solidsanek commented

2022-11-18 17:48:28 +00:00

Author

Contributor

It's still happening quite frequently when I open threads, but I don't really have more info than what I already provided. I'm assuming there's an issue with how these URLs are formed in the FE, but I may be wrong.

floatingghost commented

2022-11-20 21:51:18 +00:00

Owner

my hunch here is that it's something to do with suspended users (domain block etc etc)

there's another instance seeing some 404s when deleted users are around

my hunch here is that it's something to do with suspended users (domain block etc etc) there's another instance seeing some 404s when deleted users are around

floatingghost commented

2022-11-21 17:13:09 +00:00

Owner

ok i can't replicate anything on my side, i've requested an account on your instance to see if i can investigate it there, if that's ok

floatingghost commented

2022-11-22 11:18:30 +00:00

Owner

got it!

thanks for the account approval

it's trying to fetch the relationships of a note ID

wonder why

got it! thanks for the account approval it's trying to fetch the relationships of a note ID wonder why

floatingghost commented

2022-11-22 11:28:29 +00:00

Owner

ahah

so get this - user profiles are told to switch users when the route parameter called id changes - only problem is that both /notice/:id and /user/:id... have an ID param

![image](/attachments/b6932da3-a8e1-4bde-8b99-3255ae2d51cd) ahah so get this - user profiles are told to switch users when the route parameter called `id` changes - only problem is that both `/notice/:id` and `/user/:id`... have an ID param

image.png

22 KiB