AkkomaGang/akkoma-fe

Fork 67

4-digit interaction numbers glitch out after full load. (seen on pleroma instance) #198

New issue

Open

opened 2022-11-08 16:56:53 +00:00 by aetios · 5 comments

aetios commented

2022-11-08 16:56:53 +00:00

It looks like 4-digit interactions glitch out on pleroma instances. I haven't been able to check on akkoma but it's worth investigating?

The 4 digits Are visible as long as the response list isnt loaded then they vanish.

It looks like 4-digit interactions glitch out on pleroma instances. I haven't been able to check on akkoma but it's worth investigating? The 4 digits Are visible as long as the response list isnt loaded then they vanish.

1667926428.png

159 KiB

wizard commented

2022-11-11 04:50:02 +00:00

It all shows up properly on my instance, but the number is overflowing a bit.

2022-11-10-234916_screenshot.png

78 KiB

Mergan added the

Bug

label 2022-11-17 23:15:49 +00:00

drudge commented

2022-11-24 00:26:15 +00:00

Contributor

I see this as well for interactions in excess of 1k.

It looks like the responsible CSS is:

word-break: break-word styling for .Status inherited from div.

This is automatically applying flex-shrink to the likes count

if max-width of .Status .status-actions > * is set to 5em, then the likes display nominally as expected without other alterations (as in screenshot attached)

I'll see if I can figure out where this behavior is defined and submit a PR for this

I see this as well for interactions in excess of 1k. It looks like the responsible CSS is: `word-break: break-word` styling for `.Status` inherited from `div`. This is automatically applying `flex-shrink` to the likes count if `max-width` of `.Status .status-actions > *` is set to `5em`, then the likes display nominally as expected without other alterations (as in screenshot attached) I'll see if I can figure out where this behavior is defined and submit a PR for this

image.png

118 KiB

drudge commented

2022-11-24 02:16:22 +00:00

Contributor

So, I guess there are 2 separate issues here really, but the problem @wizard and I are experiencing should be sorted by my PR, which I've submitted for review:

AkkomaGang/pleroma-fe#233

So, I guess there are 2 separate issues here really, but the problem @wizard and I are experiencing should be sorted by my PR, which I've submitted for review: https://akkoma.dev/AkkomaGang/pleroma-fe/pulls/233

drudge referenced this issue

2022-11-24 06:00:09 +00:00

WIP: This addresses formatting issues when favorites on a post exceed 1k #233

Ghost commented

2022-12-10 19:11:07 +00:00

was this fixed in #236? or did that tackle only one of the issues here

drudge commented

2022-12-10 19:18:22 +00:00

Contributor

The issue @wizard(and myself) mentioned is fixed.

One of us should've split that into a separate issue for the sake of organization, but afaik ops concern wasn't.

The issue @wizard(and myself) mentioned is fixed. One of us should've split that into a separate issue for the sake of organization, but afaik ops concern wasn't.