Allow follow(er) lists to be acessible by account owner even if follower counts are disabled #246

Merged
floatingghost merged 1 commits from Beefox/fox-fe:fix-allow-follow-list into develop 2022-12-30 03:04:16 +00:00
Contributor

Currently, if a user has their follower/follow counts hidden, they cannot access their own list of followers/follows. This makes no real sense and means that they cannot modify those lists without disabling their privacy options.

This fix simply allows those tabs to be accessed no matter if the counts are hidden or not.

Currently, if a user has their follower/follow counts hidden, they cannot access their own list of followers/follows. This makes no real sense and means that they cannot modify those lists without disabling their privacy options. This fix simply allows those tabs to be accessed no matter if the counts are hidden or not.
Beefox added 1 commit 2022-12-08 01:04:57 +00:00
Contributor

i think a more intuitive solution UX-wise (and maybe security-wise too?) would be to still hide those tabs to those who aren't supposed to access them, but allow the user to see them:

- :disabled="!user.friends_count"
+ :disabled="!(user.friends_count || user === currentUser)"

of course check that this code works but yeah

i think a more intuitive solution UX-wise (and maybe security-wise too?) would be to still hide those tabs to those who aren't supposed to access them, but allow the user to see them: ```diff - :disabled="!user.friends_count" + :disabled="!(user.friends_count || user === currentUser)" ``` of course check that this code works but yeah
Author
Contributor

The tabs are already hidden by other code based on your settings for if the follower lists are visible or not, via the line
v-if="followsTabVisible"

The tabs are already hidden by other code based on your settings for if the follower lists are visible or not, via the line `v-if="followsTabVisible"`
Author
Contributor

When you have follow counts disabled, they aren't hidden, just disabled. you can still access the page with the correct link and still need to be the correct user,there is no security to disabling the buttons nor logic :p

When you have follow counts disabled, they aren't hidden, just disabled. you can still access the page with the correct link and still need to be the correct user,there is no security to disabling the buttons nor logic :p
Mergan added the
Feature request
label 2022-12-16 01:01:19 +00:00

seems good to me! thanks

seems good to me! thanks
floatingghost merged commit 2e5001e5de into develop 2022-12-30 03:04:16 +00:00
floatingghost deleted branch fix-allow-follow-list 2022-12-30 03:04:16 +00:00
Sign in to join this conversation.
No description provided.