AkkomaGang
/
akkoma-fe
4
13
Fork 56
Code Issues 72 Pull Requests 16 Projects Releases 1 Wiki Activity

fix realtime updates in 'following' replies filter #285

Merged
floatingghost merged 1 commits from flisk/akkoma-fe:fix-realtime-reply-filter into develop 2023-03-10 18:56:32 +00:00
Conversation 1 Commits 1 Files Changed 1 +14 -4
flisk commented 2023-02-23 23:28:05 +00:00
Contributor
Copy Link

with realtime updates enabled and the "show replies to my follows" filter enabled, no new posts would show up unless they were replies to my follows. this changes the filter to always let non-reply statuses through.

with realtime updates enabled and the "show replies to my follows" filter enabled, no new posts would show up unless they were replies to my follows. this changes the filter to always let non-reply statuses through.
flisk added 1 commit 2023-02-23 23:28:05 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
999c38594e fix realtime updates in 'following' replies filter 
i'm not sure how this code was supposed to work, but the way it was
written would only add statuses to the timeline if they were in reply to
someone the user is following and erroneously filter out posts that
aren't replies.
floatingghost commented 2023-03-10 18:56:28 +00:00
Owner
Copy Link

ah that makes sense

thanks!

ah that makes sense thanks!
floatingghost merged commit 6a9764951f into develop 2023-03-10 18:56:32 +00:00
floatingghost deleted branch fix-realtime-reply-filter 2023-03-10 18:56:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No Label
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#285
No description provided.
Delete Branch "flisk/akkoma-fe:fix-realtime-reply-filter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?