only fetch privileged resources when appropriate #288

Closed
flisk wants to merge 1 commits from flisk:only-fetch-when-authenticated into develop
Contributor

always doing these fetches regardless of whether they'll reasonably succeed is silly and causes a bunch of spurious 403's, which end up as noise in the server logs. instead, let's not do that.

always doing these fetches regardless of whether they'll reasonably succeed is silly and causes a bunch of spurious 403's, which end up as noise in the server logs. instead, let's not do that.
Mergan added the
Feature
label 2023-03-15 21:16:10 +00:00
flisk force-pushed only-fetch-when-authenticated from 5167228e4a to 7fe848d1b3 2023-04-08 20:40:04 +00:00 Compare
Author
Contributor

rebased on current develop.

i'm not sure feature is an appropriate label. this seems rather like a bugfix to me.

rebased on current develop. i'm not sure `feature` is an appropriate label. this seems rather like a bugfix to me.

i think we may have inadvertantly both done this in the course of development

seems it's already been moved to after auth

i think we may have inadvertantly both done this in the course of development seems it's already been moved to after auth
Author
Contributor

oh shit thats right, i just noticed that the diff no longer makes sense

cool! closing.

oh shit thats right, i just noticed that the diff no longer makes sense cool! closing.
flisk closed this pull request 2023-04-14 16:34:48 +00:00

took the if clause though in c540764408

took the if clause though in c540764408ade606c69c4f2d07f68320c0d62c43
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful

Pull request closed

Sign in to join this conversation.
No description provided.