AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 81 Pull requests 19 Projects Releases 1 Wiki Activity

only fetch privileged resources when appropriate #288

Closed
flisk wants to merge 1 commit from flisk:only-fetch-when-authenticated into develop
pull from: flisk:only-fetch-when-authenticated
merge into: AkkomaGang:develop
Conversation 4 Commits 1 Files changed 1 +8
flisk commented 2023-03-11 13:39:34 +00:00
Contributor
Copy link

always doing these fetches regardless of whether they'll reasonably succeed is silly and causes a bunch of spurious 403's, which end up as noise in the server logs. instead, let's not do that.

always doing these fetches regardless of whether they'll reasonably succeed is silly and causes a bunch of spurious 403's, which end up as noise in the server logs. instead, let's not do that.
Mergan added the
Feature
 label 2023-03-15 21:16:10 +00:00
flisk force-pushed only-fetch-when-authenticated from 5167228e4a to 7fe848d1b3 2023-04-08 20:40:04 +00:00 Compare
flisk commented 2023-04-08 20:42:19 +00:00
Author
Contributor
Copy link

rebased on current develop.

i'm not sure feature is an appropriate label. this seems rather like a bugfix to me.

rebased on current develop. i'm not sure `feature` is an appropriate label. this seems rather like a bugfix to me.
floatingghost commented 2023-04-14 16:29:44 +00:00
Owner
Copy link

i think we may have inadvertantly both done this in the course of development

seems it's already been moved to after auth

i think we may have inadvertantly both done this in the course of development seems it's already been moved to after auth
flisk commented 2023-04-14 16:34:48 +00:00
Author
Contributor
Copy link

oh shit thats right, i just noticed that the diff no longer makes sense

cool! closing.

oh shit thats right, i just noticed that the diff no longer makes sense cool! closing.
flisk closed this pull request 2023-04-14 16:34:48 +00:00
floatingghost commented 2023-04-14 16:43:59 +00:00
Owner
Copy link

took the if clause though in c540764408

took the if clause though in c540764408ade606c69c4f2d07f68320c0d62c43
👍 1
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#288
No description provided.
Delete branch "flisk:only-fetch-when-authenticated"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?