AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 82 Pull requests 20 Projects Releases 1 Wiki Activity

Correctly link to BE commit in version tab #3

Merged
floatingghost merged 1 commit from :develop into develop 2022-06-17 11:56:12 +00:00
Conversation 1 Commits 1 Files changed 2 +15 -4
Ghost commented 2022-06-14 19:21:05 +00:00
First-time contributor
Copy link

currently unless the BE version is something like 2.5.0-20-gabcd123, the link will go to https://akkoma.dev/AkkomaGang/akkoma/commit, which 404s.

I haven't managed to find a way to link to the commit itself just from a tag/branch name, so this simply links to the history page of that commit, with it at the top. compromise :baa:

currently unless the BE version is something like `2.5.0-20-gabcd123`, the link will go to https://akkoma.dev/AkkomaGang/akkoma/commit, which 404s. I haven't managed to find a way to link to the commit itself just from a tag/branch name, so this simply links to the history page of that commit, with it at the top. compromise :baa:
Ghost added 1 commit 2022-06-14 19:21:05 +00:00
floatingghost commented 2022-06-17 11:56:08 +00:00
Owner
Copy link

bleh yeah this seems awkward as heck, this will do for now i suppose~

bleh yeah this seems awkward as heck, this will do for now i suppose~
floatingghost merged commit 3806f579b9 into develop 2022-06-17 11:56:12 +00:00
floatingghost referenced this pull request from a commit 2022-06-18 12:20:39 +00:00
Add tests to #3
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#3
No description provided.
Delete branch ":develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?