[bug] Posts that Quote an unfetchable post show no indication of being a quote post #310
Labels
No labels
a11y
Bug
Bug fix
cannot reproduce
CSS
Documentation
enhancement
Feature
Feature request
Held for next release cycle
Minor change
performance
priority: critical
priority: high
priority: low
priority: medium
priority: patch welcome
regression
Translation/Locale
WIP
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AkkomaGang/akkoma-fe#310
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Version
85abc62What were you trying to do?
I run an allowlist instance meaning i frequently run into the situation that someone quotes a post from an instance i do not have in my allowlist resulting in posts such as these:
https://ak.zweitekassabitte.jetzt/notice/AVVViYcSZafLKzS5eC
Original on snug.moe for comparison:
https://snug.moe/notes/9el1ms5ing
In this example the reason the post doesn't fetch is because cuddlegirls.cafe is down at the moment, but this same behaviour occurs with instances not on my allowlist having their posts quoted
What did you expect to happen?
Post displays some indicator that a quote is attached but is unable to load, or is filtered out entirely(potentially decided through filter broken threads setting)
What actually happened?
Post displays no indication that it is quoting a different post
Severity
I can manage
Have you searched for this issue?
When I check the Masto-API response, I see the
quote_idis null, so this may (partly?) be a BE issue as well.But I saw another example on fedi where the quote_id was filled in in the Mast-API, and the quote still didn't, so it seems also an FE issue. Maybe the quote was unable to show for other reasons? https://gayboyz.space/notice/AZ0YXfymtByH3ZHvpw
In both cases I expect to have a link to the quoted post in the content. But in both cases, I see in the Masto-API that the "RE: $quote_url" hasn't been added. So that may also be a BE issue with InlineQuotePolicy.
It currently indiscrimnately hides the
RE: ...paragraph from the original post HTML (even if it existed; existence might be enforced via MRF)*, but also omits the display box for the quoted status (since it can't retrieve the status).This can happen for either private posts being quoted, or deleted posts.
The frontend could either just only hide the paragraph if
quote != null(relying on such a paragraph being present), or create a fancier box informing the post is unavailable and showing the quoted AP id; see: AkkomaGang/akkoma#991(If/when we gain a way to fetch private posts on request with user keys instead of the generic actor, the latter option might also offer a button to attempt to fetch the post with one’s own signing key if the quoting post is followers-only. But that’s future talk, for now just the first option will be good enough too (and doesn't even depend on AkkomaGang/akkoma#991))
Oneric referenced this issue from AkkomaGang/akkoma2025-10-12 16:48:43 +00:00