[bug] Notification filter selector broken in german language #317
Labels
No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: AkkomaGang/akkoma-fe#317
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Version
2023.05
What were you trying to do?
I opened the filter settings for the notifications with german frontend.
What did you expect to happen?
I expected the filter selection to look similar to the other languages.
What actually happened?
The last item in the filter selection has a pretty long translation, which increases the size of the filter box and thus moves it more to the left.
At this point it is somehow behind the timeline and i am unable to read the settings.
The only way i could find to make this usable, is switching to another language.
Severity
I cannot use it as easily as I'd like
Have you searched for this issue?
I cannot reproduce this as of8afbe5e3bc, save for different text the filter settings appear and work the same as in English.Tested with Firefox ESR115 and Chromium 119.Perhaps it was fixed since filing, could you recheck @django ?Am dumb, tested the wrong thing
I just created a test instance using docker.
I installed the frontend with
./docker-resources/manage.sh mix pleroma.frontend install pleroma-fe --ref stableIt looks still broken to me in firefox(119) and chromium (119).
Should i install the frontend in a different way?
I just followed the instructions on https://docs.akkoma.dev/stable/installation/docker_en/
Edit:
i installed the develop ref and updated the config in the frontend management to switch to the develop ref. This did not change anything regarding this issue.
You didn’t nothing wrong, my bad. Thanks for checking and sorry for the trouble, I somehow got confused which filter setting is affected when testing.
To properly fix this for any long text, two approaches come to mind:
Unfortunately, I’m not familiar enough with CSS to whip up a solution with confidence it won't break something else.
However, for this particular case there’s another simple workaround: the translation is not long by necessity but because it is too literal.
"Ende beteiligter Umfragen"conveys the same meaning and is much shorter avoiding the width overflow.From a glance at the current localisations for all notification filter settings, it appears besides German only Dutch and Spanish have long enough localisations here to also be affected (for the same field even). Indeed a quick check confirms Spanish is also affected the same way and for Dutch the checkboxes are just barely still half-visible.
Ideally, the popup could work with any string length, but since too long translations aren't desirable either shortening the text seems like a good idea regardless. I suggested the above in Weblate, idk who can approve it. For Dutch and Spanish someone else will need to check if it can be shortened.
grep of all localisations for the notification filter settings
Thanks for checking again and your help so far. :)
I am sadly also not well versed enough in css to fix this issue.