[bug] animated emoji not detected when file name in the URL doesn't have extension #337

New Issue

Closed

opened 2023-08-22 08:49:33 +00:00 by xarvos · 3 comments

xarvos commented

2023-08-22 08:49:33 +00:00

Contributor

Version

174f98b1cb

What were you trying to do?

Viewing a post: https://fedi.criminallycute.fi/notice/AYwybe0Pw7aTGlcWdE

What did you expect to happen?

Animated emoji should pause

What actually happened?

Animated emoji react from misskey doesn't

Severity

I can manage

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Version 174f98b1cb0c3f506026f15f4efbde59739b8264 ### What were you trying to do? Viewing a post: https://fedi.criminallycute.fi/notice/AYwybe0Pw7aTGlcWdE ### What did you expect to happen? Animated emoji should pause ### What actually happened? Animated emoji react from misskey doesn't ### Severity I can manage ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.

xarvos commented

2023-08-22 08:52:36 +00:00

Author

Contributor

It looks like:

the detection depends on file name from the URL
file name in misskey URL is UUID and does not have the extension. the extension is included in the file name in content-disposition header, and the content-type is marked as image/png, however

why do we check the file extension and not the mime type again?

It looks like: - the detection depends on file name from the URL - file name in misskey URL is UUID and does not have the extension. the extension is included in the file name in `content-disposition` header, and the `content-type` is marked as `image/png`, however why do we check the file extension and not the mime type again?

floatingghost commented

2023-08-22 10:01:51 +00:00

Owner

please ensure you correctly fill out the issue form, since this helps us prioiritise issues

this is not a "I cannot use the software"-level issue

please ensure you correctly fill out the issue form, since this helps us prioiritise issues this is not a "I cannot use the software"-level issue

xarvos commented

2023-08-22 12:29:41 +00:00

Author

Contributor

sorry, i updated that.

as for the commit, it's actually https://code.criminallycute.fi/CriminallyCute/criminallycute-fe/commit/7b10d8f, the admin clone the repo mainly to add CI so I linked the latest merged commit from upstream

sorry, i updated that. as for the commit, it's actually https://code.criminallycute.fi/CriminallyCute/criminallycute-fe/commit/7b10d8f, the admin clone the repo mainly to add CI so I linked the latest merged commit from upstream