[bug] brick after media upload fail

Crafti commented

2023-09-02 09:49:06 +00:00

Version

e530c2b

What were you trying to do?

Upload a media attachment

What did you expect to happen?

For it to appear in the media tray

What actually happened?

No attachment was added, this error is being thrown in the console

TypeError: t is undefined
    r file_type.service.js:9
    data attachment.js:57

Trying to send the post, can cause two different errors.

Server returns 422 "Cannot post an empty status without attachments" because the post was empty
Server returns 400 "Internal server error" because the FE tried to submit media_ids[] set to undefined

In either cases the FE displays following message: Error: t.text is undefined

Refreshing the FE causes it to refuse to render the page with the TypeError mentioned before, thus being bricked.

If this was done while replying to someone, it becomes impossible to reopen or toggle the replying form again, with following error:

TypeError: e is null
    [...]
    tn status.js:90
    toggleReplying status.js:482
    [...]
    8948/Ot</e[0]< reply_button.vue:8
    [...]

Severity

I cannot use it as easily as I'd like

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Version e530c2b ### What were you trying to do? Upload a media attachment ### What did you expect to happen? For it to appear in the media tray ### What actually happened? No attachment was added, this error is being thrown in the console ``` TypeError: t is undefined r file_type.service.js:9 data attachment.js:57 ``` Trying to send the post, can cause two different errors. 1. Server returns 422 "Cannot post an empty status without attachments" because the post was empty 2. Server returns 400 "Internal server error" because the FE tried to submit `media_ids[]` set to `undefined` In either cases the FE displays following message: `Error: t.text is undefined` Refreshing the FE causes it to refuse to render the page with the TypeError mentioned before, thus being bricked. If this was done while replying to someone, it becomes impossible to reopen or toggle the replying form again, with following error: ``` TypeError: e is null [...] tn status.js:90 toggleReplying status.js:482 [...] 8948/Ot</e[0]< reply_button.vue:8 [...] ``` ### Severity I cannot use it as easily as I'd like ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.

👍 1

Mergan added the

Bug

label

2023-09-05 07:36:33 +00:00

norm commented

2023-09-19 05:38:01 +00:00

Contributor

Hit that same error just now.

The only way to recover is deleting local storage from the Inspect tool.

For the record, this is in Firefox. I was able to upload the same attachment in Google Chrome.

Hit that same error just now. The only way to recover is deleting local storage from the Inspect tool. For the record, this is in Firefox. I was able to upload the same attachment in Google Chrome.

Riedler commented

2025-09-10 01:19:53 +00:00

Contributor

was the attachment a bmp image? if not, can you upload the attachment somewhere and link it? this seems similar to #396

norm commented

2025-09-10 20:38:26 +00:00

Contributor

Sorry, it's been a while. I don't think I've had that issue happen since, and I don't have whatever I was trying to upload at the time on hand anymore.

😕 1

Oneric commented

2025-09-10 20:57:05 +00:00

Owner

This generally happened afairc when the upload failed with an error response. We fixed the issues in the backend (if any) leading to such responses, so e.g. BMP files work now.

However we left this open, becuase regardless of what the backend returns, the frontend shouldn’t save invalid data to its internal state in such a way it completely bricks itself. Instead it should display an erorr popup with any information and not modify the attachment state at all.
You can probably reproduce the bricking issue with a local dev server by stubbing out the upload endpoint to always return a HTTP 500 error.

This generally happened afairc when the upload failed with an error response. We fixed the issues in the backend (if any) leading to such responses, so e.g. BMP files work now. However we left this open, becuase regardless of what the backend returns, the frontend shouldn’t save invalid data to its internal state in such a way it completely bricks itself. Instead it should display an erorr popup with any information and not modify the attachment state at all. You can probably reproduce the bricking issue with a local dev server by stubbing out the upload endpoint to always return a HTTP 500 error.

Riedler commented

2025-09-10 21:00:06 +00:00

Contributor

[…], the frontend shouldn’t save invalid data […] You can probably reproduce the bricking issue with a local dev server […]

oh, that's a very good point! I'll see if I can do anything tomorrow or so

> […], the frontend shouldn’t save invalid data […] You can probably reproduce the bricking issue with a local dev server […] oh, that's a very good point! I'll see if I can do anything tomorrow or so