Do not copy all emojis in recentEmoji getter #340

Merged

floatingghost merged 1 commit from sn0w/akkoma-fe:feature/optimize-recent-emojis into develop

2023-09-25 13:24:13 +00:00

sn0w commented

2023-09-03 14:37:06 +00:00

Contributor

Currently the recentEmojis getter performs a concat of rootState.instance.emoji and rootState.instance.customEmoji.
On instances with tons of emojis, this full copy can take forever.

In the case of cofe.rocks, emoji-reacting to a post will cause the browser to spend 7 seconds in Array.prototype.concat followed by a then relatively quick find call (~ 1-2 secs).

This PR changes the code to avoid the copy and instead performs two separate searches.
Profiles of reacting to a post before and after the patch are attached (both with JIT disabled, but enabling JIT only makes the concat about 1-2 secs faster so it doesn't change much).

If the resulting object must be copied in a final step to avoid state issues let me know, I'm not deep enough into Vue to judge that.

Currently the recentEmojis getter performs a concat of `rootState.instance.emoji` and `rootState.instance.customEmoji`. On instances with tons of emojis, this full copy can take forever. In the case of cofe.rocks, emoji-reacting to a post will cause the browser to spend 7 seconds in `Array.prototype.concat` followed by a then relatively quick `find` call (~ 1-2 secs). This PR changes the code to avoid the copy and instead performs two separate searches. Profiles of reacting to a post before and after the patch are attached (both with JIT disabled, but enabling JIT only makes the concat about 1-2 secs faster so it doesn't change much). If the resulting object must be copied in a final step to avoid state issues let me know, I'm not deep enough into Vue to judge that.

2023-09-03T15:53:08,695690123+02:00.png

115 KiB

2023-09-03T16:34:29,128627443+02:00.png

105 KiB