AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 81 Pull requests 19 Projects Releases 1 Wiki Activity

Drop broken "@ symbol as icon" setting #359

Merged
floatingghost merged 1 commit from Oneric/akkoma-fe:at-icon into develop 2023-11-16 10:41:18 +00:00
Conversation 1 Commits 1 Files changed 12 -21
Oneric commented 2023-11-15 23:03:31 +00:00
Member
Copy link

It was merged into pleroma-fe on 2022-02-03 in
76547fe66d and imported
into akkoma-fe on 2022-06-08 with the merge commit
f6cf509a04.

However, something went wrong in the merge and while the setting
and its infrastructure exist, it is never used anywhere and @ is
always displayed as text.

Given it existed in this broken state for nearly one and a half years,
never worked on akkoma-fe and no bugs were filed about this, it appears
nobody cares, so let’s just remove it.

Resolves #358

It was merged into pleroma-fe on 2022-02-03 in 76547fe66d1771f5bff732a34b0547f890f4621a and imported into akkoma-fe on 2022-06-08 with the merge commit f6cf509a046507eeb9e52e2a279e82dd7a0f6bf8. However, something went wrong in the merge and while the setting and its infrastructure exist, it is never used anywhere and @ is always displayed as text. Given it existed in this broken state for nearly one and a half years, never worked on akkoma-fe and no bugs were filed about this, it appears nobody cares, so let’s just remove it. Resolves #358
Oneric added 1 commit 2023-11-15 23:03:32 +00:00
Drop broken "@ symbol as icon" setting
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
c524a47e6f 
It was merged into pleroma-fe on 2022-02-03 in
76547fe66d and imported
into akkoma-fe on 2022-06-08 with the merge commit
f6cf509a04.

However, something went wrong in the merge and while the setting
and its infrastructure exist, it is never used anywhere and @ is
always displayed as text.

Given it existed in this broken state for nearly one and a half years,
never worked on akkoma-fe and no bugs were filed about this, it appears
nobody cares, so let’s just remove it.
floatingghost commented 2023-11-16 10:41:10 +00:00
Owner
Copy link

hehe, i think i removed this on my local fork and that ended up being inhereted into akkoma when i made it a thing proper

yea, let's yeet it

thanks!

hehe, i _think_ i removed this on my local fork and that ended up being inhereted into akkoma when i made it a thing proper yea, let's yeet it thanks!
floatingghost merged commit 40a08f279b into develop 2023-11-16 10:41:18 +00:00
floatingghost deleted branch at-icon 2023-11-16 10:41:18 +00:00
mel referenced this pull request from a commit 2024-05-15 22:36:01 +00:00
Squashed commit of the following:
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#359
No description provided.
Delete branch "Oneric/akkoma-fe:at-icon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?