AkkomaGang/akkoma-fe
4
13
Fork 58
Code Issues 75 Pull requests 15 Projects Releases 1 Wiki Activity

Make animated emojis in reactions pause #378

Merged
floatingghost merged 2 commits from sarayalth/akkoma-fe:pause-animated-reaction into develop 2024-05-28 02:25:02 +00:00
Conversation 1 Commits 2 Files changed 2 +7 -4
sarayalth commented 2024-03-01 19:44:30 +00:00
Contributor
Copy link

when the option "Pause animated images until you hover on them" is enabled the notifications about reactions that have animated emojis don't pause, this PR just makes them follow that toggle

image

when the option "Pause animated images until you hover on them" is enabled the notifications about reactions that have animated emojis don't pause, this PR just makes them follow that toggle ![image](/attachments/87e07060-623a-4a25-a6f0-0911f8be54ca)
image.png
38 KiB
sarayalth added 1 commit 2024-03-01 19:44:30 +00:00
make animated reactions pause unless hovered on notifications
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
1f5f8665c8
Oneric reviewed 2024-05-13 00:13:18 +00:00
Oneric left a comment
Member
Copy link

Thanks for the fix and sorry it took so long; one question though

Thanks for the fix and sorry it took so long; one question though
src/components/notification/notification.vue Outdated
@ -120,2 +119,3 @@
<still-image
v-if="notification.emoji_url !== null"
class="notification-reaction-emoji"
class="notification-reaction-emoji emoji img"
Oneric commented 2024-05-13 00:12:33 +00:00
Member
Copy link

why did you add generic img and emoji classes here? Removing them doesn’t seem to make a difference and on a cursory search no matching selectors seem to exist; did i miss something?

why did you add generic `img` and `emoji` classes here? Removing them doesn’t seem to make a difference and on a cursory search no matching selectors seem to exist; did i miss something?
sarayalth commented 2024-05-14 16:05:37 +00:00
Author
Contributor
Copy link

honestly, i don't remember why those are there, i just tested myself and it seems to work fine without them

honestly, i don't remember why those are there, i just tested myself and it seems to work fine without them
👍 1
sarayalth added 1 commit 2024-05-14 16:09:27 +00:00
remove unused classes on notifications
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
cc709394c5
Oneric approved these changes 2024-05-14 16:28:05 +00:00
floatingghost commented 2024-05-28 02:24:58 +00:00
Owner
Copy link

thanks!

thanks!
floatingghost merged commit 8964dce609 into develop 2024-05-28 02:25:02 +00:00
floatingghost deleted branch pause-animated-reaction 2024-05-28 02:25:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Oneric
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#378
No description provided.
Delete branch "sarayalth/akkoma-fe:pause-animated-reaction"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?