[bug] still-image doesn't detect extensionful APNG with mediaproxy off #381

New issue

Open

opened 2024-03-26 22:52:29 +00:00 by novenary · 1 comment

novenary commented

2024-03-26 22:52:29 +00:00

Version

ed0b403

What were you trying to do?

Uploaded an APNG image.
https://akko.wtf/notice/Ag95iENE4XtQrDMXKa

What did you expect to happen?

With still-image enabled, the image should not animate.

What actually happened?

The image animates.

This is because still-image only falls back to detectAnimationWithFetch with extensionless URLs. Additionally, it will still greedily mark local .gif and .webp images as animated, even though CORS would allow fetching them just fine.

       // Hail mary for extensionless
       if (extension.includes('/')) {
         // Don't mind the CORS error barrage
         this.detectAnimationWithFetch(image)
       }

I know it's basically impossible to reliably detect animated images without mediaproxy, but it should at least work correctly for local media. :P

Severity

I can manage

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Version ed0b403 ### What were you trying to do? Uploaded an APNG image. https://akko.wtf/notice/Ag95iENE4XtQrDMXKa ### What did you expect to happen? With still-image enabled, the image should not animate. ### What actually happened? The image animates. This is because still-image only falls back to detectAnimationWithFetch with extensionless URLs. Additionally, it will still greedily mark local .gif and .webp images as animated, even though CORS would allow fetching them just fine. https://akkoma.dev/AkkomaGang/akkoma-fe/src/commit/ed0b403c330914ed10c391d4c7ac9f5f9e606da8/src/components/still-image/still-image.js#L114-L118 I know it's basically impossible to reliably detect animated images without mediaproxy, but it should at least work correctly for local media. :P ### Severity I can manage ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.

Oneric commented

2024-03-27 00:25:45 +00:00

Member

Tangential note: while .png is often used as well (like in the example post), the canonical extension for APNG images is .apng. Regardless of local or not, we could always match at least the latter.

Tangential note: while `.png` is often used as well *(like in the example post)*, the [canonical extension](https://www.iana.org/assignments/media-types/image/apng) for APNG images is `.apng`. Regardless of local or not, we could always match at least the latter.