[bug] Favorites are being rearranged by post date despite API serving by favorite date, messing up scrolling #391
Labels
No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: AkkomaGang/akkoma-fe#391
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Version
ed0b403c33
What were you trying to do?
browse my favorites
What did you expect to happen?
see my favorites sorted in the order i favorited them, without the ui going all herp derp and jumping all over the place
What actually happened?
it seems the frontend is sorting the posts by post date, despite the back end serving them in order of favorite date, which is causing the frontend to spazz out, as it puts oldest posts at the bottom, and then when you scroll near the bottom, posts of miscellaneous dates are inserted all over the list, pushing the content down, making it very difficult to get to the posts at the bottom as they keep getting pushed down. very annoying
Severity
I cannot use the software
Have you searched for this issue?
I think the below should fix it. Can you confirm?:
There are some userId related checks before that though, if you’re actually running develop + the current iteration of your public-favourites patch its userID mangling might affect this too. On the other hand, if as suggested public favourites get added as a distinct
publicFavorits
timeline, some of the processing above the changed line probabaly also needs to be updated to treat them likefavorites
this works. favorites line is working properly
thx, opened #392