Misc fixes #416

Open

novenary wants to merge 6 commits from novenary/akkoma-fe:misc-fixes/2024-09-17 into develop

novenary commented

2024-09-17 09:35:05 +00:00

First-time contributor

This is a collection of bug fixes and minor UX improvements based on my own experience using akkoma-fe.

Individual commits are rather small, so I'm submitting them together, but I can split up the PR if needed.

This is a collection of bug fixes and minor UX improvements based on my own experience using akkoma-fe. Individual commits are rather small, so I'm submitting them together, but I can split up the PR if needed.

novenary added 3 commits 2024-09-17 09:35:05 +00:00

post_status_form: fix enter key in subject field 5886765d89

This fixes random actions being triggered by the enter key while the
subject field is focused.

When pressing enter, the browser simulates a click on the first "submit"
button it finds in the form.
A submit button is a button without `type="button"` set.
Remediate this by setting the type attribute on all but the "Post"
button.

Additionally, inhibit the enter key in the subject field (ctrl+enter
still works).

emoji_picker: select recents tab by default 2765a5c163

This saves a click to get at your most commonly used emoji.

emoji_input: show more suggestions 7b8429aa24

5 suggestions is really too little, so increase the limit and make the
list scrollable.

novenary force-pushed misc-fixes/2024-09-17 from c2b2f59c03 to 67c0143b1f

2024-09-17 18:17:00 +00:00

Compare

novenary changed title from ~~WIP: Misc fixes~~ to Misc fixes

2024-09-17 22:12:35 +00:00

novenary force-pushed misc-fixes/2024-09-17 from 8b5ebe10ab to c6de61e081

2024-09-20 15:45:15 +00:00

Compare

Oneric approved these changes 2024-10-14 21:30:07 +00:00

Oneric left a comment

Member

Been using it for a while without noticing any problems, though i rarely use the thread expand/collapse feature so I’m excluding this here; I don’t have any suggestions for the /* HACK */ part of its commit either.

I don’t feel qualified to judge whether the hardcoded values in the “more emoji” commit are sensible or the right approach, but for all other commits the code seems good to me too. Barring complaints from someone better versed in JS and HTML/CSS than me about the excluded parts, this seems like a good improvement to me; thanks!

Been using it for a while without noticing any problems, though i rarely use the thread expand/collapse feature so I’m excluding this here; I don’t have any suggestions for the `/* HACK */` part of its commit either. I don’t feel qualified to judge whether the hardcoded values in the “more emoji” commit are sensible or the right approach, but for all other commits the code seems good to me too. Barring complaints from someone better versed in JS and HTML/CSS than me about the excluded parts, this seems like a good improvement to me; thanks!

Oneric commented

2024-10-14 21:40:45 +00:00

Member

Well, one minor nit afterall: initially the recent emoji tab is empty and actually can't be selected interactively. Defaulting to it leads to a blank page being present on first use and being in a category which isn’t meant to be selectable. Ideally the default would be “recent if non-empty, otherwise”

novenary commented

2024-10-15 06:43:33 +00:00

Author

First-time contributor

Ah yeah, I would've missed that, thanks.

I'm also unhappy with the use of scrollIntoView for emoji suggestions, it causes some weird problems because it tries to adjust all parent scrollports. I think it'd be simpler to the scrolling manually.

(this one is actually fixed by other unsubmitted work, but I think the manual solution would still be cleaner overall)

Ah yeah, I would've missed that, thanks. I'm also unhappy with the use of scrollIntoView for emoji suggestions, it causes some weird problems because it tries to adjust all parent scrollports. I think it'd be simpler to the scrolling manually. ![image](/attachments/4db45dc3-e151-422f-8b62-24a99d5933ee) (this one is actually fixed by other unsubmitted work, but I think the manual solution would still be cleaner overall)

image.png

293 KiB