AkkomaGang/akkoma-fe
5
13
Fork 62
Code Issues 81 Pull requests 19 Projects Releases 1 Wiki Activity

Misc fixes #416

Open
novenary wants to merge 6 commits from novenary/akkoma-fe:misc-fixes/2024-09-17 into develop
pull from: novenary/akkoma-fe:misc-fixes/2024-09-17
merge into: AkkomaGang:develop
Conversation 0 Commits 6 Files changed 10 +58 -13
novenary commented 2024-09-17 09:35:05 +00:00
First-time contributor
Copy link

This is a collection of bug fixes and minor UX improvements based on my own experience using akkoma-fe.

Individual commits are rather small, so I'm submitting them together, but I can split up the PR if needed.

This is a collection of bug fixes and minor UX improvements based on my own experience using akkoma-fe. Individual commits are rather small, so I'm submitting them together, but I can split up the PR if needed.
novenary added 5 commits 2024-09-17 09:35:05 +00:00 
This fixes random actions being triggered by the enter key while the
subject field is focused.

When pressing enter, the browser simulates a click on the first "submit"
button it finds in the form.
A submit button is a button without `type="button"` set.
Remediate this by setting the type attribute on all but the "Post"
button.

Additionally, inhibit the enter key in the subject field (ctrl+enter
still works).
This saves a click to get at your most commonly used emoji.
5 suggestions is really too little, so increase the limit and make the
list scrollable.
post_status_form: inherit language from parent
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
c2b2f59c03 
If I'm replying to a post in Klingon, chances are I'm going to write in
Klingon. This reduces friction for properly marking post language in a
conversation.
novenary force-pushed misc-fixes/2024-09-17 from c2b2f59c03 to 67c0143b1f 2024-09-17 18:17:00 +00:00 Compare
novenary added 1 commit 2024-09-17 22:08:03 +00:00
conversation: scrollIntoView when collapsed
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
8b5ebe10ab 
This helps find the original context when collapsing a thread on the
timeline.
novenary changed title from WIP: Misc fixes to Misc fixes 2024-09-17 22:12:35 +00:00
novenary force-pushed misc-fixes/2024-09-17 from 8b5ebe10ab to c6de61e081 2024-09-20 15:45:15 +00:00 Compare
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u misc-fixes/2024-09-17:novenary-misc-fixes/2024-09-17
git checkout novenary-misc-fixes/2024-09-17
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#416
No description provided.
Delete branch "novenary/akkoma-fe:misc-fixes/2024-09-17"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?