AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 82 Pull requests 20 Projects Releases 1 Wiki Activity

[#44] i18n/fix-format #45

Merged
floatingghost merged 3 commits from i18n/fix-format into develop 2022-07-19 10:12:37 +00:00
Conversation 1 Commits 3 Files changed 28 +824 -755
floatingghost commented 2022-07-19 10:03:18 +00:00
Owner
Copy link

units got moved to units

units got moved to `units`
floatingghost added 3 commits 2022-07-19 10:03:19 +00:00
fix time formats
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
a32cd0a98c
remove debug log
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
eb47bb8973
lint
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
606e850aad
floatingghost merged commit 137bf5557c into develop 2022-07-19 10:12:37 +00:00
floatingghost deleted branch i18n/fix-format 2022-07-19 10:12:39 +00:00
norm commented 2022-07-26 21:19:08 +00:00
Contributor
Copy link

Apparently the change was meant to remove the assumption that time units have separate singular/plural forms (see https://git.pleroma.social/pleroma/pleroma-fe/-/issues/1164).

This change results in only plural units being shown where there is a distinction between singular/plural units. The real fix is letting vue-i18n determine which form to use (E.g. https://git.pleroma.social/pleroma/pleroma-fe/-/merge_requests/1535/diffs?commit_id=772ddade2123595817a16a2f9c56824a87f9e97c).

Apparently the change was meant to remove the assumption that time units have separate singular/plural forms (see https://git.pleroma.social/pleroma/pleroma-fe/-/issues/1164). This change results in only plural units being shown where there is a distinction between singular/plural units. The real fix is letting vue-i18n determine which form to use (E.g. https://git.pleroma.social/pleroma/pleroma-fe/-/merge_requests/1535/diffs?commit_id=772ddade2123595817a16a2f9c56824a87f9e97c).
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#45
No description provided.
Delete branch "i18n/fix-format"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?