[Bug] custom emoji reaction popover gets confused when two reactions have the same key #80

New issue

Closed

opened 2022-07-29 23:14:39 +00:00 by floatingghost · 0 comments

floatingghost commented

2022-07-29 23:14:39 +00:00

Owner

so if user_a@first reacted with :maid_nod: (url: first/somewhere), and user_b@second reacted with :main_nod: (url: second/somewhere), the frontend popover shows user_a@first as having reacted with both

this is likely just due to the way the FE filters the /reactions output - we should filter it by image URL instead

custom emoji are uniq'd on the backend via their URL (since instances may use the same key for different emoji), but the list of "who reacted" in the frontend gets confused when this happens, and assigns the same set of reactors to both popovers so if `user_a@first` reacted with `:maid_nod: (url: first/somewhere)`, and `user_b@second` reacted with `:main_nod: (url: second/somewhere)`, the frontend popover shows `user_a@first` as having reacted with both this is likely just due to the way the FE filters the `/reactions` output - we should filter it by image URL instead