[Bug] MFM parser issues #86

New Issue

Closed

opened 2022-07-31 16:21:40 +00:00 by Beefox · 8 comments

Beefox commented

2022-07-31 16:21:40 +00:00

Contributor

Copy Link

there are currrent mfm parser issues:
example posts are: https://myfriendsare.gay/notice/AM3UOQjPrKCqF8t0L2
this post lists all common mfm things, many of which do not seem to work.

List of working mfm tags:

Plain
Bold
Italics
Small
Quote
Center
Inline code
Code block
Flip
Font
x2
x3
x4
Blur
Jelly
Tada
Jump
Bounce
Spin
Shake
Twitch
Rainbow
Sparkle
Rotate

there are currrent mfm parser issues: example posts are: https://myfriendsare.gay/notice/AM3UOQjPrKCqF8t0L2 this post lists all common mfm things, many of which do not seem to work. List of working mfm tags: - [ ] Plain - [x] Bold - [x] Italics - [ ] Small - [ ] Quote - [ ] Center - [ ] Inline code - [ ] Code block - [x] Flip - [x] Font - [x] x2 - [x] x3 - [x] x4 - [ ] Blur - [x] Jelly - [x] Tada - [ ] Jump - [ ] Bounce - [x] Spin - [x] Shake - [x] Twitch - [x] Rainbow - [ ] Sparkle - [x] Rotate

nbsp commented

2022-07-31 18:05:57 +00:00

Contributor

Copy Link

sparkle, bounce, jump and blur are correctly tokenized and just need to be handled by pleroma-fe (fun fact, in Misskey sparkle is entirely handled by Misskey itself and not the mfm.js library, meaning it's.. nonstandard???)
plain is deliberately unsupported in marked-mfm, in favor of standard markdown backslash escaping (not yet pushed to pleroma-fe, i'm holding that version until i fix some other stuff)
center is annoying and i'm gonna fix it hopefully
small and quote... ~~i don't know what the deal with those are honestly, they work in the dingus~~ UPDATE it's probably html encoding < > into < > and not letting them parse
i think inline code works, you just omitted the last ` on that line
codeblock... h, that bug looks annoying

- sparkle, bounce, jump and blur are correctly tokenized and just need to be handled by pleroma-fe (fun fact, in Misskey sparkle is *entirely* handled by Misskey itself and not the mfm.js library, meaning it's.. nonstandard???) - plain is deliberately unsupported in marked-mfm, in favor of standard markdown backslash escaping (not yet pushed to pleroma-fe, i'm holding that version until i fix some other stuff) - center is annoying and i'm gonna fix it hopefully - small and quote... ~~i don't know what the deal with those are honestly, they work in the dingus~~ UPDATE it's probably html encoding `<` `>` into `<` `>` and not letting them parse - i think inline code works, you just omitted the last ` on that line - codeblock... h, that bug looks annoying

Beefox commented

2022-08-01 00:41:19 +00:00

Author

Contributor

Copy Link

inline code yeah you're probably right xD

nbsp commented

2022-08-01 06:12:45 +00:00

Contributor

Copy Link

center and escaped are implemented in marked-mfm 0.5.0
small is fixed in a backend branch that needs to be merged

quote is a backend thing, might wanna open an issue there
sparkle, bounce, jump and blur are frontend

i'll look into codeblock later

center and escaped are implemented in marked-mfm 0.5.0 small is fixed in a backend branch that needs to be merged quote is a backend thing, might wanna open an issue there sparkle, bounce, jump and blur are frontend i'll look into codeblock later

nbsp referenced this issue

2022-08-01 06:41:36 +00:00

Fix broken MFM tags #93

nbsp added a new dependency 2022-08-01 14:54:25 +00:00

#96 Fix code blocks not working in MFM

eris added the

Bug

label 2022-08-01 18:04:37 +00:00

TransGal4872 commented

2022-08-08 05:39:29 +00:00

Copy Link

(We don't run an instance so it feels kind of silly to make an account here but we were told to)

-Nim

I'm reporting that the <> characters can erase words, sentances (with spaces), and paragraphs (with line breaks) that are not valid tags, which does not match the behavior of MFM on Misskey; the erased tag does show correctly on Misskey (We don't run an instance so it feels kind of silly to make an account here but we were told to) -Nim

tmp.png

10 KiB

tmp_.png

15 KiB

nbsp commented

2022-08-08 06:55:00 +00:00

Contributor

Copy Link

I'm reporting that the <> characters can erase words, sentances (with spaces), and paragraphs (with line breaks) that are not valid tags, which does not match the behavior of MFM on Misskey; the erased tag does show correctly on Misskey

(We don't run an instance so it feels kind of silly to make an account here but we were told to)

-Nim

explained more clearly on fedi but this is not an mfm thing and it's expected (though slightly weird) behaviour

> I'm reporting that the <> characters can erase words, sentances (with spaces), and paragraphs (with line breaks) that are not valid tags, which does not match the behavior of MFM on Misskey; the erased tag does show correctly on Misskey > > (We don't run an instance so it feels kind of silly to make an account here but we were told to) > > -Nim explained more clearly on fedi but this is not an mfm thing and it's expected (though slightly weird) behaviour

Mergan commented

2022-08-31 06:45:57 +00:00

Member

Copy Link

@floatingghost Status with backend MFM parser?

floatingghost commented

2022-09-09 01:31:57 +00:00

Owner

Copy Link

backend parser is working, and honestly we shouldn't care that much about matching misskey behaviour 1-to-1, since it does a lot of things that make no sense

posting things between < and > should indeed get stripped since you've made an HTML tag

backend parser is working, and honestly we shouldn't care that much about matching misskey behaviour 1-to-1, since it does a lot of things that make no sense posting things between `<` and `>` should indeed get stripped since you've made an HTML tag

nbsp commented

2022-12-13 15:36:21 +00:00

Contributor

Copy Link

closing since MFM is handled in the backend through mfm-parser

closing since MFM is handled in the backend through `mfm-parser`

nbsp closed this issue

2022-12-13 15:36:21 +00:00

No Branch/Tag Specified

Branches Tags

develop

translations

stable

dm-privacy

paginate-follow-requests

link-verification

cypress

i18n

branch-artifact

marked-mfm

build-on-merge

woodpecker

v3.11.0

v3.10.0

2023.05

2023.04

2023.03

2.4.5-2

2.4.5-1

2.4.5

2.4.4-1

2.4.4

2.4.3

ci-1

ci-0

2.4.2

2.4.0

2.3.0

2.2.3

2.2.2

2.2.1

2.2.0

2.1.2

2.1.1

2.1.0

2.0.5

2.0.3

2.0.2

0.9.999

0.9.99

0.9.9

Labels

Clear labels

a11y

Issues and PRs about accessibility

Bug

Applies to issues describing bugs

Bug fix

Pull requests that squash bugs

Critical Priority

Documentation

Feature

Pull requests that implement new features

Feature request

Issues that request new features

Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

For minor changes, ie CSS alignment changes

Translation/Locale

For changes related to translations

No Label

Held for next release cycle

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on

#96 Fix code blocks not working in MFM

AkkomaGang/akkoma-fe

Reference: AkkomaGang/akkoma-fe#86

Reference in New Issue

Repository

AkkomaGang/akkoma-fe

Title

Body

No description provided.

Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?