AkkomaGang
/
akkoma-fe
4
13
Fork 57
Code Issues 72 Pull Requests 17 Projects Releases 1 Wiki Activity

[Bug] Thread Breaking on Some Locked Posts When I Follow Both People #89

New Issue
Closed
opened 2022-07-31 21:56:13 +00:00 by arcana · 10 comments
arcana commented 2022-07-31 21:56:13 +00:00
Copy Link

Screenshots anonymised due to being locked posts but the issue is that threads often break with certain users when the thread is locked. It will seem to be a new thread and I won't actually be able to see the post that is being replied to or any earlier posts in the thread

image
image

Screenshots anonymised due to being locked posts but the issue is that threads often break with certain users when the thread is locked. It will seem to be a new thread and I won't actually be able to see the post that is being replied to or any earlier posts in the thread ![image](/attachments/0d1ab99f-256c-49c5-8dc6-bdbed8bda551) ![image](/attachments/4c54de5c-c76f-4e90-9995-ee5b4c9a7f63)
image.png
19 KiB
image.png
7.1 KiB
image.png image.png
floatingghost commented 2022-07-31 22:53:44 +00:00
Owner
Copy Link

ok some debugging steps to help here

  1. open a broken reply (as pictured)
  2. open replace notice in the URL with api/v1/statuses - i.e instead of https://akko.disqordia.space/notice/ALypMnPy9EfONs8GOm, go to https://akko.disqordia.space/api/v1/statuses/ALypMnPy9EfONs8GOm
  3. check that the data includes in_reply_to_id, grab that string
  4. add /context to the end of the URL, should be https://akko.disqordia.space/api/v1/statuses/ALypMnPy9EfONs8GOm/context
  5. see if ancestors has anything in it
  6. go to https://akko.disqordia.space/api/v1/statuses/<in_reply_to_id>, with the ID from 4, see if you can see it

if 6 works but 5 doesn't i'll have something to narrow in on

ok some debugging steps to help here 1. open a broken reply (as pictured) 2. open replace `notice` in the URL with `api/v1/statuses` - i.e instead of `https://akko.disqordia.space/notice/ALypMnPy9EfONs8GOm`, go to `https://akko.disqordia.space/api/v1/statuses/ALypMnPy9EfONs8GOm` 3. check that the data includes `in_reply_to_id`, grab that string 4. add `/context` to the end of the URL, should be `https://akko.disqordia.space/api/v1/statuses/ALypMnPy9EfONs8GOm/context` 5. see if `ancestors` has anything in it 6. go to `https://akko.disqordia.space/api/v1/statuses/<in_reply_to_id>`, with the ID from 4, see if you can see it if 6 works but 5 doesn't i'll have something to narrow in on
arcana commented 2022-07-31 23:17:24 +00:00
Author
Copy Link
  1. in_reply_to_id is null

nothing in ancestors

3. in_reply_to_id is null nothing in ancestors
arcana commented 2022-07-31 23:17:58 +00:00
Author
Copy Link

I'll repeat these steps again if I see it again to try to get a bigger sample size

I'll repeat these steps again if I see it again to try to get a bigger sample size
floatingghost commented 2022-07-31 23:51:10 +00:00
Owner
Copy Link

ok not having in_reply_to_id means that we had trouble fetching the status they were replying to (or it wasn't filled in)

hm, might have to rope eris in here to get the backend AP data to check what's going on at some point

ok not having `in_reply_to_id` means that we had trouble fetching the status they were replying to (or it wasn't filled in) hm, might have to rope eris in here to get the backend AP data to check what's going on at some point
eris commented 2022-08-01 00:05:18 +00:00
Contributor
Copy Link

hm, might have to rope eris in here to get the backend AP data to check what's going on at some point

Watcha need me to do?

> hm, might have to rope eris in here to get the backend AP data to check what's going on at some point > Watcha need me to do?
floatingghost commented 2022-08-01 01:18:31 +00:00
Owner
Copy Link

this will be quite awkward i warn you

first, @arcana will need to look at the /api/v1/statuses/<id> endpoint as above

find the url that looks like "https://somewhere/objects/blah`

then on the machine itself, in postgres (probably psql akkoma_prod or similar), run select (data->>'inReplyTo') from objects where (data->>'id') = '<the id found above>';

this should return a single result

run select (data->>'id') from objects where (data->>'id') = '<the id the last command spat out>';

if this returns a single entry, then federation is fine, if it returns nothing, then we've got a federation issue (:()

this will be quite awkward i warn you first, @arcana will need to look at the `/api/v1/statuses/<id>` endpoint as above find the url that looks like "https://somewhere/objects/blah` then on the machine itself, in postgres (probably `psql akkoma_prod` or similar), run `select (data->>'inReplyTo') from objects where (data->>'id') = '<the id found above>';` this should return a single result run `select (data->>'id') from objects where (data->>'id') = '<the id the last command spat out>';` if this returns a single entry, then federation is fine, if it returns nothing, then we've got a federation issue (:()
arcana commented 2022-08-01 13:11:30 +00:00
Author
Copy Link

@eris the url is https://misskey.bubbletea.dev/notes/937u8irz7h

@eris the url is https://misskey.bubbletea.dev/notes/937u8irz7h
eris added the
Bug
 label 2022-08-01 18:04:28 +00:00
nbsp commented 2022-08-04 21:28:55 +00:00
Contributor
Copy Link

this seems like a federation issue from my testing, those commands return this:

 ?column? 
----------
(0 rows)
this seems like a federation issue from my testing, those commands return this: ``` ?column? ---------- (0 rows) ```
floatingghost commented 2022-08-04 21:30:07 +00:00
Owner
Copy Link

yep, this was indeed a federation issue

fixed in akkoma!#145 (praise helene)

yep, this was indeed a federation issue fixed in akkoma!#145 (praise helene)
floatingghost commented 2022-08-05 16:29:00 +00:00
Owner
Copy Link

tested, works, closing

tested, works, closing
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
develop
translations
stable
dm-privacy
paginate-follow-requests
link-verification
cypress
i18n
branch-artifact
marked-mfm
build-on-merge
woodpecker
v3.11.0
v3.10.0
2023.05
2023.04
2023.03
2.4.5-2
2.4.5-1
2.4.5
2.4.4-1
2.4.4
2.4.3
ci-1
ci-0
2.4.2
2.4.0
2.3.0
2.2.3
2.2.2
2.2.1
2.2.0
2.1.2
2.1.1
2.1.0
2.0.5
2.0.3
2.0.2
0.9.999
0.9.99
0.9.9
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No Label
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#89
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?