Add private note field to user profile #9

Ghost · 2022-06-22T15:50:42Z

Ghost commented

2022-06-22 15:50:42 +00:00

First-time contributor

again, something that's in the api thanks to mastodon but just isn't added in

one problem: this sends a fuck ton of API requests. one on each keystroke. I could add a save button but that's u g l y and i want it to just save whatever's there, but if there's no easy way to do that without sending that many requests i'll just add a button

didn't add any tests because there weren't any to add; no mutations were changed

again, something that's in the api thanks to mastodon but just isn't added in one problem: this sends a fuck ton of API requests. one on each keystroke. I could add a save button but that's u g l y and i want it to just save whatever's there, but if there's no easy way to do that without sending that many requests i'll just add a button didn't add any tests because there weren't any to add; no mutations were changed

Ghost force-pushed notes from 1c0ed32b6f to 9923ff587b

2022-06-22 16:15:27 +00:00

Compare

Ghost added 1 commit 2022-06-22 16:43:31 +00:00

Add debounce to API request

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

fb2fc686b1

Ghost commented

2022-06-23 10:12:14 +00:00

First-time contributor

hm, maybe this should be togglable

floatingghost commented

2022-06-23 10:26:03 +00:00

hm given that it's standard functionality it's ok not being togglable

the keystroke thing is annoying but search works the same way so it's cool

i'll try it out and see how it works

hm given that it's standard functionality it's ok not being togglable the keystroke thing is annoying but search works the same way so it's cool i'll try it out and see how it works

Ghost commented

2022-06-23 10:30:27 +00:00

First-time contributor

i fixed the keystrokes, it's debounced so it only triggers if there's been a 1.5s delay without being called again

floatingghost reviewed 2022-06-23 10:37:41 +00:00

floatingghost left a comment

hm, the debounce works, but given that there's no feedback as to whether the save has gone through yet, you can refresh the page and lose your note if you do it too fast

could probably have a little loading-spinner until debounce fires?

hm, the debounce works, but given that there's no feedback as to whether the save has gone through yet, you can refresh the page and lose your note if you do it too fast could probably have a little `loading-spinner` until debounce fires?

src/services/api/api.service.js Outdated

					
				@ -311,3 +312,3 @@

				const fetchUser = ({ id, credentials }) => {

				  let url = `${MASTODON_USER_URL}/${id}`

				  let url = `${MASTODON_USER_URL}/${id}` + '?with_relationships=true'