Flip order of accommodation for (#115) #118

Merged

floatingghost merged 1 commits from Mergan/pleroma-fe:emoji-picker into develop

2022-08-11 10:08:12 +00:00

Mergan commented

2022-08-06 00:02:49 +00:00

Member

There's just no space for the picker when it does that. Prefer bottom when spaceless in auto

Mergan added 1 commit 2022-08-06 00:02:50 +00:00

ci/woodpecker/pr/woodpecker Pipeline was successful Details

d69df0e906 Flip order of accommodation for (#115 )

floatingghost commented

2022-08-11 09:07:01 +00:00

Owner

with stable release on sat, is this in a WIP state or does it fix the issue (even if a bit hackily)?

Mergan commented

2022-08-11 09:13:09 +00:00

Author

Member

Yeah it should fix the issue (hacky though). Eris might've found something less hacky though-- haven't had time this week to test.

Oh by the way you can replicate it by simply making your window smaller. The emoji picker won't fit and it'll go upwards.

By reversing the order it should try upwards first and if not, bottom. Which in practice is more desirable, because we can scroll downwards, but not upwards.

Yeah it should fix the issue (hacky though). Eris might've found something less hacky though-- haven't had time this week to test. Oh by the way you can replicate it by simply making your window smaller. The emoji picker won't fit and it'll go upwards. ![image](/attachments/9ca68db8-559d-41c6-9d86-fb43d9f96c19) By reversing the order it should try upwards first and if not, bottom. Which in practice is more desirable, because we can scroll downwards, but not upwards.

image.png

49 KiB

floatingghost commented

2022-08-11 10:08:06 +00:00

Owner

it does seem to work, we can touch it up later if needed, but i guess fixing it at least hackily is good for stable - will merge this for now

thankies

it does seem to work, we can touch it up later if needed, but i guess fixing it at least hackily is good for stable - will merge this for now thankies

👍 1