AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 81 Pull requests 19 Projects Releases 1 Wiki Activity

New option: Pause MFM animations until status hover #120

Merged
floatingghost merged 3 commits from eris/pleroma-fe:mfm-on-hover into develop 2022-08-08 15:47:07 +00:00
Conversation 1 Commits 3 Files changed 7 +26 -1
eris commented 2022-08-07 07:43:43 +00:00
Contributor
Copy link

Closes #103

Closes #103
Screen Recording 2022-08-07 at 12.41.40 AM.mp4
91 KiB
eris added 1 commit 2022-08-07 07:43:44 +00:00
New option: Pause MFM until status hover
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
75e18ecfcf
eris added the
Feature
 label 2022-08-07 07:44:04 +00:00
eris changed title from New option: Pause MFM until status hover to New option: Pause MFM animations until status hover 2022-08-07 07:45:14 +00:00
floatingghost reviewed 2022-08-07 20:08:28 +00:00
floatingghost left a comment
Owner
Copy link

niggle about naming, otherwise this looks ok

niggle about naming, otherwise this looks ok
src/components/settings_modal/tabs/general_tab.vue Outdated
@ -106,0 +108,4 @@
>
<li>
<BooleanSetting
path="mfmOnHover"
floatingghost commented 2022-08-07 20:08:02 +00:00
Owner
Copy link

this setting path is named a tiny bit vaguely, any chance it could be renderMfmOnHover?

this setting path is named a tiny bit vaguely, any chance it could be `renderMfmOnHover`?
👍 1
eris marked this conversation as resolved
src/i18n/en.json Outdated
@ -577,6 +577,7 @@
"remove_alias": "Remove this alias",
"remove_backup": "Remove",
"render_mfm": "Render Misskey Markdown",
"render_mfm_on_hover": "Pause MFM animations until status hover",
floatingghost commented 2022-08-07 20:07:22 +00:00
Owner
Copy link

terminology has recently been unified to use post to mean... well, posts

terminology has recently been unified to use `post` to mean... well, posts
👍 1
eris marked this conversation as resolved
eris added 1 commit 2022-08-07 20:27:12 +00:00
eris added 1 commit 2022-08-07 20:27:26 +00:00
floatingghost commented 2022-08-08 15:47:02 +00:00
Owner
Copy link

seems good, thank

seems good, thank
👍 1
floatingghost merged commit d4f8934e8a into develop 2022-08-08 15:47:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#120
No description provided.
Delete branch "eris/pleroma-fe:mfm-on-hover"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?