AkkomaGang
/
akkoma-fe
4
13
Fork 56
Code Issues 71 Pull Requests 16 Projects Releases 1 Wiki Activity

Add delete & redraft button to posts #174

Merged
floatingghost merged 1 commits from nbsp/pleroma-fe:feat/redraft into develop 2022-10-02 12:02:02 +00:00
Conversation 4 Commits 1 Files Changed 7 +9196 -8707
nbsp commented 2022-09-25 17:54:24 +00:00
Contributor
Copy Link

seen a few people ask for this, i've tried my best to explain how this is different from editing a post
i think there is still rationale for adding this alongside edits

i did my best with the icon choice? it required updating fortawesome to a newer version which made a lot of changes to some existing icons

seen a few people ask for this, i've tried my best to explain how this is different from editing a post i think there is still rationale for adding this alongside edits i did my best with the icon choice? it required updating fortawesome to a newer version which made a lot of changes to some existing icons
nbsp added 1 commit 2022-09-25 17:54:24 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
ca646822f6
Add delete & redraft button to posts
floatingghost commented 2022-09-25 21:27:40 +00:00
Owner
Copy Link

i think there is still rationale for adding this

could you elaborate on this? given that a delete and redraft was a hack to add easy editing, what is its purpose now we can edit?

>i think there is still rationale for adding this could you elaborate on this? given that a delete and redraft was a hack to add easy editing, what is its purpose now we can edit?
nbsp commented 2022-09-26 08:40:56 +00:00
Author
Contributor
Copy Link

editing doesn't let you change the post visibility, you can't update polls, you can't fix broken mentions, and it's not supported on 2 substantially large pieces of software

editing doesn't let you change the post visibility, you can't update polls, you can't fix broken mentions, and it's not supported on 2 substantially large pieces of software
floatingghost commented 2022-09-26 10:19:55 +00:00
Owner
Copy Link

hm, the scope change is a good one, i shall accept the justification

lemme test the changes, but in priniciple it should be ok

hm, the scope change is a good one, i shall accept the justification lemme test the changes, but in priniciple it should be ok
floatingghost commented 2022-10-02 12:01:57 +00:00
Owner
Copy Link

that works very nicely, thanks!

that works very nicely, thanks!
floatingghost merged commit eaf2bd05a0 into develop 2022-10-02 12:02:02 +00:00
floatingghost deleted branch feat/redraft 2022-10-02 12:02:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No Label
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#174
No description provided.
Delete Branch "nbsp/pleroma-fe:feat/redraft"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?