AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 81 Pull requests 19 Projects Releases 1 Wiki Activity

Fix floating point error for poll expiry #294

Merged
floatingghost merged 1 commit from xarvos/pleroma-fe:fix-poll-expire into develop 2023-03-30 09:49:39 +00:00
Conversation 2 Commits 1 Files changed 1 +3 -3
xarvos commented 2023-03-24 13:48:52 +00:00
Contributor
Copy link

Previous code multiply with 0.001 before multiplication which leads to a
floating point error. By changing it to division by 1000 after
multiplication this is avoided.

This resolves #290

Previous code multiply with 0.001 before multiplication which leads to a floating point error. By changing it to division by 1000 after multiplication this is avoided. This resolves #290
xarvos added 1 commit 2023-03-24 13:48:52 +00:00
Fix floating point error for poll expiry
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
47fc082fb9 
Previous code multiply with 0.001 before multiplication which leads to a
floating point error.  By changing it to division by 1000 after
multiplication this is avoided.
xarvos commented 2023-03-24 13:50:02 +00:00
Author
Contributor
Copy link

By the way, can you tag releases? latest develop doesn't work for me and it was hard to find latest stable release without tags.

By the way, can you tag releases? latest develop doesn't work for me and it was hard to find latest stable release without tags.
floatingghost commented 2023-03-30 09:49:35 +00:00
Owner
Copy link

oh interesting, good spot!

thanks

and yes i'll make sure to tag releases, didn't know anyone relied on that, just tagged 2023.03

oh interesting, good spot! thanks and yes i'll make sure to tag releases, didn't know anyone relied on that, just tagged 2023.03
floatingghost merged commit 5911777aa2 into develop 2023-03-30 09:49:39 +00:00
floatingghost deleted branch fix-poll-expire 2023-03-30 09:49:39 +00:00
mel referenced this pull request from a commit 2024-05-15 22:36:01 +00:00
Squashed commit of the following:
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#294
No description provided.
Delete branch "xarvos/pleroma-fe:fix-poll-expire"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?