AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 82 Pull requests 20 Projects Releases 1 Wiki Activity

Make animated emojis in reactions pause #378

Merged
floatingghost merged 2 commits from sarayalth/akkoma-fe:pause-animated-reaction into develop 2024-05-28 02:25:02 +00:00
Conversation 1 Commits 2 Files changed 2 +8 -5
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 1f5f8665c8 - Show all commits

4
src/components/notification/notification.js
View file

@ -6,6 +6,7 @@ import UserCard from '../user_card/user_card.vue'
import Timeago from '../timeago/timeago.vue' import Timeago from '../timeago/timeago.vue'
import RichContent from 'src/components/rich_content/rich_content.jsx' import RichContent from 'src/components/rich_content/rich_content.jsx'
import ConfirmModal from '../confirm_modal/confirm_modal.vue' import ConfirmModal from '../confirm_modal/confirm_modal.vue'
import StillImage from '../still-image/still-image.vue'
import { isStatusNotification } from '../../services/notification_utils/notification_utils.js' import { isStatusNotification } from '../../services/notification_utils/notification_utils.js'
import { highlightClass, highlightStyle } from '../../services/user_highlighter/user_highlighter.js' import { highlightClass, highlightStyle } from '../../services/user_highlighter/user_highlighter.js'
import generateProfileLink from 'src/services/user_profile_link_generator/user_profile_link_generator' import generateProfileLink from 'src/services/user_profile_link_generator/user_profile_link_generator'
@ -50,7 +51,8 @@ const Notification = {
Timeago, Timeago,
Status, Status,
RichContent, RichContent,
ConfirmModal ConfirmModal,
StillImage
}, },
methods: { methods: {
toggleUserExpanded () { toggleUserExpanded () {

9
src/components/notification/notification.vue
View file

@ -116,12 +116,13 @@
scope="global" scope="global"
keypath="notifications.reacted_with" keypath="notifications.reacted_with"
> >
<img <still-image
v-if="notification.emoji_url !== null" v-if="notification.emoji_url !== null"
class="notification-reaction-emoji" class="notification-reaction-emoji emoji img"
Oneric commented 2024-05-13 00:12:33 +00:00
Outdated
Review
Copy link

why did you add generic img and emoji classes here? Removing them doesn’t seem to make a difference and on a cursory search no matching selectors seem to exist; did i miss something?

why did you add generic `img` and `emoji` classes here? Removing them doesn’t seem to make a difference and on a cursory search no matching selectors seem to exist; did i miss something?
sarayalth commented 2024-05-14 16:05:37 +00:00
Outdated
Review
Copy link

honestly, i don't remember why those are there, i just tested myself and it seems to work fine without them

honestly, i don't remember why those are there, i just tested myself and it seems to work fine without them
👍 1
:src="notification.emoji_url" :src="notification.emoji_url"
:name="notification.emoji" :title="notification.emoji"
> :alt="notification.emoji"
/>
<span <span
v-else v-else
class="emoji-reaction-emoji" class="emoji-reaction-emoji"