AkkomaGang/akkoma-fe
5
14
Fork 71
Code Issues 85 Pull requests 12 Projects Releases 1 Wiki Activity

Support selectable visibility of repeats #440

Merged
Oneric merged 2 commits from Oneric/akkoma-fe:boost-scopes into develop 2025-06-10 18:38:00 +00:00
Conversation 0 Commits 2 Files changed 7 +81 -37
Oneric commented 2025-05-18 20:59:16 +00:00
Owner
Copy link

Update: With AkkomaGang/akkoma#941 there’s no confusion anymore and this should be a clear improvement

Currently the backend maps the fine-grained visibility options to a boolean private/public though which is a bit confusing. (only private/direct are mapped to private; everything else, is considered a public repeat)

Mastodon supports private//unlisted/public visibilities however, so there’s no reason we shouldn’t just support all visibility options in the backend.

See lib/pleroma/web/common_api.ex::{repeat/3, public_announce/2} and lib/pleroma/web/activity_pub/builder.ex::announce/3 in the backend and compare to lib/pleroma/web/common_api/utils.ex::get_to_and_cc/1 which takes an ActivityDraft

Superseding #345

**Update:** With https://akkoma.dev/AkkomaGang/akkoma/pulls/941 there’s no confusion anymore and this should be a clear improvement --- ~~Currently the backend maps the fine-grained visibility options to a boolean `private`/`public` though which is a bit confusing. *(only `private`/`direct` are mapped to `private`; everything else, is considered a `public` repeat)*~~ ~~Mastodon supports `private`//`unlisted`/`public` visibilities however, so there’s no reason we shouldn’t just support all visibility options in the backend.~~ ~~See `lib/pleroma/web/common_api.ex::{repeat/3, public_announce/2}` and `lib/pleroma/web/activity_pub/builder.ex::announce/3` in the backend and compare to `lib/pleroma/web/common_api/utils.ex::get_to_and_cc/1` which takes an `ActivityDraft`~~ --- Superseding https://akkoma.dev/AkkomaGang/akkoma-fe/pulls/345
Oneric added 2 commits 2025-05-18 20:59:16 +00:00
Add support selectable visibility of repeat
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
d617a9596a 
Co-authored-by: Oneric <oneric@oneric.stub>
Oneric merged commit 4cf4b5e2d0 into develop 2025-06-10 18:38:00 +00:00
Oneric deleted branch boost-scopes 2025-06-10 18:38:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#440
No description provided.
Delete branch "Oneric/akkoma-fe:boost-scopes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?