Support selectable visibility of repeats #440

Merged
Oneric merged 2 commits from Oneric/akkoma-fe:boost-scopes into develop 2025-06-10 18:38:00 +00:00
Owner

Update: With AkkomaGang/akkoma#941 there’s no confusion anymore and this should be a clear improvement


Currently the backend maps the fine-grained visibility options to a boolean private/public though which is a bit confusing. (only private/direct are mapped to private; everything else, is considered a public repeat)

Mastodon supports private//unlisted/public visibilities however, so there’s no reason we shouldn’t just support all visibility options in the backend.

See lib/pleroma/web/common_api.ex::{repeat/3, public_announce/2} and lib/pleroma/web/activity_pub/builder.ex::announce/3 in the backend and compare to lib/pleroma/web/common_api/utils.ex::get_to_and_cc/1 which takes an ActivityDraft


Superseding #345

**Update:** With https://akkoma.dev/AkkomaGang/akkoma/pulls/941 there’s no confusion anymore and this should be a clear improvement --- ~~Currently the backend maps the fine-grained visibility options to a boolean `private`/`public` though which is a bit confusing. *(only `private`/`direct` are mapped to `private`; everything else, is considered a `public` repeat)*~~ ~~Mastodon supports `private`//`unlisted`/`public` visibilities however, so there’s no reason we shouldn’t just support all visibility options in the backend.~~ ~~See `lib/pleroma/web/common_api.ex::{repeat/3, public_announce/2}` and `lib/pleroma/web/activity_pub/builder.ex::announce/3` in the backend and compare to `lib/pleroma/web/common_api/utils.ex::get_to_and_cc/1` which takes an `ActivityDraft`~~ --- Superseding https://akkoma.dev/AkkomaGang/akkoma-fe/pulls/345
Oneric added 2 commits 2025-05-18 20:59:16 +00:00
Add support selectable visibility of repeat
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
d617a9596a
Co-authored-by: Oneric <oneric@oneric.stub>
Oneric merged commit 4cf4b5e2d0 into develop 2025-06-10 18:38:00 +00:00
Oneric deleted branch boost-scopes 2025-06-10 18:38:00 +00:00
Sign in to join this conversation.
No description provided.