Fix sensitive by default option #443

norm · 2025-09-04T00:54:43Z

norm commented

2025-09-04 00:54:43 +00:00

Fixes #442

Fixes https://akkoma.dev/AkkomaGang/akkoma-fe/issues/442

norm added 1 commit

2025-09-04 00:54:44 +00:00

Fix sensitive by default option 9c15db16a6

Fixes #442

Oneric reviewed

2025-09-04 18:54:14 +00:00

src/components/post_status_form/post_status_form.js

					
				@ -514,3 +514,3 @@

				      this.newStatus.files.push(fileInfo)

				      if (this.$store.getters.mergedConfig.sensitiveIfSubject && this.newStatus.spoilerText !== '') {

				      if (this.$store.getters.mergedConfig.sensitiveIfSubject && this.newStatus.spoilerText !== '' || !!this.$store.getters.mergedConfig.sensitiveByDefault) {

Considering the descriptions of the settings:

"sensitive_by_default": "Mark posts as sensitive by default",
"sensitive_if_subject": "Automatically mark images as sensitive if a content warning is specified",

the existing behaviour is technically correct. Considering the lack of complaints of posts but not images being marked as default, this might actually be desired for (some) current users.
While it doesn’t align with the existing config description (or internal name), the most flexible solution would be to turn sensitiveIfSubject effectively Into attachmentSensitiveIfPost. It’s hard to imaginge anyone enabling both of these options and not expecting images to be marked sensitive by default, spoiler text or not

Considering the descriptions of the settings: > ```json > "sensitive_by_default": "Mark posts as sensitive by default", > "sensitive_if_subject": "Automatically mark images as sensitive if a content warning is specified", > ``` the existing behaviour is technically correct. Considering the lack of complaints of posts but not images being marked as default, this might actually be desired for (some) current users. While it doesn’t align with the existing config description (or internal name), the most flexible solution would be to turn `sensitiveIfSubject` effectively Into `attachmentSensitiveIfPost`. It’s hard to imaginge anyone enabling both of these options and _not_ expecting images to be marked sensitive by default, spoiler text or not

Should these options be turned into a dropdown with three options like?

"Mark all posts as sensitive by default" (current sensitiveByDefault)
"Mark posts with content warnings as sensitive by default" (current sensitiveIfSubject)
"Don't mark any posts as sensitive by default" (if both aren't enabled)

Should these options be turned into a dropdown with three options like? - "Mark all posts as sensitive by default" (current `sensitiveByDefault`) - "Mark posts with content warnings as sensitive by default" (current `sensitiveIfSubject`) - "Don't mark any posts as sensitive by default" (if both aren't enabled)

norm marked this conversation as resolved

norm referenced this pull request

2025-09-04 21:54:20 +00:00

WIP: Overhaul post sensitivity default setting #444

norm commented

2025-09-04 21:54:46 +00:00

Made an alternate PR with the three way option thing in #444

Made an alternate PR with the three way option thing in https://akkoma.dev/AkkomaGang/akkoma-fe/pulls/444

Oneric referenced this pull request

2025-09-05 17:26:58 +00:00

WIP: Overhaul post sensitivity default setting #444

Oneric referenced this pull request

2025-09-05 19:13:04 +00:00

WIP: Overhaul post sensitivity default setting #444

norm commented

2025-09-05 19:42:31 +00:00

Ok from the now closed #444, this approach seems ot be the way to go for now.

What would be a better updated description for sensitive_if_subject?

Ok from the now closed #444, this approach seems ot be the way to go for now. What would be a better updated description for `sensitive_if_subject`?

Oneric commented

2025-09-06 11:48:01 +00:00

Anything which makes it clear it refers to the whole post works. E.g. a minimal change of the current text:
"Automatically mark post as sensitive if a content warning is specified"

This doesn't explicitly mention attachments but neither does the other option. If you think it's better to be more explicit "post and attachments" (for both)

Anything which makes it clear it refers to the whole post works. E.g. a minimal change of the current text: *"Automatically mark post as sensitive if a content warning is specified"* This doesn't explicitly mention attachments but neither does the other option. If you think it's better to be more explicit *"post and attachments"* (for both)

👍 1

norm added 1 commit

2025-09-06 12:29:11 +00:00

Clarify the sensitiveIfSUbject setting description 166f80b67d

norm force-pushed fix-sensitive from 166f80b67d to 9ef8effeed

2025-09-06 12:31:34 +00:00

Compare

Oneric approved these changes

2025-09-07 00:47:43 +00:00

Oneric merged commit 55dff3a9bd into develop

2025-09-07 00:50:15 +00:00

Oneric referenced this pull request from a commit