AkkomaGang/akkoma-fe
4
15
Fork 73
Code Issues 70 Pull requests 13 Projects Releases 1 Wiki Activity

media_modal: fix image load handler wiring #454

Merged
floatingghost merged 1 commit from novenary/akkoma-fe:media_modal/load_handler into develop 2025-10-14 12:40:55 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -1
novenary commented 2025-10-14 12:39:00 +00:00
Contributor
Copy link

The media modal was changed to use still_image, but the attribute
pointing to the image load event handler wasn't updated.
This causes the modal to remain in the loading state forever.

Fixes: f48138c979

The media modal was changed to use still_image, but the attribute pointing to the image load event handler wasn't updated. This causes the modal to remain in the loading state forever. Fixes: f48138c9793e77b8d4a2b6f6089a6038860509aa
media_modal: fix image load handler wiring
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline is pending approval
Details
f6bf484d4b 
The media modal was changed to use still_image, but the attribute
pointing to the image load event handler wasn't updated.
This causes the modal to remain in the loading state forever.

Fixes: f48138c979
floatingghost commented 2025-10-14 12:40:50 +00:00
Owner
Copy link

ah, this would explain some of what users have been reporting

thanks!

ah, this would explain some of what users have been reporting thanks!
❤️ 1
floatingghost deleted branch media_modal/load_handler 2025-10-14 12:40:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
cannot reproduce

   
CSS

Related to CSS styling

  
Documentation

  
enhancement

Improving existing stuff

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
Minor change

For minor changes, ie CSS alignment changes

  
performance

Poor performance or too high resource usage

  
priority: critical

   
priority: high

   
priority: low

   
priority: medium

   
priority: patch welcome

   
regression

   
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
cannot reproduce
CSS
Documentation
enhancement
Feature
Feature request
Held for next release cycle
Minor change
performance
priority: critical
priority: high
priority: low
priority: medium
priority: patch welcome
regression
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma-fe!454
No description provided.