Various small fixes #459

Merged

Oneric merged 4 commits from Oneric/akkoma-fe:varfixes-20251018 into develop

2025-10-24 18:56:42 +00:00

Oneric commented

2025-10-18 12:35:53 +00:00

Owner

fixes image attachments overflowing their display box (#456; regression in last release (already before hotfix))
fixes document attachments description not being scrollable in the entire width (brought up in #456)
finally fixes failed media uploads bricking the frontend (#339)
copy AP IDs also for local posts (related to #166)

Seemed fine in initial checks, but more testing welcome

... apparently we still account for the response format of the legacy qvitter API in the frontend. This really should be all purged at some point

- fixes image attachments overflowing their display box (#456; regression in last release (already before hotfix)) - fixes document attachments description not being scrollable in the entire width (brought up in #456) - finally fixes failed media uploads bricking the frontend (#339) - copy AP IDs also for local posts (related to #166) Seemed fine in initial checks, but more testing welcome ... apparently we still account for the response format of the legacy qvitter API in the frontend. This really should be all purged at some point

Oneric added 4 commits

2025-10-18 12:35:53 +00:00

Fix image attachments overflowing their container f0c149950c

This reverts commit e1b4d8f59a
and obsoletes commit c2db0e66ef
which already unset min-height in notifications where this
caused images to become effectively invisible.

Image previews are currently designed to always show the full image
scaled down as needed. With min-height though they were allowed to
take the full width even if it caused overflows in vertical direction.
This happened to look kind of fine with only easy-to-miss overflows
in the main post view if each preview row had the same amount of
columns, but creates jarring overlaps otherwise.

Fixes: #456

Always use AP ID when copying post link c3673eb53a

This is the canonical reference to a post and works best for lookups on
other servers. Previously this canonical ID was not accessible from the
frontend at all.

The "source" button continues to redirect to the preferred display URL
though (if set), since this is as the name suggests the preferred URL
for viewing the post in a browser (it might however not work when the
source instance restricts unauthenticated access even to local content).

This lifts the redundancy between the "source" and "copy link" buttons.

Since the legac qvitter API is still accounted for in the entity
normaliser, we just assume its external_url serves as both the canoncial
location and preferred display URL. It is dubious however, if this
codepath can even still be triggered at all and it likely makes more
sense to purge all remnants of the legacy API from the codebase.

Resolves: #166

Fix failed media uploads bricking the frontend 7e4d381af1

The upload call hid errors and the entity normaliser lets them pass
through as well (assuming it must be an already "correctly" formatted
legacy qvitter response), which led to errors being added to the the
draft as if it was a valid attachment object.
On later use of this error exceptions occur breaking the frontend and
due to being saved as part of a draft this could only be recovered by
clearing local client data.

Fixes: #339

Ensure attachment descriptions fill full width

ci/woodpecker/pr/woodpecker Pipeline failed

Details

9dea46bc8a

Was noticeable by e.g. the scrollbar being shown somewhere inside the
container and not being able to scroll near the edges if each line of
text was sufficiently short.

Directly implements the suggesstion from
#456 (comment)