cosmetic: fix linter complaints #476

Merged
Oneric merged 1 commit from Oneric/akkoma-fe:lint-cosmetics into develop 2026-01-26 14:44:19 +00:00
Owner

Since CI is broken atm anyway, I didn’t notice it was now failing already in the lint step rather than on the broken test. This hopefully fixes this


Mostly just reordering, whitespace changes
and removing superfluous "this".

eslint really wants us to add :key to the UserAvatar list in DM
conversation cards. With :key Vue will reorder elements instead
of patching their contents on list changes, allowing input state
of elements to be preserved. This doesn’t really seem relevant
here since USerAvatars do not have a state, but also not harmful.

One (non-fatal) lint complaint about using double quotes at the outer level
was purposefully ignored as it results in needing to quote
double quotes within the string making it rather unreadable.

Since CI is broken atm anyway, I didn’t notice it was now failing already in the `lint` step rather than on the broken test. This hopefully fixes this --- Mostly just reordering, whitespace changes and removing superfluous "this". eslint really wants us to add :key to the UserAvatar list in DM conversation cards. With :key Vue will reorder elements instead of patching their contents on list changes, allowing input state of elements to be preserved. This doesn’t really seem relevant here since USerAvatars do not have a state, but also not harmful. One (non-fatal) lint complaint about using double quotes at the outer level was purposefully ignored as it results in needing to quote double quotes within the string making it rather unreadable.
cosmetic: fix linter complaints
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
ci/woodpecker/pull_request_metadata/woodpecker Pipeline was successful
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
ci/woodpecker/push/woodpecker Pipeline was successful
42595fcb2c
Mostly just reordering, whitespace changes
and removing superfluous "this".

eslint really wants us to add :key to the UserAvatar list in DM
conversation cards. With :key Vue will reorder elements instead
of patching their contents on list changes, allowing input state
of elements to be preserved. This doesn’t really seem relevant
here since USerAvatars do not have a state, but also not harmful.

One lint complaint about using double quotes at the outer level
was purposefully ignored as it results in needing to quote
double quotes within the string making it rather unreadable.
Oneric merged commit 42595fcb2c into develop 2026-01-26 14:44:19 +00:00
Oneric deleted branch lint-cosmetics 2026-01-26 14:44:20 +00:00
Sign in to join this conversation.
No description provided.