Remove descriptions in timeline menu, change to titles and aria-labels #74

Merged
floatingghost merged 2 commits from eris/pleroma-fe:timeline-text-as-titles into develop 2022-08-02 09:18:59 +00:00
Contributor

Strips the text and adds it as alt-text / popover title as well as aria-label for screenreaders

This lets you close #47

Strips the text and adds it as alt-text / popover title as well as aria-label for screenreaders This lets you close #47
eris added 1 commit 2022-07-29 00:06:44 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
c74e939a82
Remove descriptions in timeline menu, change to title

hm, whilst this works, apparently title isn't recommended for this per accessibility guidelines

i'm gonna play around with aria- attributes and see if i can get a working setup that way

hm, whilst this works, apparently `title` isn't recommended for this per [accessibility guidelines](https://www.a11yproject.com/posts/title-attributes/) i'm gonna play around with `aria-` attributes and see if i can get a working setup that way
Author
Contributor

hm, whilst this works, apparently title isn't recommended for this per accessibility guidelines

i'm gonna play around with aria- attributes and see if i can get a working setup that way

There's some debate about that article here:

https://stackoverflow.com/questions/27953425/what-is-the-difference-between-aria-label-and-title-attributes

The most preferred solution seemed to have been using both title and aria-label, I'll add that into the PR

> hm, whilst this works, apparently `title` isn't recommended for this per [accessibility guidelines](https://www.a11yproject.com/posts/title-attributes/) > > i'm gonna play around with `aria-` attributes and see if i can get a working setup that way There's some debate about that article here: https://stackoverflow.com/questions/27953425/what-is-the-difference-between-aria-label-and-title-attributes The most preferred solution seemed to have been using both `title` and `aria-label`, I'll add that into the PR
eris added 1 commit 2022-08-01 17:47:57 +00:00
eris changed title from Remove descriptions in timeline menu, change to title to Remove descriptions in timeline menu, change to titles and aria-labels 2022-08-01 17:48:27 +00:00
Author
Contributor

Okay @floatingghost all ready for review and this should make everynyan happy~

Okay @floatingghost all ready for review and this should make everynyan happy~
eris added the
a11y
label 2022-08-01 18:00:11 +00:00

perfect, that works entirely as i was trying to get it to

perfect, that works entirely as i was trying to get it to
floatingghost merged commit ef41494bad into develop 2022-08-02 09:18:59 +00:00
eris deleted branch timeline-text-as-titles 2022-08-07 08:05:59 +00:00
Sign in to join this conversation.
No description provided.