AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 82 Pull requests 20 Projects Releases 1 Wiki Activity

Commit list accounts state after difference in removed accounts is determined #82

Merged
floatingghost merged 2 commits from :commit-list-accounts-after-delete into develop 2022-08-01 10:11:40 +00:00
Conversation 2 Commits 2 Files changed 1 +10 -6
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/modules/lists.js
View file

@ -57,12 +57,16 @@ const actions = {
commit('setList', { id, title }) commit('setList', { id, title })
}, },
setListAccounts ({ rootState, commit }, { id, accountIds }) { setListAccounts ({ rootState, commit }, { id, accountIds }) {
const saved = rootState.lists.allListsObject[id].accountIds
const added = accountIds.filter(id => !saved.includes(id))
const removed = saved.filter(id => !accountIds.includes(id))
commit('setListAccounts', { id, accountIds }) commit('setListAccounts', { id, accountIds })
rootState.api.backendInteractor.addAccountsToList({ id, accountIds }) if (added.length > 0) {
rootState.api.backendInteractor.removeAccountsFromList({ rootState.api.backendInteractor.addAccountsToList({ id, accountIds: added })
id, }
accountIds: rootState.lists.allListsObject[id].accountIds.filter(id => !accountIds.includes(id)) if (removed.length > 0) {
}) rootState.api.backendInteractor.removeAccountsFromList({ id, accountIds: removed })
}
}, },
deleteList ({ rootState, commit }, { id }) { deleteList ({ rootState, commit }, { id }) {
rootState.api.backendInteractor.deleteList({ id }) rootState.api.backendInteractor.deleteList({ id })
@ -76,7 +80,7 @@ export const getters = {
return state.allListsObject[id].title return state.allListsObject[id].title
}, },
findListAccounts: state => id => { findListAccounts: state => id => {
return state.allListsObject[id].accountIds return [...state.allListsObject[id].accountIds]
Ghost marked this conversation as resolved Outdated
floatingghost commented 2022-07-31 21:46:03 +00:00
Outdated
Review
Copy link

the preferred way to duplicate an array is via the ... syntax

return [...state.allListsObject[id].accountIds]

the preferred way to duplicate an array is via the `...` syntax `return [...state.allListsObject[id].accountIds]`
Ghost commented 2022-08-01 10:07:57 +00:00
Outdated
Review
Copy link

As far as performance goes, ths is less optimal option. But if you want to prioritize readability, sure.

As far as performance goes, ths is less optimal option. But if you want to prioritize readability, sure.
floatingghost commented 2022-08-01 10:11:11 +00:00
Outdated
Review
Copy link

the difference in performance would only actually be relevent if we were dealing with (tens of) thousands of elements, which we're not

the difference in performance would only actually be relevent if we were dealing with (tens of) thousands of elements, which we're not
} }
} }