AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 177 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

Revert "Mark instances as unreachable when returning a 403 from an object fetch"

Browse source 
This reverts commit d472bafec19cee269e7c943bafae7c805785acd7.
This commit is contained in:
Mark Felder 2023-12-26 17:12:58 -05:00 committed by Floatingghost
parent e2b04fac5a
commit 30d63aaa6e
3 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/handle_object_fetch_failures.change
View file

@ -1,3 +1,2 @@
Remote object fetch failures will prevent the object fetch job from retrying if the object has been deleted or the fetch was denied with a 403 due to instance block behavior with authorized_fetch enabled. Remote object fetch failures will prevent the object fetch job from retrying if the object has been deleted or the fetch was denied with a 403 due to instance block behavior with authorized_fetch enabled.
Mark instances as unreachable when object fetch is denied due to instance block and authorized_fetch.
Skip fetching objects from unreachable instances. Skip fetching objects from unreachable instances.

1
lib/pleroma/object/fetcher.ex
View file

@ -344,7 +344,6 @@ def get_object(id) do
end end
else else
{:ok, %{status: 403}} -> {:ok, %{status: 403}} ->
Instances.set_consistently_unreachable(id)
{:error, "Object fetch has been denied"} {:error, "Object fetch has been denied"}
{:ok, %{status: code}} when code in [404, 410] -> {:ok, %{status: code}} when code in [404, 410] ->

12
test/pleroma/object/fetcher_test.exs
View file

@ -419,18 +419,6 @@ test "handle HTTP 404 response" do
) )
end end
test "handle HTTP 403 response" do
object_id = "https://octodon.social/users/cwebber/statuses/111647596861000656"
Instances.set_reachable(object_id)
assert Instances.reachable?(object_id)
assert {:error, "Object fetch has been denied"} ==
Fetcher.fetch_object_from_id(object_id)
refute Instances.reachable?(object_id)
end
test "it can fetch pleroma polls with attachments" do test "it can fetch pleroma polls with attachments" do
{:ok, object} = {:ok, object} =
Fetcher.fetch_object_from_id("https://patch.cx/objects/tesla_mock/poll_attachment") Fetcher.fetch_object_from_id("https://patch.cx/objects/tesla_mock/poll_attachment")