don't publish public activities to quarantined

lib/pleroma/web/activity_pub/publisher.ex

@@ -104,18 +104,14 @@ defp signature_host(%URI{port: port, scheme: scheme, host: host}) do
   end
 
   defp should_federate?(inbox, public) do
-    if public do
+    %{host: host} = URI.parse(inbox)
-      true
-    else
-      %{host: host} = URI.parse(inbox)
 
-      quarantined_instances =
+    quarantined_instances =
-        Config.get([:instance, :quarantined_instances], [])
+      Config.get([:instance, :quarantined_instances], [])
-        |> Pleroma.Web.ActivityPub.MRF.instance_list_from_tuples()
+      |> Pleroma.Web.ActivityPub.MRF.instance_list_from_tuples()
-        |> Pleroma.Web.ActivityPub.MRF.subdomains_regex()
+      |> Pleroma.Web.ActivityPub.MRF.subdomains_regex()
 
-      !Pleroma.Web.ActivityPub.MRF.subdomain_match?(quarantined_instances, host)
+    !Pleroma.Web.ActivityPub.MRF.subdomain_match?(quarantined_instances, host)
-    end
   end
 
   @spec recipients(User.t(), Activity.t()) :: list(User.t()) | []

test/pleroma/web/activity_pub/publisher_test.exs

@@ -267,7 +267,7 @@ test "publish to url with with different ports" do
   end
 
   describe "publish/2" do
-    test_with_mock "doesn't publish a non-public activity to quarantined instances.",
+    test_with_mock "doesn't publish any activity to quarantined instances.",
                    Pleroma.Web.Federator.Publisher,
                    [:passthrough],
                    [] do