activitypub: fix possible false positives with broken thread filtering

2018-10-28 05:45:33 +00:00 · 2018-10-28 05:45:33 +00:00 · 72ea54de6e
parent 310a4bc25c
commit 72ea54de6e
1 changed files with 3 additions and 2 deletions
--- a/lib/pleroma/web/activity_pub/activity_pub.ex
+++ b/lib/pleroma/web/activity_pub/activity_pub.ex
@ -793,9 +793,10 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do

  # child
  def entire_thread_visible_for_user?(
-        %Activity{data: %{"object" => %{"inReplyTo" => _parent_id}}} = tail,
+        %Activity{data: %{"object" => %{"inReplyTo" => parent_id}}} = tail,
        user
-      ) do
+      )
+      when is_binary(parent_id) do
    parent = Activity.get_in_reply_to_activity(tail)
    visible_for_user?(tail, user) && entire_thread_visible_for_user?(parent, user)
  end