Prefer userLanguage cookie over Accept-Language header in detecting locale

https://git.pleroma.social/pleroma/pleroma-meta/-/issues/60
This commit is contained in:
Tusooa Zhu 2022-02-21 17:54:18 -05:00 committed by FloatingGhost
parent a20d2847e2
commit 775f997c40
2 changed files with 87 additions and 1 deletions

View file

@ -6,6 +6,8 @@
defmodule Pleroma.Web.Plugs.SetLocalePlug do defmodule Pleroma.Web.Plugs.SetLocalePlug do
import Plug.Conn, only: [get_req_header: 2, assign: 3] import Plug.Conn, only: [get_req_header: 2, assign: 3]
def frontend_language_cookie_name(), do: "userLanguage"
def init(_), do: nil def init(_), do: nil
def call(conn, _) do def call(conn, _) do
@ -16,10 +18,35 @@ defmodule Pleroma.Web.Plugs.SetLocalePlug do
defp get_locale_from_header(conn) do defp get_locale_from_header(conn) do
conn conn
|> extract_accept_language() |> extract_preferred_language()
|> normalize_language_codes()
|> Enum.find(&supported_locale?/1) |> Enum.find(&supported_locale?/1)
end end
defp normalize_language_codes(codes) do
codes
|> Enum.map(fn code -> String.replace(code, "-", "_") end)
end
defp extract_preferred_language(conn) do
extract_frontend_language(conn) ++ extract_accept_language(conn)
end
defp extract_frontend_language(conn) do
%{req_cookies: cookies} =
conn
|> Plug.Conn.fetch_cookies()
case cookies[frontend_language_cookie_name()] do
nil ->
[]
fe_lang ->
[fe_lang]
|> ensure_language_fallbacks()
end
end
defp extract_accept_language(conn) do defp extract_accept_language(conn) do
case get_req_header(conn, "accept-language") do case get_req_header(conn, "accept-language") do
[value | _] -> [value | _] ->

View file

@ -33,6 +33,65 @@ defmodule Pleroma.Web.Plugs.SetLocalePlugTest do
assert %{locale: "ru"} == conn.assigns assert %{locale: "ru"} == conn.assigns
end end
test "use supported locale with specifiers from `accept-language`" do
conn =
:get
|> conn("/cofe")
|> Conn.put_req_header(
"accept-language",
"zh-Hans;q=0.9, en;q=0.8, *;q=0.5"
)
|> SetLocalePlug.call([])
assert "zh_Hans" == Gettext.get_locale()
assert %{locale: "zh_Hans"} == conn.assigns
end
test "use supported locale from cookie" do
conn =
:get
|> conn("/cofe")
|> put_req_cookie(SetLocalePlug.frontend_language_cookie_name(), "zh-Hans")
|> Conn.put_req_header(
"accept-language",
"ru, fr-CH, fr;q=0.9, en;q=0.8, *;q=0.5"
)
|> SetLocalePlug.call([])
assert "zh_Hans" == Gettext.get_locale()
assert %{locale: "zh_Hans"} == conn.assigns
end
test "fallback to supported locale from `accept-language` if locale in cookie not supported" do
conn =
:get
|> conn("/cofe")
|> put_req_cookie(SetLocalePlug.frontend_language_cookie_name(), "x-nonexist")
|> Conn.put_req_header(
"accept-language",
"ru, fr-CH, fr;q=0.9, en;q=0.8, *;q=0.5"
)
|> SetLocalePlug.call([])
assert "ru" == Gettext.get_locale()
assert %{locale: "ru"} == conn.assigns
end
test "fallback to default if nothing is supported" do
conn =
:get
|> conn("/cofe")
|> put_req_cookie(SetLocalePlug.frontend_language_cookie_name(), "x-nonexist")
|> Conn.put_req_header(
"accept-language",
"x-nonexist"
)
|> SetLocalePlug.call([])
assert "en" == Gettext.get_locale()
assert %{locale: "en"} == conn.assigns
end
test "use default locale if locale from `accept-language` is not supported" do test "use default locale if locale from `accept-language` is not supported" do
conn = conn =
:get :get