From b3401ba7bdd087fa0fcff684e07a2872acaa73ab Mon Sep 17 00:00:00 2001
From: Ekaterina Vaartis <vaartis@kotobank.ch>
Date: Sun, 22 Aug 2021 16:37:52 +0300
Subject: [PATCH] Also index incoming federated posts

---
 lib/pleroma/search/search.ex                 | 18 ++++++++++++++++++
 lib/pleroma/web/activity_pub/activity_pub.ex |  7 ++-----
 lib/pleroma/web/activity_pub/side_effects.ex |  7 +++++++
 lib/pleroma/web/common_api.ex                |  8 ++------
 4 files changed, 29 insertions(+), 11 deletions(-)
 create mode 100644 lib/pleroma/search/search.ex

diff --git a/lib/pleroma/search/search.ex b/lib/pleroma/search/search.ex
new file mode 100644
index 000000000..e363abf19
--- /dev/null
+++ b/lib/pleroma/search/search.ex
@@ -0,0 +1,18 @@
+defmodule Pleroma.Search do
+  def add_to_index(activity) do
+    search_module = Pleroma.Config.get([Pleroma.Search, :module])
+
+    ConcurrentLimiter.limit(Pleroma.Search, fn ->
+      Task.start(fn -> search_module.add_to_index(activity) end)
+    end)
+  end
+
+  def remove_from_index(object) do
+    # Also delete from search index
+    search_module = Pleroma.Config.get([Pleroma.Search, :module])
+
+    ConcurrentLimiter.limit(Pleroma.Search, fn ->
+      Task.start(fn -> search_module.remove_from_index(object) end)
+    end)
+  end
+end
diff --git a/lib/pleroma/web/activity_pub/activity_pub.ex b/lib/pleroma/web/activity_pub/activity_pub.ex
index 615bee428..5f068cef0 100644
--- a/lib/pleroma/web/activity_pub/activity_pub.ex
+++ b/lib/pleroma/web/activity_pub/activity_pub.ex
@@ -140,11 +140,8 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
         Task.start(fn -> Pleroma.Web.RichMedia.Helpers.fetch_data_for_activity(activity) end)
       end)
 
-      search_module = Pleroma.Config.get([Pleroma.Search, :module])
-
-      ConcurrentLimiter.limit(Pleroma.Search, fn ->
-        Task.start(fn -> search_module.add_to_index(activity) end)
-      end)
+      # Add local posts to search index
+      Pleroma.Search.add_to_index(activity)
 
       {:ok, activity}
     else
diff --git a/lib/pleroma/web/activity_pub/side_effects.ex b/lib/pleroma/web/activity_pub/side_effects.ex
index 9c2f89e72..98911f28f 100644
--- a/lib/pleroma/web/activity_pub/side_effects.ex
+++ b/lib/pleroma/web/activity_pub/side_effects.ex
@@ -193,6 +193,7 @@ defmodule Pleroma.Web.ActivityPub.SideEffects do
   # - Increase replies count
   # - Set up ActivityExpiration
   # - Set up notifications
+  # - Index incoming posts for search (if needed)
   @impl true
   def handle(%{data: %{"type" => "Create"}} = activity, meta) do
     with {:ok, object, meta} <- handle_object_creation(meta[:object_data], activity, meta),
@@ -222,6 +223,8 @@ defmodule Pleroma.Web.ActivityPub.SideEffects do
         Task.start(fn -> Pleroma.Web.RichMedia.Helpers.fetch_data_for_activity(activity) end)
       end)
 
+      Pleroma.Search.add_to_index(Map.put(activity, :object, object))
+
       meta =
         meta
         |> add_notifications(notifications)
@@ -281,6 +284,7 @@ defmodule Pleroma.Web.ActivityPub.SideEffects do
   # - Reduce the user note count
   # - Reduce the reply count
   # - Stream out the activity
+  # - Removes posts from search index (if needed)
   @impl true
   def handle(%{data: %{"type" => "Delete", "object" => deleted_object}} = object, meta) do
     deleted_object =
@@ -320,6 +324,9 @@ defmodule Pleroma.Web.ActivityPub.SideEffects do
 
     if result == :ok do
       Notification.create_notifications(object)
+
+      Pleroma.Search.remove_from_index(object)
+
       {:ok, object, meta}
     else
       {:error, result}
diff --git a/lib/pleroma/web/common_api.ex b/lib/pleroma/web/common_api.ex
index 0b7be42e0..b4887d424 100644
--- a/lib/pleroma/web/common_api.ex
+++ b/lib/pleroma/web/common_api.ex
@@ -146,12 +146,8 @@ defmodule Pleroma.Web.CommonAPI do
          true <- User.superuser?(user) || user.ap_id == object.data["actor"],
          {:ok, delete_data, _} <- Builder.delete(user, object.data["id"]),
          {:ok, delete, _} <- Pipeline.common_pipeline(delete_data, local: true) do
-      # Also delete from search index
-      search_module = Pleroma.Config.get([Pleroma.Search, :module])
-
-      ConcurrentLimiter.limit(Pleroma.Search, fn ->
-        Task.start(fn -> search_module.remove_from_index(object) end)
-      end)
+      # Remove from search index for local posts
+      Pleroma.Search.remove_from_index(object)
 
       {:ok, delete}
     else