Merge branch 'remove-user-activities' into 'develop'

[#757] Add mix task to delete user's activities

See merge request pleroma/pleroma!1008

lib/mix/tasks/pleroma/user.ex

@@ -32,6 +32,10 @@ defmodule Mix.Tasks.Pleroma.User do
 
       mix pleroma.user rm NICKNAME
 
+  ## Delete the user's activities.
+
+      mix pleroma.user delete_activities NICKNAME
+
   ## Deactivate or activate the user's account.
 
       mix pleroma.user toggle_activated NICKNAME
@@ -303,6 +307,18 @@ def run(["invite"]) do
     end
   end
 
+  def run(["delete_activities", nickname]) do
+    Common.start_pleroma()
+
+    with %User{local: true} = user <- User.get_by_nickname(nickname) do
+      User.delete_user_activities(user)
+      Mix.shell().info("User #{nickname} statuses deleted.")
+    else
+      _ ->
+        Mix.shell().error("No local user #{nickname}")
+    end
+  end
+
   defp set_moderator(user, value) do
     info_cng = User.Info.admin_api_update(user.info, %{is_moderator: value})
 

lib/pleroma/user.ex

@@ -1088,28 +1088,27 @@ def delete(%User{} = user) do
     # Remove all relationships
     {:ok, followers} = User.get_followers(user)
 
-    followers
+    Enum.each(followers, fn follower -> User.unfollow(follower, user) end)
-    |> Enum.each(fn follower -> User.unfollow(follower, user) end)
 
     {:ok, friends} = User.get_friends(user)
 
-    friends
+    Enum.each(friends, fn followed -> User.unfollow(user, followed) end)
-    |> Enum.each(fn followed -> User.unfollow(user, followed) end)
 
-    query =
+    delete_user_activities(user)
-      from(a in Activity, where: a.actor == ^user.ap_id)
+  end
+
+  def delete_user_activities(%User{ap_id: ap_id} = user) do
+    Activity
+    |> where(actor: ^ap_id)
     |> Activity.with_preloaded_object()
-
+    |> Repo.all()
-    Repo.all(query)
+    |> Enum.each(fn
-    |> Enum.each(fn activity ->
+      %{data: %{"type" => "Create"}} = activity ->
-      case activity.data["type"] do
+        activity |> Object.normalize() |> ActivityPub.delete()
-        "Create" ->
-          ActivityPub.delete(Object.normalize(activity))
 
       # TODO: Do something with likes, follows, repeats.
       _ ->
         "Doing nothing"
-      end
     end)
 
     {:ok, user}

test/tasks/user_test.exs

@@ -248,4 +248,14 @@ test "invite token is generated" do
       assert message =~ "Generated"
     end
   end
+
+  describe "running delete_activities" do
+    test "activities are deleted" do
+      %{nickname: nickname} = insert(:user)
+
+      assert :ok == Mix.Tasks.Pleroma.User.run(["delete_activities", nickname])
+      assert_received {:mix_shell, :info, [message]}
+      assert message == "User #{nickname} statuses deleted."
+    end
+  end
 end

test/user_test.exs

@@ -799,6 +799,16 @@ test ".deactivate can de-activate then re-activate a user" do
     assert false == user.info.deactivated
   end
 
+  test ".delete_user_activities deletes all create activities" do
+    user = insert(:user)
+
+    {:ok, activity} = CommonAPI.post(user, %{"status" => "2hu"})
+    {:ok, _} = User.delete_user_activities(user)
+
+    # TODO: Remove favorites, repeats, delete activities.
+    refute Activity.get_by_id(activity.id)
+  end
+
   test ".delete deactivates a user, all follow relationships and all create activities" do
     user = insert(:user)
     followed = insert(:user)