Connection pool: Fix a possible infinite recursion if the pool is exhausted

lib/pleroma/gun/connection_pool/worker_supervisor.ex

@@ -14,16 +14,14 @@ def init(_opts) do
     )
   end
 
-  def start_worker(opts) do
+  def start_worker(opts, retry \\ false) do
     case DynamicSupervisor.start_child(__MODULE__, {Pleroma.Gun.ConnectionPool.Worker, opts}) do
       {:error, :max_children} ->
-        case free_pool() do
+        if retry or free_pool() == :error do
-          :ok ->
+          :telemetry.execute([:pleroma, :connection_pool, :provision_failure], %{opts: opts})
-            start_worker(opts)
+          {:error, :pool_full}
-
+        else
-          :error ->
+          start_worker(opts, true)
-            :telemetry.execute([:pleroma, :connection_pool, :provision_failure], %{opts: opts})
-            {:error, :pool_full}
         end
 
       res ->