add elixir 1.16 test step

.buildpacks

@@ -0,0 +1 @@
+https://github.com/hashnuke/heroku-buildpack-elixir  

.gitignore

@@ -78,4 +78,3 @@ docs/venv
 # docker stuff
 docker-db
 *.iml
-docker-compose.override.yml

.woodpecker/build-docker.yml

@@ -0,0 +1,29 @@
+platform: linux/amd64
+
+
+variables:
+  - &on-release
+    when:
+      event:
+        - push
+        - tag
+      branch:
+        - docker
+  - &on-stable
+    when:
+      event:
+        - push
+        - tag
+      branch:
+        - stable
+
+pipeline:
+  build:
+    image: woodpeckerci/plugin-docker-buildx
+    secrets: [docker_username, docker_password]
+    <<: *on-release
+    settings:
+      repo: akkoma/akkoma
+      dockerfile: Dockerfile
+      platforms: linux/amd64,linux/arm64/v8
+      tag: test

.woodpecker/test.yml

@@ -7,7 +7,6 @@ matrix:
   ELIXIR_VERSION:
     - 1.14
     - 1.15
-    - 1.16
   OTP_VERSION:
     - 25
     - 26

CHANGELOG.md

@@ -6,104 +6,19 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
-## 2024.04
-
-## Added
-- Support for [FEP-fffd](https://codeberg.org/fediverse/fep/src/branch/main/fep/fffd/fep-fffd.md) (proxy objects)
-- Verified support for elixir 1.16
-- Uploadfilter `Pleroma.Upload.Filter.Exiftool.ReadDescription` returns description values to the FE so they can pre fill the image description field
-  NOTE: this filter MUST be placed before `Exiftool.StripMetadata` to work
-
-## Changed
-- Inbound pipeline error handing was modified somewhat, which should lead to less incomprehensible log spam. Hopefully.
-- Uploadfilter `Pleroma.Upload.Filter.Exiftool` was replaced by `Pleroma.Upload.Filter.Exiftool.StripMetadata`;
-  the latter strips all non-essential metadata by default but can be configured.
-  To regain the old behaviour of only stripping GPS data set `purge: ["gps:all"]`.
-- Uploadfilter `Pleroma.Upload.Filter.Exiftool` has been renamed to `Pleroma.Upload.Filter.Exiftool.StripMetadata`
-- MRF.InlineQuotePolicy now prefers to insert display URLs instead of ActivityPub IDs
-- Old accounts are no longer listed in WebFinger as aliases; this was breaking spec
-
-## Fixed
-- Issue preventing fetching anything from IPv6-only instances
-- Issue allowing post content to leak via opengraph tags despite :estrict\_unauthenticated being set
-- Move activities no longer operate on stale user data
-- Missing definitions in our JSON-LD context
-- Issue mangling newlines in code blocks for RSS/Atom feeds
-- static\_fe squeezing non-square avatars and emoji
-- Issue leading to properly JSON-LD compacted emoji reactions being rejected
-- We now use a standard-compliant Accept header when fetching ActivityPub objects
-- /api/pleroma/notification\_settings was rejecting body parameters;
-  this also broke changing this setting via akkoma-fe
-- Issue leading to Mastodon bot accounts being rejected
-- Scope misdetection of remote posts resulting from not recognising
-  JSON-LD-compacted forms of public scope; affected e.g. federation with bovine
-- Ratelimits encountered when fetching objects are now respected; 429 responses will cause a backoff when we get one.
-
-## Removed
-- ActivityPub Client-To-Server write API endpoints have been disabled;
-  read endpoints are planned to be removed next release unless a clear need is demonstrated
-
-## 2024.03
-
-## Added
-- CLI tasks best-effort checking for past abuse of the recent spoofing exploit
-- new `:mrf_steal_emoji, :download_unknown_size` option; defaults to `false`
-
-## Changed
-- `Pleroma.Upload, :base_url` now MUST be configured explicitly if used;
-  use of the same domain as the instance is **strongly** discouraged
-- `:media_proxy, :base_url` now MUST be configured explicitly if used;
-  use of the same domain as the instance is **strongly** discouraged
-- StealEmoji:
-  - now uses the pack.json format;
-    existing users must migrate with an out-of-band script (check release notes)
-  - only steals shortcodes recognised as valid
-  - URLs of stolen emoji is no longer predictable
-- The `Dedupe` upload filter is now always active;
-  `AnonymizeFilenames` is again opt-in
-- received AP data is sanity checked before we attempt to parse it as a user
-- Uploads, emoji and media proxy now restrict Content-Type headers to a safe subset
-- Akkoma will no longer fetch and parse objects hosted on the same domain
-
-## Fixed
-- Critical security issue allowing Akkoma to be used as a vector for
-  (depending on configuration) impersonation of other users or creation
-  of bogus users and posts on the upload domain
-- Critical security issue letting Akkoma fall for the above impersonation
-  payloads due to lack of strict id checking
-- Critical security issue allowing domains redirect to to pose as the initial domain
-  (e.g. with media proxy's fallback redirects)
-- refetched objects can no longer attribute themselves to third-party actors
-  (this had no externally visible effect since actor info is read from the Create activity)
-- our litepub JSON-LD schema is now served with the correct content type
-- remote APNG attachments are now recognised as images
-
-## Upgrade Notes
-
-- As mentioned in "Changed", `Pleroma.Upload, :base_url` **MUST** be configured. Uploads will fail without it.
-  - Akkoma will refuse to start if this is not set.
-- Same with media proxy.
-
-## 2024.02
-
 ## Added
 - Full compatibility with Erlang OTP26
 - handling of GET /api/v1/preferences
-- Akkoma API is now documented
-- ability to auto-approve follow requests from users you are already following
-- The SimplePolicy MRF can now strip user backgrounds from selected remote hosts
 
 ## Changed
 - OTP builds are now built on erlang OTP26
 - The base Phoenix framework is now updated to 1.7
 - An `outbox` field has been added to actor profiles to comply with AP spec
-- User profile backgrounds do now federate with other Akkoma instances and Sharkey
 
 ## Fixed
 - Documentation issue in which a non-existing nginx file was referenced
 - Issue where a bad inbox URL could break federation
 - Issue where hashtag rel values would be scrubbed
-- Issue where short domains listed in `transparency_obfuscate_domains` were not actually obfuscated
 
 ## 2023.08
 

Dockerfile

@@ -1,10 +1,35 @@
-FROM hexpm/elixir:1.15.4-erlang-26.0.2-alpine-3.18.2
+##############################################
+# BUILD CONTAINER
+##############################################
+
+FROM hexpm/elixir:1.16.0-erlang-26.2.1-alpine-3.18.4 as BUILD
 
 ENV MIX_ENV=prod
+
+RUN apk add git gcc g++ musl-dev make cmake file-dev exiftool ffmpeg imagemagick libmagic ncurses postgresql-client
+
+WORKDIR /src
+ADD mix.exs mix.lock /src/
+ADD ./restarter /src/restarter/
+ADD ./priv /src/priv/
+ADD ./installation /src/installation/
+ADD ./rel /src/rel/
+ADD ./config /src/config/
+ADD ./docs /src/docs/
+ADD ./lib /src/lib/
+
+RUN mix local.hex --force && \
+    mix local.rebar --force
+
+RUN mix deps.get --only=prod
+
+RUN mix release --path /release
+
+#################################################
+# RUNTIME CONTAINER
+#################################################
+FROM alpine:3.18
 ENV ERL_EPMD_ADDRESS=127.0.0.1
-
-ARG HOME=/opt/akkoma
-
 LABEL org.opencontainers.image.title="akkoma" \
     org.opencontainers.image.description="Akkoma for Docker" \
     org.opencontainers.image.vendor="akkoma.dev" \
@@ -14,21 +39,16 @@ LABEL org.opencontainers.image.title="akkoma" \
     org.opencontainers.image.revision=$VCS_REF \
     org.opencontainers.image.created=$BUILD_DATE
 
-RUN apk add git gcc g++ musl-dev make cmake file-dev exiftool ffmpeg imagemagick libmagic ncurses postgresql-client
+RUN apk add ffmpeg imagemagick exiftool ncurses postgresql-client file-dev libmagic
 
+COPY --from=BUILD /release /opt/akkoma/
+ADD ./docker-entrypoint.sh /opt/akkoma/
 EXPOSE 4000
 
-ARG UID=1000
-ARG GID=1000
-ARG UNAME=akkoma
-
-RUN addgroup -g $GID $UNAME
-RUN adduser -u $UID -G $UNAME -D -h $HOME $UNAME
+VOLUME /opt/akkoma/uploads/
+VOLUME /opt/akkoma/instance/
+VOLUME /opt/akkoma/config/docker-config.exs
 
 WORKDIR /opt/akkoma
 
-USER $UNAME
-RUN mix local.hex --force &&\
-    mix local.rebar --force
-
-CMD ["/opt/akkoma/docker-entrypoint.sh"]
+CMD [ "/opt/akkoma/docker-entrypoint.sh" ]

Procfile

@@ -0,0 +1,2 @@
+web: mix phx.server
+release: mix ecto.migrate

SECURITY.md

@@ -1,21 +1,16 @@
-# Akkoma backend security handling
+# Pleroma backend security policy
+
+## Supported versions
+
+Currently, Pleroma offers bugfixes and security patches only for the latest minor release.
+
+| Version | Support 
+|---------| --------
+| 2.2     | Bugfixes and security patches
 
 ## Reporting a vulnerability
 
-Please send an email (preferably encrypted) or
-a DM via our IRC to one of the following people:
-
-| Forgejo nick | IRC nick      | Email         | GPG                                     |
-| ------------ | ------------- | ------------- | --------------------------------------- |
-| floatinghost | FloatingGhost | *see GPG key* | https://coffee-and-dreams.uk/pubkey.asc |
-
+Please use confidential issues (tick the "This issue is confidential and should only be visible to team members with at least Reporter access." box when submitting) at our [bugtracker](https://git.pleroma.social/pleroma/pleroma/-/issues/new) for reporting vulnerabilities.
 ## Announcements
 
-New releases and security issues are announced at
-[meta.akkoma.dev](https://meta.akkoma.dev/c/releases) and
-[@akkoma@ihatebeinga.live](https://ihatebeinga.live/akkoma).
-
-Both also offer RSS feeds
-([meta](https://meta.akkoma.dev/c/releases/7.rss),
-[fedi](https://ihatebeinga.live/users/akkoma.rss))
-so you can keep an eye on it without any accounts.
+New releases are announced at [pleroma.social](https://pleroma.social/announcements/). All security releases are tagged with ["Security"](https://pleroma.social/announcements/tags/security/). You can be notified of them by subscribing to an Atom feed at <https://pleroma.social/announcements/tags/security/feed.xml>. 

config/config.exs

@@ -61,12 +61,11 @@ config :pleroma, Pleroma.Captcha.Kocaptcha, endpoint: "https://captcha.kotobank.
 # Upload configuration
 config :pleroma, Pleroma.Upload,
   uploader: Pleroma.Uploaders.Local,
-  filters: [],
+  filters: [Pleroma.Upload.Filter.Dedupe],
   link_name: false,
   proxy_remote: false,
   filename_display_max_length: 30,
-  base_url: nil,
-  allowed_mime_types: ["image", "audio", "video"]
+  base_url: nil
 
 config :pleroma, Pleroma.Uploaders.Local, uploads: "uploads"
 
@@ -149,38 +148,18 @@ config :logger, :ex_syslogger,
   format: "$metadata[$level] $message",
   metadata: [:request_id]
 
-# ———————————————————————————————————————————————————————————————
-#                       W  A  R  N  I  N  G
-# ———————————————————————————————————————————————————————————————
-#
-#  Whenever adding a privileged new custom type for e.g.
-#  ActivityPub objects, ALWAYS map their extension back
-#  to "application/octet-stream".
-#  Else files served by us can automatically end up with
-#  those privileged types causing severe security hazards.
-#  (We need those mappings so Phoenix can assoiate its format
-#   (the "extension") to incoming requests of those MIME types)
-#
-# ———————————————————————————————————————————————————————————————
 config :mime, :types, %{
   "application/xml" => ["xml"],
   "application/xrd+xml" => ["xrd+xml"],
   "application/jrd+json" => ["jrd+json"],
   "application/activity+json" => ["activity+json"],
-  "application/ld+json" => ["activity+json"],
-  # Can be removed when bumping MIME past 2.0.5
-  # see https://akkoma.dev/AkkomaGang/akkoma/issues/657
-  "image/apng" => ["apng"]
+  "application/ld+json" => ["activity+json"]
 }
 
 config :mime, :extensions, %{
-  "xrd+xml" => "text/plain",
-  "jrd+json" => "text/plain",
-  "activity+json" => "text/plain"
+  "activity+json" => "application/activity+json"
 }
 
-# ———————————————————————————————————————————————————————————————
-
 config :tesla, :adapter, {Tesla.Adapter.Finch, name: MyFinch}
 
 # Configures http settings, upstream proxy etc.
@@ -311,6 +290,7 @@ config :pleroma, :frontend_configurations,
     alwaysShowSubjectInput: true,
     background: "/images/city.jpg",
     collapseMessageWithSubject: false,
+    disableChat: false,
     greentext: false,
     hideFilteredStatuses: false,
     hideMutedPosts: false,
@@ -398,7 +378,6 @@ config :pleroma, :mrf_simple,
   accept: [],
   avatar_removal: [],
   banner_removal: [],
-  background_removal: [],
   reject_deletes: [],
   handle_threads: true
 
@@ -427,6 +406,8 @@ config :pleroma, :mrf_object_age,
   threshold: 604_800,
   actions: [:delist, :strip_followers]
 
+config :pleroma, :mrf_follow_bot, follower_nickname: nil
+
 config :pleroma, :mrf_reject_newly_created_account_notes, age: 86_400
 
 config :pleroma, :rich_media,
@@ -472,6 +453,10 @@ config :pleroma, :media_preview_proxy,
   image_quality: 85,
   min_content_length: 100 * 1024
 
+config :pleroma, :shout,
+  enabled: true,
+  limit: 5_000
+
 config :phoenix, :format_encoders, json: Jason, "activity+json": Jason
 
 config :phoenix, :json_library, Jason

config/description.exs

@@ -100,22 +100,9 @@ config :pleroma, :config_description, [
         label: "Base URL",
         type: :string,
         description:
-          "Base URL for the uploads. Required if you use a CDN or host attachments under a different domain - it is HIGHLY recommended that you **do not** set this to be the same as the domain akkoma is hosted on.",
+          "Base URL for the uploads. Required if you use a CDN or host attachments under a different domain.",
         suggestions: [
-          "https://media.akkoma.dev/media/"
-        ]
-      },
-      %{
-        key: :allowed_mime_types,
-        label: "Allowed MIME types",
-        type: {:list, :string},
-        description:
-          "List of MIME (main) types uploads are allowed to identify themselves with. Other types may still be uploaded, but will identify as a generic binary to clients. WARNING: Loosening this over the defaults can lead to security issues. Removing types is safe, but only add to the list if you are sure you know what you are doing.",
-        suggestions: [
-          "image",
-          "audio",
-          "video",
-          "font"
+          "https://cdn-host.com"
         ]
       },
       %{
@@ -222,26 +209,6 @@ config :pleroma, :config_description, [
       }
     ]
   },
-  %{
-    group: :pleroma,
-    key: Pleroma.Upload.Filter.Exiftool.StripMetadata,
-    type: :group,
-    description: "Strip specified metadata from image uploads",
-    children: [
-      %{
-        key: :purge,
-        description: "Metadata fields or groups to strip",
-        type: {:list, :string},
-        suggestions: ["all", "CommonIFD0"]
-      },
-      %{
-        key: :preserve,
-        description: "Metadata fields or groups to preserve (takes precedence over stripping)",
-        type: {:list, :string},
-        suggestions: ["ColorSpaces", "Orientation"]
-      }
-    ]
-  },
   %{
     group: :pleroma,
     key: Pleroma.Emails.Mailer,

config/dokku.exs

@@ -0,0 +1,25 @@
+import Config
+
+config :pleroma, Pleroma.Web.Endpoint,
+  http: [
+    port: String.to_integer(System.get_env("PORT") || "4000"),
+    protocol_options: [max_request_line_length: 8192, max_header_value_length: 8192]
+  ],
+  protocol: "http",
+  secure_cookie_flag: false,
+  url: [host: System.get_env("APP_HOST"), scheme: "https", port: 443],
+  secret_key_base: "+S+ULgf7+N37c/lc9K66SMphnjQIRGklTu0BRr2vLm2ZzvK0Z6OH/PE77wlUNtvP"
+
+database_url =
+  System.get_env("DATABASE_URL") ||
+    raise """
+    environment variable DATABASE_URL is missing.
+    For example: ecto://USER:PASS@HOST/DATABASE
+    """
+
+config :pleroma, Pleroma.Repo,
+  # ssl: true,
+  url: database_url,
+  pool_size: String.to_integer(System.get_env("POOL_SIZE") || "10")
+
+config :pleroma, :instance, name: "#{System.get_env("APP_NAME")} CI Instance"

config/test.exs

@@ -22,12 +22,9 @@ config :logger, :console,
 config :pleroma, :auth, oauth_consumer_strategies: []
 
 config :pleroma, Pleroma.Upload,
-  base_url: "http://localhost:4001/media/",
   filters: [],
   link_name: false
 
-config :pleroma, :media_proxy, base_url: "http://localhost:4001"
-
 config :pleroma, Pleroma.Uploaders.Local, uploads: "test/uploads"
 
 config :pleroma, Pleroma.Emails.Mailer, adapter: Swoosh.Adapters.Test, enabled: true

coveralls.json

@@ -0,0 +1,7 @@
+{
+  "skip_files": [
+    "test/support",
+    "lib/mix/tasks/pleroma/benchmark.ex",
+    "lib/credo/check/consistency/file_location.ex"
+  ]
+}

docker-compose.yml

@@ -2,11 +2,9 @@ version: "3.7"
 
 services:
   db:
-    image: akkoma-db:latest
-    build: ./docker-resources/database
+    image: postgres:14
     shm_size: 4gb
     restart: unless-stopped
-    user: ${DOCKER_USER}
     environment: {
       # This might seem insecure but is usually not a problem.
       # You should leave this at the "akkoma" default.
@@ -21,16 +19,17 @@ services:
     env_file:
       - .env 
     volumes:
-      - type: bind
-        source: ./pgdata
-        target: /var/lib/postgresql/data
+      - ./pgdata:/var/lib/postgresql/data:Z
+        
 
   akkoma:
     image: akkoma:latest
-    build: .
     restart: unless-stopped
     env_file:
       - .env
+    environment: {
+      "AKKOMA_CONFIG_PATH": "/opt/akkoma/config/docker-config.exs"
+    }
     links:
       - db
     ports: [
@@ -44,9 +43,11 @@ services:
       "127.0.0.1:4000:4000",
     ]
     volumes:
-      - .:/opt/akkoma
+    - ./uploads:/opt/akkoma/uploads:Z
+    - ./instance:/opt/akkoma/instance:Z
+    - ./config/docker-config.exs:/opt/akkoma/config/docker-config.exs:Z
 
-  # Copy this into docker-compose.override.yml and uncomment there if you want to use a reverse proxy
+  # Uncomment the following if you want to use a reverse proxy
   #proxy:
   #  image: caddy:2-alpine
   #  restart: unless-stopped
@@ -60,3 +61,6 @@ services:
   #    - ./docker-resources/Caddyfile:/etc/caddy/Caddyfile
   #    - ./caddy-data:/data
   #    - ./caddy-config:/config
+
+volumes:
+  db-data:

docker-entrypoint.sh

@@ -8,7 +8,7 @@ while ! pg_isready -U ${DB_USER:-pleroma} -d postgres://${DB_HOST:-db}:5432/${DB
 done
 
 echo "-- Running migrations..."
-mix ecto.migrate
+/opt/akkoma/bin/pleroma_ctl migrate
 
 echo "-- Starting!"
-mix phx.server
+/opt/akkoma/bin/pleroma start

docker-resources/generate-instance

@@ -0,0 +1,16 @@
+#!/bin/bash
+
+mkdir -p ./uploads ./instance
+
+podman run \
+    -v ./config:/opt/akkoma/config/:Z \
+    -v ./uploads:/opt/akkoma/uploads/:Z \
+    -v ./instance:/opt/akkoma/instance/:Z \
+    -it akkoma ./bin/pleroma_ctl instance gen \
+        --dbhost db \
+        --dbname akkoma \
+        --dbpass akkoma \
+        --dbuser akkoma \
+        --static-dir /opt/akkoma/instance/ \
+        --uploads-dir /opt/akkoma/uploads/ \
+        --listen-ip 0.0.0.0 $@

docker-resources/install-frontend

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+podman compose run -e "PLEROMA_CTL_RPC_DISABLED=true" --rm akkoma ./bin/pleroma_ctl frontend install pleroma-fe --ref stable

docker-resources/manage.sh

@@ -1,3 +1,3 @@
 #!/bin/sh
 
-docker compose run --rm akkoma $@
+podman compose run -e "PLEROMA_CTL_RPC_DISABLED=true" --rm akkoma ./bin/pleroma_ctl $@

docs/docs/administration/CLI_tasks/instance.md

@@ -37,8 +37,7 @@ If any of the options are left unspecified, you will be prompted interactively.
 - `--static-dir <path>` - the directory custom public files should be read from (custom emojis, frontend bundle overrides, robots.txt, etc.)
 - `--listen-ip <ip>` - the ip the app should listen to, defaults to 127.0.0.1
 - `--listen-port <port>` - the port the app should listen to, defaults to 4000
-- `--strip-uploads-metadata <Y|N>` - use ExifTool to strip uploads of metadata when possible
-- `--read-uploads-description <Y|N>` - use ExifTool to read image descriptions from uploads
+- `--strip-uploads <Y|N>` - use ExifTool to strip uploads of sensitive location data
 - `--anonymize-uploads <Y|N>` - randomize uploaded filenames
 - `--dedupe-uploads <Y|N>` - store files based on their hash to reduce data storage requirements if duplicates are uploaded with different filenames
 - `--skip-release-env` - skip generation the release environment file

docs/docs/administration/CLI_tasks/security.md

@@ -1,56 +0,0 @@
-# Security-related tasks
-
-{! administration/CLI_tasks/general_cli_task_info.include !}
-
-!!! danger
-    Many of these tasks were written in response to a patched exploit.
-    It is recommended to run those very soon after installing its respective security update.
-    Over time with db migrations they might become less accurate or be removed altogether.
-    If you never ran an affected version, there’s no point in running them.
-
-## Spoofed AcitivityPub objects exploit (2024-03, fixed in 3.11.1)
-
-### Search for uploaded spoofing payloads
-
-Scans local uploads for spoofing payloads.
-If the instance is not using the local uploader it was not affected.
-Attachments wil be scanned anyway in case local uploader was used in the past.
-
-!!! note
-    This cannot reliably detect payloads attached to deleted posts.
-
-=== "OTP"
-
-    ```sh
-    ./bin/pleroma_ctl security spoof-uploaded
-    ```
-
-=== "From Source"
-
-    ```sh
-    mix pleroma.security spoof-uploaded
-    ```
-
-### Search for counterfeit posts in database
-
-Scans all notes in the database for signs of being spoofed.
-
-!!! note
-    Spoofs targeting local accounts can be detected rather reliably
-    (with some restrictions documented in the task’s logs).
-    Counterfeit posts from remote users cannot. A best-effort attempt is made, but
-    a thorough attacker can avoid this and it may yield a small amount of false positives.
-
-    Should you find counterfeit posts of local users, let other admins know so they can delete the too.
-
-=== "OTP"
-
-    ```sh
-    ./bin/pleroma_ctl security spoof-inserted
-    ```
-
-=== "From Source"
-
-    ```sh
-    mix pleroma.security spoof-inserted
-    ```

docs/docs/administration/monitoring.md

@@ -3,7 +3,7 @@
 If you run akkoma, you may be inclined to collect metrics to ensure your instance is running smoothly,
 and that there's nothing quietly failing in the background.
 
-To facilitate this, akkoma exposes a dashboard and prometheus metrics to be scraped.
+To facilitate this, akkoma exposes prometheus metrics to be scraped.
 
 ## Prometheus
 
@@ -31,15 +31,3 @@ Once you have your token of the form `Bearer $ACCESS_TOKEN`, you can use that in
   - targets:
     - example.com
 ```
-
-## Dashboard
-
-Administrators can access a live dashboard under `/phoenix/live_dashboard`
-giving an overview of uptime, software versions, database stats and more.
-
-The dashboard also includes a variation of the prometheus metrics, however
-they do not exactly match due to respective limitations of the dashboard
-and the prometheus exporter.
-Even more important, the dashboard collects metrics locally in the browser
-only while the page is open and cannot give a view on their past history.
-For proper monitoring it is recommended to set up prometheus.

docs/docs/clients.md

@@ -1,15 +1,12 @@
 # Akkoma Clients
-This is a list of clients that are known to work with Akkoma.
-
-!!! warning
-    **Clients listed here are not officially supported by the Akkoma project.**
-    Some Akkoma features may be unsupported by these clients.
+Note: Additional clients may work, but these are known to work with Akkoma.
+Apps listed here might not support all of Akkoma's features.
 
 ## Multiplatform
 ### Kaiteki
 - Homepage: <https://kaiteki.app/>
 - Source Code: <https://github.com/Kaiteki-Fedi/Kaiteki>
-- Contact: [@kaiteki@social.kaiteki.app](https://social.kaiteki.app/@kaiteki)
+- Contact: [@kaiteki@fedi.software](https://fedi.software/@Kaiteki)
 - Platforms: Web, Windows, Linux, Android
 - Features: MastoAPI, Supports multiple backends
 
@@ -41,6 +38,12 @@ This is a list of clients that are known to work with Akkoma.
 - Platforms: Android
 - Features: MastoAPI, No Streaming, Emoji Reactions, Text Formatting, FE Stickers
 
+### Fedi
+- Homepage: <https://www.fediapp.com/>
+- Source Code: Proprietary, but gratis
+- Platforms: iOS, Android
+- Features: MastoAPI, Pleroma-specific features like Reactions
+
 ### Tusky
 - Homepage: <https://tuskyapp.github.io/>
 - Source Code: <https://github.com/tuskyapp/Tusky>
@@ -48,18 +51,12 @@ This is a list of clients that are known to work with Akkoma.
 - Platforms: Android
 - Features: MastoAPI, No Streaming
 
-### Subway Tooter
-- Source Code: <https://github.com/tateisu/SubwayTooter/>
-- Contact: [@SubwayTooter@mastodon.juggler.jp](https://mastodon.juggler.jp/@SubwayTooter)
-- Platforms: Android
-- Features: MastoAPI, Editing, Emoji Reactions (including custom emoji)
-
 ## Alternative Web Interfaces
-### Enafore
-- An actively developed fork of Pinafore with improved Akkoma support
-- Homepage: <https://enafore.social/>
-- Source Code: <https://github.com/enafore/enafore>
-- Contact: [@enfore@enafore.social](https://meta.enafore.social/@enafore)
+### Pinafore
+- Note: Pinafore is unmaintained (See [the author's original article](https://nolanlawson.com/2023/01/09/retiring-pinafore/) for details)
+- Homepage: <https://pinafore.social/>
+- Source Code: <https://github.com/nolanlawson/pinafore>
+- Contact: [@pinafore@mastodon.technology](https://mastodon.technology/users/pinafore)
 - Features: MastoAPI, No Streaming
 
 ### Sengi

docs/docs/configuration/cheatsheet.md

@@ -104,60 +104,31 @@ To add configuration to your config file, you can copy it from the base config.
 ## Message rewrite facility
 
 ### :mrf
-* `transparency`: Make the content of your Message Rewrite Facility settings public (via nodeinfo).
-* `transparency_exclusions`: Exclude specific instance names from MRF transparency.  The use of the exclusions feature will be disclosed in nodeinfo as a boolean value.
-* `transparency_obfuscate_domains`: Show domains with `*` in the middle, to censor them if needed. For example, `ridingho.me` will show as `rid*****.me`
 * `policies`: Message Rewrite Policy, either one or a list. Here are the ones available by default:
     * `Pleroma.Web.ActivityPub.MRF.NoOpPolicy`: Doesn’t modify activities (default).
     * `Pleroma.Web.ActivityPub.MRF.DropPolicy`: Drops all activities. It generally doesn’t makes sense to use in production.
-    * `Pleroma.Web.ActivityPub.MRF.ActivityExpirationPolicy`: Sets a default expiration on all posts made by users of the local instance. Requires `Pleroma.Workers.PurgeExpiredActivity` to be enabled for processing the scheduled delections.
-      (See [`:mrf_activity_expiration`](#mrf_activity_expiration))
-    * `Pleroma.Web.ActivityPub.MRF.AntiFollowbotPolicy`: Drops follow requests from followbots. Users can still allow bots to follow them by first following the bot.
-    * `Pleroma.Web.ActivityPub.MRF.AntiLinkSpamPolicy`: Rejects posts from likely spambots by rejecting posts from new users that contain links.
+    * `Pleroma.Web.ActivityPub.MRF.SimplePolicy`: Restrict the visibility of activities from certains instances (See [`:mrf_simple`](#mrf_simple)).
+    * `Pleroma.Web.ActivityPub.MRF.TagPolicy`: Applies policies to individual users based on tags, which can be set using pleroma-fe/admin-fe/any other app that supports Pleroma Admin API. For example it allows marking posts from individual users nsfw (sensitive).
+    * `Pleroma.Web.ActivityPub.MRF.SubchainPolicy`: Selectively runs other MRF policies when messages match (See [`:mrf_subchain`](#mrf_subchain)).
+    * `Pleroma.Web.ActivityPub.MRF.RejectNonPublic`: Drops posts with non-public visibility settings (See [`:mrf_rejectnonpublic`](#mrf_rejectnonpublic)).
     * `Pleroma.Web.ActivityPub.MRF.EnsureRePrepended`: Rewrites posts to ensure that replies to posts with subjects do not have an identical subject and instead begin with re:.
-    * `Pleroma.Web.ActivityPub.MRF.ForceBotUnlistedPolicy`: Makes all bot posts to disappear from public timelines.
-    * `Pleroma.Web.ActivityPub.MRF.HellthreadPolicy`: Blocks messages with too many mentions.
-      (See [`mrf_hellthread`](#mrf_hellthread))
-    * `Pleroma.Web.ActivityPub.MRF.KeywordPolicy`: Rejects or removes from the federated timeline or replaces keywords. (See [`:mrf_keyword`](#mrf_keyword)).
+    * `Pleroma.Web.ActivityPub.MRF.AntiLinkSpamPolicy`: Rejects posts from likely spambots by rejecting posts from new users that contain links.
     * `Pleroma.Web.ActivityPub.MRF.MediaProxyWarmingPolicy`: Crawls attachments using their MediaProxy URLs so that the MediaProxy cache is primed.
     * `Pleroma.Web.ActivityPub.MRF.MentionPolicy`: Drops posts mentioning configurable users. (See [`:mrf_mention`](#mrf_mention)).
-    * `Pleroma.Web.ActivityPub.MRF.NoEmptyPolicy`: Drops local activities which have no actual content.
-       (e.g. no attachments and only consists of mentions)
-    * `Pleroma.Web.ActivityPub.MRF.NoPlaceholderTextPolicy`: Strips content placeholders from posts
-      (such as the dot from mastodon)
-    * `Pleroma.Web.ActivityPub.MRF.ObjectAgePolicy`: Rejects or delists posts based on their age when received. (See [`:mrf_object_age`](#mrf_object_age)).
-    * `Pleroma.Web.ActivityPub.MRF.RejectNewlyCreatedAccountNotesPolicy`: Rejects posts of users the server only recently learned about for a while. Great to block spam accounts. (See [`:mrf_reject_newly_created_account_notes`](#mrf_reject_newly_created_account_notes))
-    * `Pleroma.Web.ActivityPub.MRF.RejectNonPublic`: Drops posts with non-public visibility settings (See [`:mrf_rejectnonpublic`](#mrf_rejectnonpublic)).
-    * `Pleroma.Web.ActivityPub.MRF.SimplePolicy`: Restrict the visibility of activities from certains instances (See [`:mrf_simple`](#mrf_simple)).
-    * `Pleroma.Web.ActivityPub.MRF.StealEmojiPolicy`: Steals all eligible emoji encountered in posts from remote instances
-      (See [`:mrf_steal_emoji`](#mrf_steal_emoji))
-    * `Pleroma.Web.ActivityPub.MRF.SubchainPolicy`: Selectively runs other MRF policies when messages match (See [`:mrf_subchain`](#mrf_subchain)).
-    * `Pleroma.Web.ActivityPub.MRF.TagPolicy`: Applies policies to individual users based on tags, which can be set using pleroma-fe/admin-fe/any other app that supports Pleroma Admin API. For example it allows marking posts from individual users nsfw (sensitive).
-    * `Pleroma.Web.ActivityPub.MRF.UserAllowListPolicy`: Drops all posts except from users specified in a list.
-      (See [`:mrf_user_allowlist`](#mrf_user_allowlist))
     * `Pleroma.Web.ActivityPub.MRF.VocabularyPolicy`: Restricts activities to a configured set of vocabulary. (See [`:mrf_vocabulary`](#mrf_vocabulary)).
-
-Additionally the following MRFs will *always* be aplied and cannot be disabled:
-
-* `Pleroma.Web.ActivityPub.MRF.DirectMessageDisabledPolicy`: Strips users limiting who can send them DMs from the recipients of non-eligible DMs
-* `Pleroma.Web.ActivityPub.MRF.HashtagPolicy`: Depending on a post’s hashtags it can be rejected, get its sensitive flags force-enabled or removed from the global timeline
-    (See [`:mrf_hashtag`](#mrf_hashtag))
-* `Pleroma.Web.ActivityPub.MRF.InlineQuotePolicy`: Append a link to a post that quotes another post with the link to the quoted post, to ensure that software that does not understand quotes can have full context.
-    (See [`:mrf_inline_quote`](#mrf_inline_quote))
-* `Pleroma.Web.ActivityPub.MRF.NormalizeMarkup`: Pass inbound HTML through a scrubber to make sure it doesn't have anything unusual in it.
-    (See [`:mrf_normalize_markup`](#mrf_normalize_markup))
-
+    * `Pleroma.Web.ActivityPub.MRF.ObjectAgePolicy`: Rejects or delists posts based on their age when received. (See [`:mrf_object_age`](#mrf_object_age)).
+    * `Pleroma.Web.ActivityPub.MRF.ActivityExpirationPolicy`: Sets a default expiration on all posts made by users of the local instance. Requires `Pleroma.Workers.PurgeExpiredActivity` to be enabled for processing the scheduled delections.
+    * `Pleroma.Web.ActivityPub.MRF.ForceBotUnlistedPolicy`: Makes all bot posts to disappear from public timelines.
+    * `Pleroma.Web.ActivityPub.MRF.FollowBotPolicy`: Automatically follows newly discovered users from the specified bot account. Local accounts, locked accounts, and users with "#nobot" in their bio are respected and excluded from being followed.
+    * `Pleroma.Web.ActivityPub.MRF.AntiFollowbotPolicy`: Drops follow requests from followbots. Users can still allow bots to follow them by first following the bot.
+    * `Pleroma.Web.ActivityPub.MRF.KeywordPolicy`: Rejects or removes from the federated timeline or replaces keywords. (See [`:mrf_keyword`](#mrf_keyword)).
+    * `Pleroma.Web.ActivityPub.MRF.NormalizeMarkup`: Pass inbound HTML through a scrubber to make sure it doesn't have anything unusual in it. On by default, cannot be turned off.
+    * `Pleroma.Web.ActivityPub.MRF.InlineQuotePolicy`: Append a link to a post that quotes another post with the link to the quoted post, to ensure that software that does not understand quotes can have full context. On by default, cannot be turned off.
+* `transparency`: Make the content of your Message Rewrite Facility settings public (via nodeinfo).
+* `transparency_exclusions`: Exclude specific instance names from MRF transparency.  The use of the exclusions feature will be disclosed in nodeinfo as a boolean value.
+* `transparency_obfuscate_domains`: Show domains with `*` in the middle, to censor them if needed. For example, `ridingho.me` will show as `rid*****.me`
 
 ## Federation
-### :activitypub
-* `unfollow_blocked`: Whether blocks result in people getting unfollowed
-* `outgoing_blocks`: Whether to federate blocks to other instances
-* `blockers_visible`: Whether a user can see the posts of users who blocked them
-* `deny_follow_blocked`: Whether to disallow following an account that has blocked the user in question
-* `sign_object_fetches`: Sign object fetches with HTTP signatures
-* `authorized_fetch_mode`: Require HTTP signatures for AP fetches
-* `max_collection_objects`: The maximum number of objects to fetch from a remote AP collection.
-
 ### MRF policies
 
 !!! note
@@ -173,7 +144,6 @@ Additionally the following MRFs will *always* be aplied and cannot be disabled:
 * `report_removal`: List of instances to reject reports from and the reason for doing so.
 * `avatar_removal`: List of instances to strip avatars from and the reason for doing so.
 * `banner_removal`: List of instances to strip banners from and the reason for doing so.
-* `background_removal`: List of instances to strip user backgrounds from and the reason for doing so.
 * `reject_deletes`: List of instances to reject deletions from and the reason for doing so.
 
 #### :mrf_subchain
@@ -236,9 +206,7 @@ config :pleroma, :mrf_user_allowlist, %{
 #### :mrf_steal_emoji
 * `hosts`: List of hosts to steal emojis from
 * `rejected_shortcodes`: Regex-list of shortcodes to reject
-* `size_limit`: File size limit (in bytes), checked before download if possible (and remote server honest),
-   otherwise or again checked before saving emoji to the disk
-* `download_unknown_size`: whether to download an emoji when the remote server doesn’t report its size in advance
+* `size_limit`: File size limit (in bytes), checked before an emoji is saved to the disk
 
 #### :mrf_activity_expiration
 
@@ -254,24 +222,14 @@ Notes:
 - The hashtags in the configuration do not have a leading `#`.
 - This MRF Policy is always enabled, if you want to disable it you have to set empty lists
 
-#### :mrf_reject_newly_created_account_notes
-After initially encountering an user, all their posts
-will be rejected for the configured time (in seconds).
-Only drops posts. Follows, reposts, etc. are not affected.
-
-* `age`: Time below which to reject (in seconds)
-
-An example: (86400 seconds = 24 hours)
-
-```elixir
-config :pleroma, :mrf_reject_newly_created_account_notes, age: 86400
-```
-
-#### :mrf_inline_quote
-* `prefix`: what prefix to prepend to quoted URLs
-
-#### :mrf_normalize_markup
-* `scrub_policy`: the scrubbing module to use (by default a built-in HTML sanitiser)
+### :activitypub
+* `unfollow_blocked`: Whether blocks result in people getting unfollowed
+* `outgoing_blocks`: Whether to federate blocks to other instances
+* `blockers_visible`: Whether a user can see the posts of users who blocked them
+* `deny_follow_blocked`: Whether to disallow following an account that has blocked the user in question
+* `sign_object_fetches`: Sign object fetches with HTTP signatures
+* `authorized_fetch_mode`: Require HTTP signatures for AP fetches
+* `max_collection_objects`: The maximum number of objects to fetch from a remote AP collection.
 
 ## Pleroma.User
 
@@ -398,8 +356,7 @@ This section describe PWA manifest instance-specific values. Currently this opti
 ## :media_proxy
 
 * `enabled`: Enables proxying of remote media to the instance’s proxy
-* `base_url`: The base URL to access a user-uploaded file.
-  Using a (sub)domain distinct from the instance endpoint is **strongly** recommended.
+* `base_url`: The base URL to access a user-uploaded file. Useful when you want to proxy the media files via another host/CDN fronts.
 * `proxy_opts`: All options defined in `Pleroma.ReverseProxy` documentation, defaults to `[max_body_length: (25*1_048_576)]`.
 * `whitelist`: List of hosts with scheme to bypass the mediaproxy (e.g. `https://example.com`)
 * `invalidation`: options for remove media from cache after delete object:
@@ -600,9 +557,8 @@ the source code is here: [kocaptcha](https://github.com/koto-bank/kocaptcha). Th
 
 * `uploader`: Which one of the [uploaders](#uploaders) to use.
 * `filters`: List of [upload filters](#upload-filters) to use.
-* `link_name`: When enabled Akkoma will add a `name` parameter to the url of the upload, for example `https://instance.tld/media/corndog.png?name=corndog.png`. This is needed to provide the correct filename in Content-Disposition headers
-* `base_url`: The base URL to access a user-uploaded file; MUST be configured explicitly.
-  Using a (sub)domain distinct from the instance endpoint is **strongly** recommended. A good value might be `https://media.myakkoma.instance/media/`. 
+* `link_name`: When enabled Akkoma will add a `name` parameter to the url of the upload, for example `https://instance.tld/media/corndog.png?name=corndog.png`. This is needed to provide the correct filename in Content-Disposition headers when using filters like `Pleroma.Upload.Filter.Dedupe`
+* `base_url`: The base URL to access a user-uploaded file. Useful when you want to host the media files via another domain or are using a 3rd party S3 provider.
 * `proxy_remote`: If you're using a remote uploader, Akkoma will proxy media requests instead of redirecting to it.
 * `proxy_opts`: Proxy options, see `Pleroma.ReverseProxy` documentation.
 * `filename_display_max_length`: Set max length of a filename to display. 0 = no limit. Default: 30.
@@ -642,29 +598,20 @@ config :ex_aws, :s3,
 
 ### Upload filters
 
-#### Pleroma.Upload.Filter.Dedupe
-
-**Always** active; cannot be turned off.
-Renames files to their hash and prevents duplicate files filling up the disk.
-No specific configuration.
-
 #### Pleroma.Upload.Filter.AnonymizeFilename
 
-This filter replaces the declared filename (not the path) of an upload.
+This filter replaces the filename (not the path) of an upload. For complete obfuscation, add
+`Pleroma.Upload.Filter.Dedupe` before AnonymizeFilename.
 
 * `text`: Text to replace filenames in links. If empty, `{random}.extension` will be used. You can get the original filename extension by using `{extension}`, for example `custom-file-name.{extension}`.
 
-#### Pleroma.Upload.Filter.Exiftool.StripMetadata
+#### Pleroma.Upload.Filter.Dedupe
 
-This filter strips metadata with Exiftool leaving color profiles and orientation intact.
+No specific configuration.
 
-* `purge`: List of Exiftool tag names or tag group names to purge
-* `preserve`: List of Exiftool tag names or tag group names to preserve even if they occur in the purge list
+#### Pleroma.Upload.Filter.Exiftool
 
-
-#### Pleroma.Upload.Filter.Exiftool.ReadDescription
-
-This filter reads the ImageDescription and iptc:Caption-Abstract fields with Exiftool so clients can prefill the media description field.
+This filter only strips the GPS and location metadata with Exiftool leaving color profiles and attributes intact.
 
 No specific configuration.
 
@@ -1011,15 +958,6 @@ config :ueberauth, Ueberauth,
   ]
 ```
 
-You may also need to set up your frontend to use oauth logins. For example, for `akkoma-fe`:
-
-```elixir
-config :pleroma, :frontend_configurations,
-  pleroma_fe: %{
-    loginMethod: "token"
-  }
-```
-
 ## Link parsing
 
 ### :uri_schemes

docs/docs/configuration/hardening.md

@@ -17,16 +17,6 @@ This sets the Akkoma application server to only listen to the localhost interfac
 
 This sets the `secure` flag on Akkoma’s session cookie. This makes sure, that the cookie is only accepted over encrypted HTTPs connections. This implicitly renames the cookie from `pleroma_key` to `__Host-pleroma-key` which enforces some restrictions. (see [cookie prefixes](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#Cookie_prefixes))
 
-### `Pleroma.Upload, :uploader, :base_url`
-
-> Recommended value: *anything on a different domain than the instance endpoint; e.g. https://media.myinstance.net/*
-
-Uploads are user controlled and (unless you’re running a true single-user
-instance) should therefore not be considered trusted. But the domain is used
-as a pivilege boundary e.g. by HTTP content security policy and ActivityPub.
-Having uploads on the same domain enabled several past vulnerabilities
-able to be exploited by malicious users.
-
 ### `:http_security`
 
 > Recommended value: `true`

docs/docs/configuration/howto_mediaproxy.md

@@ -6,16 +6,7 @@ With the `mediaproxy` function you can use nginx to cache this content, so users
 
 ## Activate it
 
-* Edit your nginx config and add the following location to your main server block:
-```
-location /proxy {
-        return 404;
-}
-```
-
-* Set up a subdomain for the proxy with its nginx config on the same machine
-  *(the latter is not strictly required, but for simplicity we’ll assume so)*
-* In this subdomain’s server block add
+* Edit your nginx config and add the following location: 
 ```
 location /proxy {
         proxy_cache akkoma_media_cache;
@@ -35,9 +26,9 @@ config :pleroma, :media_proxy,
       enabled: true,
       proxy_opts: [
             redirect_on_failure: true
-      ],
-      base_url: "https://cache.akkoma.social"
+      ]
+      #base_url: "https://cache.akkoma.social"
 ```
-You **really** should use a subdomain to serve proxied files; while we will fix bugs resulting from this, serving arbitrary remote content on your main domain namespace is a significant attack surface.
+If you want to use a subdomain to serve the files, uncomment `base_url`, change the url and add a comma after `true` in the previous line.
 
 * Restart nginx and Akkoma

docs/docs/configuration/mrf.md

@@ -35,7 +35,6 @@ Once `SimplePolicy` is enabled, you can configure various groups in the `:mrf_si
 * `media_removal`: Servers in this group will have media stripped from incoming messages.
 * `avatar_removal`: Avatars from these servers will be stripped from incoming messages.
 * `banner_removal`: Banner images from these servers will be stripped from incoming messages.
-* `background_removal`: User background images from these servers will be stripped from incoming messages.
 * `report_removal`: Servers in this group will have their reports (flags) rejected.
 * `federated_timeline_removal`: Servers in this group will have their messages unlisted from the public timelines by flipping the `to` and `cc` fields.
 * `reject_deletes`: Deletion requests will be rejected from these servers.
@@ -62,32 +61,6 @@ config :pleroma, :mrf_simple,
 
 The effects of MRF policies can be very drastic. It is important to use this functionality carefully. Always try to talk to an admin before writing an MRF policy concerning their instance.
 
-## Hiding or Obfuscating Policies
-
-You can opt out of publicly displaying all MRF policies or only hide or obfuscate selected domains.
-
-To just hide everything set:
-
-```elixir
-config :pleroma, :mrf,
-  ...
-  transparency: false,
-```
-
-To hide or obfuscate only select entries, use:
-
-```elixir
-config :pleroma, :mrf,
-  ...
-  transparency_obfuscate_domains: ["handholdi.ng", "badword.com"],
-  transparency_exclusions: [{"ghost.club", "even a fragment is too spoopy for humans"}]
-```
-
-## More MRF Policies
-
-See the [documentation cheatsheet](cheatsheet.md)
-for all available MRF policies and their options.
-
 ## Writing your own MRF Policy
 
 As discussed above, the MRF system is a modular system that supports pluggable policies. This means that an admin may write a custom MRF policy in Elixir or any other language that runs on the Erlang VM, by specifying the module name in the `policies` config setting.

docs/docs/configuration/optimisation/optimizing_beam.md

@@ -25,14 +25,11 @@ Tuning the BEAM requires you provide a config file normally called [vm.args](htt
 
 `ExecStart=/usr/bin/elixir --erl '-args_file /opt/akkoma/config/vm.args' -S /usr/bin/mix phx.server`
 
-If using an OTP release, set the `RELEASE_VM_ARGS` environment variable to the path to the vm.args file.
-
 Check your OS documentation to adopt a similar strategy on other platforms.
 
 ### Virtual Machine and/or few CPU cores
 
-Disable the busy-waiting. This should generally be done if you're on a platform that does burst scheduling, like AWS, or if you're running other
-services on the same machine.
+Disable the busy-waiting. This should generally only be done if you're on a platform that does burst scheduling, like AWS.
 
 **vm.args:**
 
@@ -42,8 +39,6 @@ services on the same machine.
 +sbwtdio none
 ```
 
-These settings are enabled by default for OTP releases
-
 ### Dedicated Hardware
 
 Enable more busy waiting, increase the internal maximum limit of BEAM processes and ports. You can use this if you run on dedicated hardware, but it is not necessary.

docs/docs/development/API/akkoma_api.md

@@ -1,146 +0,0 @@
-# Akkoma API
-
-Request authentication (if required) and parameters work the same as for [Pleroma API](pleroma_api.md).
-
-## `/api/v1/akkoma/preferred_frontend/available`
-### Returns the available frontends which can be picked as the preferred choice
-* Method: `GET`
-* Authentication: not required
-* Params: none
-* Response: JSON
-* Example response:
-```json
-["pleroma-fe/stable"]
-```
-
-!!! note
-    There’s also a browser UI under `/akkoma/frontend`
-    for interactively querying and changing this.
-
-## `/api/v1/akkoma/preferred_frontend`
-### Configures the preferred frontend of this session
-* Method: `PUT`
-* Authentication: not required
-* Params:
-    * `frontend_name`: STRING containing one of the available frontends
-* Response: JSON
-* Example response:
-```json
-{"frontend_name":"pleroma-fe/stable"}
-```
-
-!!! note
-    There’s also a browser UI under `/akkoma/frontend`
-    for interactively querying and changing this.
-
-## `/api/v1/akkoma/metrics`
-### Provides metrics for Prometheus to scrape
-* Method: `GET`
-* Authentication: required (admin:metrics)
-* Params: none
-* Response: text
-* Example response:
-```
-# HELP pleroma_remote_users_total
-# TYPE pleroma_remote_users_total gauge
-pleroma_remote_users_total 25
-# HELP pleroma_local_statuses_total
-# TYPE pleroma_local_statuses_total gauge
-pleroma_local_statuses_total 17
-# HELP pleroma_domains_total
-# TYPE pleroma_domains_total gauge
-pleroma_domains_total 4
-# HELP pleroma_local_users_total
-# TYPE pleroma_local_users_total gauge
-pleroma_local_users_total 3
-...
-```
-
-## `/api/v1/akkoma/translation/languages`
-### Returns available source and target languages for automated text translation
-* Method: `GET`
-* Authentication: required
-* Params: none
-* Response: JSON
-* Example response:
-```json
-{
-  "source": [
-    {"code":"LV", "name":"Latvian"},
-    {"code":"ZH", "name":"Chinese (traditional)"},
-    {"code":"EN-US", "name":"English (American)"}
-  ],
-  "target": [
-    {"code":"EN-GB", "name":"English (British)"},
-    {"code":"JP", "name":"Japanese"}
-  ]
-}
-```
-
-## `/api/v1/akkoma/frontend_settings/:frontend_name`
-### Lists all configuration profiles of the selected frontend for the current user
-* Method: `GET`
-* Authentication: required
-* Params: none
-* Response: JSON
-* Example response:
-```json
-[
-  {"name":"default","version":31}
-]
-```
-
-## `/api/v1/akkoma/frontend_settings/:frontend_name/:profile_name`
-### Returns the full selected frontend settings profile of the current user
-* Method: `GET`
-* Authentication: required
-* Params: none
-* Response: JSON
-* Example response:
-```json
-{
-  "version": 31,
-  "settings": {
-    "streaming": true,
-    "conversationDisplay": "tree",
-    ...
-  }
-}
-```
-
-## `/api/v1/akkoma/frontend_settings/:frontend_name/:profile_name`
-### Updates the frontend settings profile
-* Method: `PUT`
-* Authentication: required
-* Params:
-    * `version`: INTEGER
-    * `settings`: JSON object containing the entire new settings
-* Response: JSON
-* Example response:
-```json
-{
-  "streaming": false,
-  "conversationDisplay": "tree",
-  ...
-}
-```
-
-!!! note
-    The `version` field must be increased by exactly one on each update
-
-## `/api/v1/akkoma/frontend_settings/:frontend_name/:profile_name`
-### Drops the specified frontend settings profile
-* Method: `DELETE`
-* Authentication: required
-* Params: none
-* Response: JSON
-* Example response:
-```json
-{"deleted":"ok"}
-```
-
-
-## `/api/v1/timelines/bubble`
-### Returns a timeline for the local and closely related instances
-Works like all other Mastodon-API timeline queries with the documented
-[Akkoma-specific additions and tweaks](./differences_in_mastoapi_responses.md#timelines).

docs/docs/development/API/differences_in_mastoapi_responses.md

@@ -1,6 +1,6 @@
 # Differences in Mastodon API responses from vanilla Mastodon
 
-A Akkoma instance can be identified by "<Mastodon version> (compatible; Akkoma <version>)" present in `version` field in response from `/api/v1/instance`
+A Akkoma instance can be identified by "<Mastodon version> (compatible; Pleroma <version>)" present in `version` field in response from `/api/v1/instance`
 
 ## Flake IDs
 
@@ -8,27 +8,19 @@ Akkoma uses 128-bit ids as opposed to Mastodon's 64 bits. However, just like Mas
 
 ## Timelines
 
-In addition to Mastodon’s timelines, there is also a “bubble timeline” showing
-posts from the local instance and a set of closely related instances as chosen
-by the administrator. It is available under `/api/v1/timelines/bubble`.
-
 Adding the parameter `with_muted=true` to the timeline queries will also return activities by muted (not by blocked!) users.
 
 Adding the parameter `exclude_visibilities` to the timeline queries will exclude the statuses with the given visibilities. The parameter accepts an array of visibility types (`public`, `unlisted`, `private`, `direct`), e.g., `exclude_visibilities[]=direct&exclude_visibilities[]=private`.
 
-Adding the parameter `reply_visibility` to the public, bubble or home timelines queries will filter replies. Possible values: without parameter (default) shows all replies, `following` - replies directed to you or users you follow, `self` - replies directed to you.
+Adding the parameter `reply_visibility` to the public and home timelines queries will filter replies. Possible values: without parameter (default) shows all replies, `following` - replies directed to you or users you follow, `self` - replies directed to you.
 
 Adding the parameter `instance=lain.com` to the public timeline will show only statuses originating from `lain.com` (or any remote instance).
 
-All but the direct timeline accept these parameters:
+Home, public, hashtag & list timelines accept these parameters:
 
 - `only_media`: show only statuses with media attached
-- `remote`: show only remote statuses
-
-Home, public, hashtag & list timelines further accept:
-
 - `local`: show only local statuses
-
+- `remote`: show only remote statuses
 
 ## Statuses
 
@@ -121,12 +113,6 @@ Has these additional fields under the `pleroma` object:
 - `notification_settings`: object, can be absent. See `/api/v1/pleroma/notification_settings` for the parameters/keys returned.
 - `favicon`: nullable URL string, Favicon image of the user's instance
 
-Has these additional fields under the `akkoma` object:
-
-- `instance`: nullable object with metadata about the user’s instance
-- `status_ttl_days`: nullable int, default time after which statuses are deleted
-- `permit_followback`: boolean, whether follows from followed accounts are auto-approved
-
 ### Source
 
 Has these additional fields under the `pleroma` object:

docs/docs/installation/alpine_linux_en.md

@@ -145,13 +145,47 @@ If you want to open your newly installed instance to the world, you should run n
 doas apk add nginx
 ```
 
+* Setup your SSL cert, using your method of choice or certbot. If using certbot, first install it:
+
+```shell
+doas apk add certbot
+```
+
+and then set it up:
+
+```shell
+doas mkdir -p /var/lib/letsencrypt/
+doas certbot certonly --email <your@emailaddress> -d <yourdomain> --standalone
+```
+
+If that doesn’t work, make sure, that nginx is not already running. If it still doesn’t work, try setting up nginx first (change ssl “on” to “off” and try again).
+
 * Copy the example nginx configuration to the nginx folder
 
 ```shell
 doas cp /opt/akkoma/installation/nginx/akkoma.nginx /etc/nginx/conf.d/akkoma.conf
 ```
 
-* Before starting nginx edit the configuration and change it to your needs. You must change change `server_name`. You can use `nano` (install with `apk add nano` if missing).
+* Before starting nginx edit the configuration and change it to your needs. You must change change `server_name` and the paths to the certificates. You can use `nano` (install with `apk add nano` if missing).
+
+```
+server {
+    server_name    your.domain;
+    listen         80;
+    ...
+}
+
+server {
+    server_name your.domain;
+    listen 443 ssl http2;
+    ...
+    ssl_trusted_certificate   /etc/letsencrypt/live/your.domain/chain.pem;
+    ssl_certificate           /etc/letsencrypt/live/your.domain/fullchain.pem;
+    ssl_certificate_key       /etc/letsencrypt/live/your.domain/privkey.pem;
+    ...
+}
+```
+
 * Enable and start nginx:
 
 ```shell
@@ -159,37 +193,10 @@ doas rc-update add nginx
 doas rc-service nginx start
 ```
 
-* Setup your SSL cert, using your method of choice or certbot. If using certbot, first install it:
+If you need to renew the certificate in the future, uncomment the relevant location block in the nginx config and run:
 
 ```shell
-doas apk add certbot certbot-nginx
-```
-
-and then set it up:
-
-```shell
-doas mkdir -p /var/lib/letsencrypt/
-doas certbot --email <your@emailaddress> -d <yourdomain> -d <media_domain> --nginx
-```
-
-If that doesn't work the first time, add `--dry-run` to further attempts to avoid being ratelimited as you identify the issue, and do not remove it until the dry run succeeds. A common source of problems are nginx config syntax errors; this can be checked for by running `nginx -t`.
-
-To automatically renew, set up a cron job like so:
-
-```shell
-# Enable the crond service
-doas rc-update add crond
-doas rc-service crond start
-
-# Test that renewals work
-doas certbot renew --cert-name yourinstance.tld --nginx --dry-run
-
-# Add the renewal task to cron
-echo '#!/bin/sh
-certbot renew --cert-name yourinstance.tld --nginx
-' | doas tee /etc/periodic/daily/renew-akkoma-cert
-doas chmod +x /etc/periodic/daily/renew-akkoma-cert
-
+doas certbot certonly --email <your@emailaddress> -d <yourdomain> --webroot -w /var/lib/letsencrypt/
 ```
 
 #### OpenRC service

docs/docs/installation/arch_linux_en.md

@@ -136,17 +136,16 @@ If you want to open your newly installed instance to the world, you should run n
 sudo pacman -S nginx
 ```
 
-* Copy the example nginx configuration:
+* Create directories for available and enabled sites:
 
 ```shell
-sudo cp /opt/akkoma/installation/nginx/akkoma.nginx /etc/nginx/conf.d/akkoma.conf
+sudo mkdir -p /etc/nginx/sites-{available,enabled}
 ```
 
-* Before starting nginx edit the configuration and change it to your needs (e.g. change servername, change cert paths)
-* Enable and start nginx:
+* Append the following line at the end of the `http` block in `/etc/nginx/nginx.conf`:
 
-```shell
-sudo systemctl enable --now nginx.service
+```Nginx
+include sites-enabled/*;
 ```
 
 * Setup your SSL cert, using your method of choice or certbot. If using certbot, first install it:
@@ -159,18 +158,32 @@ and then set it up:
 
 ```shell
 sudo mkdir -p /var/lib/letsencrypt/
-sudo certbot --email <your@emailaddress> -d <yourdomain> -d <media_domain> --nginx
+sudo certbot certonly --email <your@emailaddress> -d <yourdomain> --standalone
 ```
 
-If that doesn't work the first time, add `--dry-run` to further attempts to avoid being ratelimited as you identify the issue, and do not remove it until the dry run succeeds. A common source of problems are nginx config syntax errors; this can be checked for by running `nginx -t`.
+If that doesn’t work, make sure, that nginx is not already running. If it still doesn’t work, try setting up nginx first (change ssl “on” to “off” and try again).
 
-To make sure renewals work, enable the appropriate systemd timer:
+---
+
+* Copy the example nginx configuration and activate it:
 
 ```shell
-sudo systemctl enable --now certbot-renew.timer
+sudo cp /opt/akkoma/installation/nginx/akkoma.nginx /etc/nginx/sites-available/akkoma.nginx
+sudo ln -s /etc/nginx/sites-available/akkoma.nginx /etc/nginx/sites-enabled/akkoma.nginx
 ```
 
-Certificate renewal should be handled automatically by Certbot from now on.
+* Before starting nginx edit the configuration and change it to your needs (e.g. change servername, change cert paths)
+* Enable and start nginx:
+
+```shell
+sudo systemctl enable --now nginx.service
+```
+
+If you need to renew the certificate in the future, uncomment the relevant location block in the nginx config and run:
+
+```shell
+sudo certbot certonly --email <your@emailaddress> -d <yourdomain> --webroot -w /var/lib/letsencrypt/
+```
 
 #### Other webserver/proxies
 

docs/docs/installation/debian_based_en.md

@@ -155,6 +155,23 @@ If you want to open your newly installed instance to the world, you should run n
 sudo apt install nginx
 ```
 
+* Setup your SSL cert, using your method of choice or certbot. If using certbot, first install it:
+
+```shell
+sudo apt install certbot
+```
+
+and then set it up:
+
+```shell
+sudo mkdir -p /var/lib/letsencrypt/
+sudo certbot certonly --email <your@emailaddress> -d <yourdomain> --standalone
+```
+
+If that doesn’t work, make sure, that nginx is not already running. If it still doesn’t work, try setting up nginx first (change ssl “on” to “off” and try again).
+
+---
+
 * Copy the example nginx configuration and activate it:
 
 ```shell
@@ -169,23 +186,12 @@ sudo ln -s /etc/nginx/sites-available/akkoma.nginx /etc/nginx/sites-enabled/akko
 sudo systemctl enable --now nginx.service
 ```
 
-* Setup your SSL cert, using your method of choice or certbot. If using certbot, first install it:
+If you need to renew the certificate in the future, uncomment the relevant location block in the nginx config and run:
 
 ```shell
-sudo apt install certbot python3-certbot-nginx
+sudo certbot certonly --email <your@emailaddress> -d <yourdomain> --webroot -w /var/lib/letsencrypt/
 ```
 
-and then set it up:
-
-```shell
-sudo mkdir -p /var/lib/letsencrypt/
-sudo certbot --email <your@emailaddress> -d <yourdomain> -d <media_domain> --nginx
-```
-
-If that doesn't work the first time, add `--dry-run` to further attempts to avoid being ratelimited as you identify the issue, and do not remove it until the dry run succeeds. A common source of problems are nginx config syntax errors; this can be checked for by running `nginx -t`.
-
-Certificate renewal should be handled automatically by Certbot from now on.
-
 #### Other webserver/proxies
 
 You can find example configurations for them in `/opt/akkoma/installation/`.

docs/docs/installation/docker_en.md

@@ -125,26 +125,7 @@ cp docker-resources/Caddyfile.example docker-resources/Caddyfile
 
 Then edit the TLD in your caddyfile to the domain you're serving on.
 
-Copy the commented out `caddy` section in `docker-compose.yml` into a new file called `docker-compose.override.yml` like so:
-```yaml
-version: "3.7"
-
-services:
-  proxy:
-    image: caddy:2-alpine
-    restart: unless-stopped
-    links:
-      - akkoma
-    ports: [
-       "443:443",
-       "80:80"
-    ]
-    volumes:
-      - ./docker-resources/Caddyfile:/etc/caddy/Caddyfile
-      - ./caddy-data:/data
-      - ./caddy-config:/config
-```
-
+Uncomment the `caddy` section in the docker compose file,
 then run `docker compose up -d` again.
 
 #### Running a reverse proxy on the host
@@ -174,12 +155,6 @@ git pull
 docker compose restart akkoma db
 ```
 
-### Modifying the Docker services
-If you want to modify the services defined in the docker compose file, you can
-create a new file called `docker-compose.override.yml`. There you can add any
-overrides or additional services without worrying about git conflicts when a
-new release comes out.
-
 #### Further reading
 
 {! installation/further_reading.include !}

docs/docs/installation/fedora_based_en.md

@@ -135,6 +135,23 @@ If you want to open your newly installed instance to the world, you should run n
 sudo dnf install nginx
 ```
 
+* Setup your SSL cert, using your method of choice or certbot. If using certbot, first install it:
+
+```shell
+sudo dnf install certbot
+```
+
+and then set it up:
+
+```shell
+sudo mkdir -p /var/lib/letsencrypt/
+sudo certbot certonly --email <your@emailaddress> -d <yourdomain> --standalone
+```
+
+If that doesn’t work, make sure, that nginx is not already running. If it still doesn’t work, try setting up nginx first (change ssl “on” to “off” and try again).
+
+---
+
 * Copy the example nginx configuration and activate it:
 
 ```shell
@@ -148,23 +165,12 @@ sudo cp /opt/akkoma/installation/nginx/akkoma.nginx /etc/nginx/conf.d/akkoma.con
 sudo systemctl enable --now nginx.service
 ```
 
-* Setup your SSL cert, using your method of choice or certbot. If using certbot, first install it:
+If you need to renew the certificate in the future, uncomment the relevant location block in the nginx config and run:
 
 ```shell
-sudo dnf install certbot python3-certbot-nginx
+sudo certbot certonly --email <your@emailaddress> -d <yourdomain> --webroot -w /var/lib/letsencrypt/
 ```
 
-and then set it up:
-
-```shell
-sudo certbot --email <your@emailaddress> -d <yourdomain> -d <media_domain> --nginx
-```
-
-If that doesn't work the first time, add `--dry-run` to further attempts to avoid being ratelimited as you identify the issue, and do not remove it until the dry run succeeds. A common source of problems are nginx config syntax errors; this can be checked for by running `nginx -t`.
-
-Certificate renewal should be handled automatically by Certbot from now on.
-
-
 #### Other webserver/proxies
 
 You can find example configurations for them in `/opt/akkoma/installation/`.

docs/docs/installation/generic_dependencies.include

@@ -1,8 +1,8 @@
 ## Required dependencies
 
 * PostgreSQL 9.6+
-* Elixir 1.14+ (currently tested up to 1.16)
-* Erlang OTP 25+ (currently tested up to OTP26)
+* Elixir 1.14+
+* Erlang OTP 25+
 * git
 * file / libmagic
 * gcc (clang might also work)

docs/docs/installation/gentoo_en.md

@@ -201,6 +201,25 @@ Assuming you want to open your newly installed federated social network to, well
 include sites-enabled/*;
 ```
 
+* Setup your SSL cert, using your method of choice or certbot. If using certbot, install it if you haven't already:
+
+```shell
+ # emerge --ask app-crypt/certbot app-crypt/certbot-nginx
+```
+
+and then set it up:
+
+```shell
+ # mkdir -p /var/lib/letsencrypt/
+ # certbot certonly --email <your@emailaddress> -d <yourdomain> --standalone
+```
+
+If that doesn't work the first time, add `--dry-run` to further attempts to avoid being ratelimited as you identify the issue, and do not remove it until the dry run succeeds. If that doesn’t work, make sure, that nginx is not already running. If it still doesn’t work, try setting up nginx first (change ssl “on” to “off” and try again). Often the answer to issues with certbot is to use the `--nginx` flag once you have nginx up and running.
+
+If you are using any additional subdomains, such as for a media proxy, you can re-run the same command with the subdomain in question. When it comes time to renew later, you will not need to run multiple times for each domain, one renew will handle it.
+
+---
+
 * Copy the example nginx configuration and activate it:
 
 ```shell
@@ -218,24 +237,9 @@ Pay special attention to the line that begins with `ssl_ecdh_curve`. It is stong
 
 ```shell
  # rc-update add nginx default
- # rc-service nginx start
+ # /etc/init.d/nginx start
 ```
 
-* Setup your SSL cert, using your method of choice or certbot. If using certbot, install it if you haven't already:
-
-```shell
- # emerge --ask app-crypt/certbot app-crypt/certbot-nginx
-```
-
-and then set it up:
-
-```shell
- # mkdir -p /var/lib/letsencrypt/
- # certbot --email <your@emailaddress> -d <yourdomain> -d <media_domain> --nginx
-```
-
-If that doesn't work the first time, add `--dry-run` to further attempts to avoid being ratelimited as you identify the issue, and do not remove it until the dry run succeeds. A common source of problems are nginx config syntax errors; this can be checked for by running `nginx -t`.
-
 If you are using certbot, it is HIGHLY recommend you set up a cron job that renews your certificate, and that you install the suggested `certbot-nginx` plugin. If you don't do these things, you only have yourself to blame when your instance breaks suddenly because you forgot about it.
 
 First, ensure that the command you will be installing into your crontab works.

docs/docs/installation/migrating_to_akkoma.md

@@ -21,33 +21,6 @@ fork of Akkoma - luckily this isn't very hard.
 You'll need to update the backend, then possibly the frontend, depending
 on your setup.
 
-## Backup diverging features
-
-As time goes on Akkoma and Pleroma added or removed different features
-and reorganised the database in a different way. If you want to be able to
-migrate back to Pleroma without losing any affected data, you’ll want to
-make a backup before starting the migration.  
-If you're not interested in migrating back, skip this section
-*(although it might be a good idea to temporarily keep a full DB backup
-just in case something unexpected happens during migration)*
-
-As of 2024-02 you will want to keep a backup of:
-
-- the entire `chats` and `chat_message_references` tables
-
-The following columns are not deleted by a migration to Akkoma, but a migration
-back to Pleroma or future Akkoma upgrades might affect them, so perhaps back them up as well:
-
-- the `birthday` of users and their `show_birthday` setting
-- the `expires_at` key of in the `user_relationships` table
-    *(used by temporary mutes)*
-
-The way cached instance metadata is stored differs, but since those
-will be refetched and updated anyway, there’s no need for a backup.
-
-Best check all newer migrations unique to Akkoma/Pleroma
-to get an up-to-date picture of what needs to be kept.
-
 ## From Source
 
 If you're running the source Akkoma install, you'll need to set the
@@ -61,7 +34,16 @@ git pull -r
 # to run "git merge stable" instead (or develop if you want)
 ```
 
-And compile as usual.
+### WARNING - Migrating from Pleroma Develop
+If you are on pleroma develop, and have updated since 2022-08, you may have issues with database migrations.
+
+Please roll back the given migrations:
+
+```bash
+MIX_ENV=prod mix ecto.rollback --migrations-path priv/repo/optional_migrations/pleroma_develop_rollbacks -n5
+```
+
+Then compile, migrate and restart as usual.
 
 ## From OTP
 
@@ -71,44 +53,15 @@ This will just be setting the update URL - find your flavour from the [mapping o
 export FLAVOUR=[the flavour you found above]
 
 ./bin/pleroma_ctl update --zip-url https://akkoma-updates.s3-website.fr-par.scw.cloud/stable/akkoma-$FLAVOUR.zip
+./bin/pleroma_ctl migrate
 ```
 
-When updating in the future, you can just use
+Then restart. When updating in the future, you canjust use
 
 ```bash
 ./bin/pleroma_ctl update --branch stable
 ```
 
-
-## Database Migrations
-### WARNING - Migrating from Pleroma past 2022-08
-If you are on Pleroma stable >= 2.5.0 or Pleroma develop, and
-have updated since 2022-08, you may have issues with database migrations.
-
-Please first roll back the given migrations:
-
-=== "OTP"
-    ```bash
-    ./bin/pleroma_ctl rollback --migrations-path priv/repo/optional_migrations/pleroma_develop_rollbacks -n5
-    ```
-=== "From Source"
-    ```bash
-    MIX_ENV=prod mix ecto.rollback --migrations-path priv/repo/optional_migrations/pleroma_develop_rollbacks -n5
-    ```
-
-### Applying Akkoma Database Migrations
-
-Just run
-
-=== "OTP"
-    ```bash
-    ./bin/pleroma_ctl migrate
-    ```
-=== "From Source"
-    ```bash
-    MIX_ENV=prod mix ecto.migrate
-    ```
-
 ## Frontend changes
 
 Akkoma comes with a few frontend changes as well as backend ones,
@@ -177,4 +130,3 @@ MIX_ENV=prod mix ecto.rollback --to 20210416051708
 ```
 
 Then switch back to Pleroma for updates (similar to how was done to migrate to Akkoma), and remove the front-ends. The front-ends are installed in the `frontends` folder in the [static directory](../configuration/static_dir.md). Once you are back to Pleroma, you will need to run the database migrations again. See the Pleroma documentation for this.
-After this use your previous backups to restore data from diverging features.

docs/docs/installation/optional/media_graphics_packages.md

@@ -14,7 +14,7 @@ Note: the packages are not required with the current default settings of Akkoma.
 `ImageMagick` is a set of tools to create, edit, compose, or convert bitmap images.
 
 It is required for the following Akkoma features:
-  * `Pleroma.Upload.Filters.Mogrify`, `Pleroma.Upload.Filters.Mogrifun` upload filters (related config: `Pleroma.Upload/filters` in `config/config.exs`)
+  * `Pleroma.Upload.Filters.Mogrify`, `Pleroma.Upload.Filters.Mogrifun` upload filters (related config: `Plaroma.Upload/filters` in `config/config.exs`)
   * Media preview proxy for still images (related config: `media_preview_proxy/enabled` in `config/config.exs`)
   
 ## `ffmpeg`
@@ -29,5 +29,4 @@ It is required for the following Akkoma features:
 `exiftool` is media files metadata reader/writer.
 
 It is required for the following Akkoma features:
-  * `Pleroma.Upload.Filters.Exiftool.StripMetadata` upload filter (related config: `Pleroma.Upload/filters` in `config/config.exs`)
-  * `Pleroma.Upload.Filters.Exiftool.ReadDescription` upload filter (related config: `Pleroma.Upload/filters` in `config/config.exs`)
+  * `Pleroma.Upload.Filters.Exiftool` upload filter (related config: `Plaroma.Upload/filters` in `config/config.exs`)

docs/docs/installation/otp_en.md

@@ -9,7 +9,7 @@ This guide covers a installation using an OTP release. To install Akkoma from so
 * For installing OTP releases on RedHat-based distros like Fedora and Centos Stream, please follow [this guide](./otp_redhat_en.md) instead.
 * A (sub)domain pointed to the machine
 
-You will be running commands as root. If you aren't root already, please elevate your priviledges by executing `sudo -i`/`su`.
+You will be running commands as root. If you aren't root already, please elevate your priviledges by executing `sudo su`/`su`.
 
 While in theory OTP releases are possbile to install on any compatible machine, for the sake of simplicity this guide focuses only on Debian/Ubuntu and Alpine.
 
@@ -176,6 +176,11 @@ su akkoma -s $SHELL -lc "./bin/pleroma stop"
 
 ### Setting up nginx and getting Let's Encrypt SSL certificaties
 
+#### Get a Let's Encrypt certificate
+```sh
+certbot certonly --standalone --preferred-challenges http -d yourinstance.tld
+```
+
 #### Copy Akkoma nginx configuration to the nginx folder
 
 The location of nginx configs is dependent on the distro
@@ -204,14 +209,6 @@ $EDITOR path-to-nginx-config
 # Verify that the config is valid
 nginx -t
 ```
-
-#### Get a Let's Encrypt certificate
-```sh
-certbot --nginx -d yourinstance.tld -d media.yourinstance.tld
-```
-
-If that doesn't work the first time, add `--dry-run` to further attempts to avoid being ratelimited as you identify the issue, and do not remove it until the dry run succeeds. A common source of problems are nginx config syntax errors; this can be checked for by running `nginx -t`.
-
 #### Start nginx
 
 === "Alpine"
@@ -255,19 +252,32 @@ If everything worked, you should see Akkoma-FE when visiting your domain. If tha
 ## Post installation
 
 ### Setting up auto-renew of the Let's Encrypt certificate
+```sh
+# Create the directory for webroot challenges
+mkdir -p /var/lib/letsencrypt
+
+# Uncomment the webroot method
+$EDITOR path-to-nginx-config
+
+# Verify that the config is valid
+nginx -t
+```
 
 === "Alpine"
     ```
+    # Restart nginx
+    rc-service nginx restart
+
     # Start the cron daemon and make it start on boot
     rc-service crond start
     rc-update add crond
 
     # Ensure the webroot menthod and post hook is working
-    certbot renew --cert-name yourinstance.tld --nginx --dry-run
+    certbot renew --cert-name yourinstance.tld --webroot -w /var/lib/letsencrypt/ --dry-run --post-hook 'rc-service nginx reload'
 
     # Add it to the daily cron
     echo '#!/bin/sh
-    certbot renew --cert-name yourinstance.tld --nginx
+    certbot renew --cert-name yourinstance.tld --webroot -w /var/lib/letsencrypt/ --post-hook "rc-service nginx reload"
     ' > /etc/periodic/daily/renew-akkoma-cert
     chmod +x /etc/periodic/daily/renew-akkoma-cert
 
@@ -276,7 +286,22 @@ If everything worked, you should see Akkoma-FE when visiting your domain. If tha
     ```
 
 === "Debian/Ubuntu"
-    This should be automatically enabled with the `certbot-renew.timer` systemd unit.
+    ```
+    # Restart nginx
+    systemctl restart nginx
+
+    # Ensure the webroot menthod and post hook is working
+    certbot renew --cert-name yourinstance.tld --webroot -w /var/lib/letsencrypt/ --dry-run --post-hook 'systemctl reload nginx'
+
+    # Add it to the daily cron
+    echo '#!/bin/sh
+    certbot renew --cert-name yourinstance.tld --webroot -w /var/lib/letsencrypt/ --post-hook "systemctl reload nginx"
+    ' > /etc/cron.daily/renew-akkoma-cert
+    chmod +x /etc/cron.daily/renew-akkoma-cert
+
+    # If everything worked the output should contain /etc/cron.daily/renew-akkoma-cert
+    run-parts --test /etc/cron.daily
+    ```
 
 ## Create your first user and set as admin
 ```sh

docs/docs/installation/otp_redhat_en.md

@@ -82,7 +82,6 @@ Other than things bundled in the OTP release Akkoma depends on:
 * PostgreSQL (also utilizes extensions in postgresql-contrib)
 * nginx (could be swapped with another reverse proxy but this guide covers only it)
 * certbot (for Let's Encrypt certificates, could be swapped with another ACME client, but this guide covers only it)
-    * If you are using certbot, also install the `python3-certbot-nginx` package for the nginx plugin
 * libmagic/file
 
 First, update your system, if not already done:
@@ -170,6 +169,12 @@ sudo -Hu akkoma ./bin/pleroma stop
 
 ### Setting up nginx and getting Let's Encrypt SSL certificaties
 
+#### Get a Let's Encrypt certificate
+
+```shell
+certbot certonly --standalone --preferred-challenges http -d yourinstance.tld
+```
+
 #### Copy Akkoma nginx configuration to the nginx folder
 
 ```shell
@@ -190,15 +195,8 @@ sudo nginx -t
 sudo systemctl start nginx
 ```
 
-#### Get a Let's Encrypt certificate
+At this point if you open your (sub)domain in a browser you should see a 502 error, that's because Akkoma is not started yet.
 
-```shell
-sudo certbot --email <your@emailaddress> -d <yourdomain> -d <media_domain> --nginx
-```
-
-If that doesn't work the first time, add `--dry-run` to further attempts to avoid being ratelimited as you identify the issue, and do not remove it until the dry run succeeds. A common source of problems are nginx config syntax errors; this can be checked for by running `nginx -t`.
-
-If you're successful with obtaining the certificates, opening your (sub)domain in a browser will result in a 502 error, since Akkoma hasn't been started yet.
 
 ### Setting up a system service
 
@@ -241,11 +239,19 @@ sudo nginx -t
 # Restart nginx
 sudo systemctl restart nginx
 
-# Test that renewals work properly
-sudo certbot renew --cert-name yourinstance.tld --nginx --dry-run
+# Ensure the webroot menthod and post hook is working
+sudo certbot renew --cert-name yourinstance.tld --webroot -w /var/lib/letsencrypt/ --dry-run --post-hook 'systemctl reload nginx'
+
+# Add it to the daily cron
+echo '#!/bin/sh
+certbot renew --cert-name yourinstance.tld --webroot -w /var/lib/letsencrypt/ --post-hook "systemctl reload nginx"
+' > /etc/cron.daily/renew-akkoma-cert
+sudo chmod +x /etc/cron.daily/renew-akkoma-cert
+
+# If everything worked the output should contain /etc/cron.daily/renew-akkoma-cert
+sudo run-parts --test /etc/cron.daily
 ```
 
-Assuming the commands were run successfully, certbot should be able to renew your certificates automatically via the `certbot-renew.timer` systemd unit.
 
 ## Create your first user and set as admin
 ```shell

elixir_buildpack.config

@@ -0,0 +1,2 @@
+elixir_version=1.14.3
+erlang_version=25.3

installation/nginx/akkoma.nginx

@@ -1,9 +1,12 @@
 # default nginx site config for Akkoma
 #
-# See the documentation at docs.akkoma.dev for your particular distro/OS for
-# installation instructions.
+# Simple installation instructions:
+# 1. Install your TLS certificate, possibly using Let's Encrypt.
+# 2. Replace 'example.tld' with your instance's domain wherever it appears.
+# 3. Copy this file to /etc/nginx/sites-available/ and then add a symlink to it
+#    in /etc/nginx/sites-enabled/ and run 'nginx -s reload' or restart nginx.
 
-proxy_cache_path /tmp/akkoma-media-cache levels=1:2 keys_zone=akkoma_media_cache:10m max_size=1g
+proxy_cache_path /tmp/akkoma-media-cache levels=1:2 keys_zone=akkoma_media_cache:10m max_size=10g
                  inactive=720m use_temp_path=off;
 
 # this is explicitly IPv4 since Pleroma.Web.Endpoint binds on IPv4 only
@@ -12,19 +15,25 @@ upstream phoenix {
     server 127.0.0.1:4000 max_fails=5 fail_timeout=60s;
 }
 
-# If you are setting up TLS certificates without certbot, uncomment the
-# following to enable HTTP -> HTTPS redirects. Certbot users don't need to do
-# this as it will automatically do this for you.
-# server {
-#     server_name    example.tld media.example.tld;
-#
-#     listen         80;
-#     listen         [::]:80;
-#
-#     location / {
-#         return         301 https://$server_name$request_uri;
-#     }
-# }
+server {
+    server_name    example.tld;
+
+    listen         80;
+    listen         [::]:80;
+
+    # Uncomment this if you need to use the 'webroot' method with certbot. Make sure
+    # that the directory exists and that it is accessible by the webserver. If you followed
+    # the guide, you already ran 'mkdir -p /var/lib/letsencrypt' to create the folder.
+    # You may need to load this file with the ssl server block commented out, run certbot
+    # to get the certificate, and then uncomment it.
+    #
+    # location ~ /\.well-known/acme-challenge {
+    #     root /var/lib/letsencrypt/;
+    # }
+    location / {
+      return         301 https://$server_name$request_uri;
+    }
+}
 
 # Enable SSL session caching for improved performance
 ssl_session_cache shared:ssl_session_cache:10m;
@@ -32,29 +41,22 @@ ssl_session_cache shared:ssl_session_cache:10m;
 server {
     server_name example.tld;
 
-    # Once certbot is set up, this will automatically be updated to listen to
-    # port 443 with TLS alongside a redirect from plaintext HTTP.
-    listen 80;
-    listen [::]:80;
+    listen 443 ssl http2;
+    listen [::]:443 ssl http2;
+    ssl_session_timeout 1d;
+    ssl_session_cache shared:MozSSL:10m;  # about 40000 sessions
+    ssl_session_tickets off;
 
-    # If you are not using Certbot, comment out the above and uncomment/edit the following
-#     listen 443 ssl http2;
-#     listen [::]:443 ssl http2;
-#     ssl_session_timeout 1d;
-#     ssl_session_cache shared:MozSSL:10m;  # about 40000 sessions
-#     ssl_session_tickets off;
-#
-#     ssl_trusted_certificate   /etc/letsencrypt/live/example.tld/chain.pem;
-#     ssl_certificate           /etc/letsencrypt/live/example.tld/fullchain.pem;
-#     ssl_certificate_key       /etc/letsencrypt/live/example.tld/privkey.pem;
-#
-#     ssl_protocols TLSv1.2 TLSv1.3;
-#     ssl_ciphers "ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:!aNULL:!eNULL:!EXPORT:!DES:!MD5:!PSK:!RC4";
-#     ssl_prefer_server_ciphers off;
-#     ssl_ecdh_curve X25519:prime256v1:secp384r1:secp521r1;
-#     ssl_stapling on;
-#     ssl_stapling_verify on;
+    ssl_trusted_certificate   /etc/letsencrypt/live/example.tld/chain.pem;
+    ssl_certificate           /etc/letsencrypt/live/example.tld/fullchain.pem;
+    ssl_certificate_key       /etc/letsencrypt/live/example.tld/privkey.pem;
 
+    ssl_protocols TLSv1.2 TLSv1.3;
+    ssl_ciphers "ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:!aNULL:!eNULL:!EXPORT:!DES:!MD5:!PSK:!RC4";
+    ssl_prefer_server_ciphers off;
+    ssl_ecdh_curve X25519:prime256v1:secp384r1:secp521r1;
+    ssl_stapling on;
+    ssl_stapling_verify on;
 
     gzip_vary on;
     gzip_proxied any;
@@ -73,43 +75,9 @@ server {
     proxy_set_header Host $http_host;
     proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
 
-    location ~ ^/(media|proxy) {
-        return 404;
-    }
-
     location / {
         proxy_pass http://phoenix;
     }
-}
-
-# Upload and MediaProxy Subdomain
-# (see main domain setup for more details)
-server {
-    server_name media.example.tld;
-
-    # Same as above, will be updated to HTTPS once certbot is set up.
-    listen 80;
-    listen [::]:80;
-
-    # If you are not using certbot, comment the above and copy all the ssl
-    # stuff from above into here.
-
-    gzip_vary on;
-    gzip_proxied any;
-    gzip_comp_level 6;
-    gzip_buffers 16 8k;
-    gzip_http_version 1.1;
-    gzip_types text/plain text/css application/json application/javascript text/xml application/xml application/xml+rss text/javascript application/activity+json application/atom+xml;
-
-    # the nginx default is 1m, not enough for large media uploads
-    client_max_body_size 16m;
-    ignore_invalid_headers off;
-
-    proxy_http_version 1.1;
-    proxy_set_header Upgrade $http_upgrade;
-    proxy_set_header Connection "upgrade";
-    proxy_set_header Host $http_host;
-    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
 
     location ~ ^/(media|proxy) {
         proxy_cache        akkoma_media_cache;
@@ -123,8 +91,4 @@ server {
         chunked_transfer_encoding on;
         proxy_pass         http://phoenix;
     }
-
-    location / {
-        return 404;
-    }
 }

installation/quadlet/akkoma-postgresql.container

@@ -0,0 +1,23 @@
+# Put me at either:
+# /usr/share/containers/systemd/akkoma-postgresql.container
+# /etc/containers/systemd/akkoma-postgresql.container
+# $HOME/.config/containers/systemd/akkoma-postgresql.container (for rootless podman!)
+
+[Unit]
+Description=Akkoma's postgres database
+After=local-fs.target
+
+[Container]
+Image=docker.io/postgres:14
+PublishPort=4000
+Volume=/opt/akkoma/pgdata:/var/lib/postgresql/data:Z
+AutoUpdate=registry
+Environment=POSTGRES_DB=akkoma
+Environment=POSTGRES_USER=akkoma
+Environment=POSTGRES_PASSWORD=akkoma
+ContainerName=db
+Network=systemd-akkoma
+
+[Install]
+# Start by default on boot
+WantedBy=multi-user.target default.target

installation/quadlet/akkoma.container

@@ -0,0 +1,26 @@
+# Put me at either:
+# /usr/share/containers/systemd/akkoma.container
+# /etc/containers/systemd/akkoma.container
+# $HOME/.config/containers/systemd/akkoma.container (Recommended, for rootless podman!)
+
+[Unit]
+Description=The main Akkoma container
+After=local-fs.target akkoma-postgresql.container
+
+[Container]
+Image=docker.io/akkoma/akkoma:test
+ExposeHostPort=4000
+# Comment the next line if you intend to use containerized caddy!
+PublishPort=4000:4000
+Volume=/opt/akkoma/uploads:/opt/akkoma/uploads:Z
+Volume=/opt/akkoma/instance:/opt/akkoma/instance:Z
+Volume=/opt/akkoma/config.exs:/opt/akkoma/config/config.exs:Z
+#AutoUpdate=registry
+NoNewPrivileges=true
+Environment=AKKOMA_CONFIG_PATH=/opt/akkoma/config/config.exs
+ContainerName=akkoma
+Network=systemd-akkoma
+
+[Install]
+# Start by default on boot
+WantedBy=multi-user.target default.target

installation/quadlet/akkoma.network

@@ -0,0 +1,2 @@
+[Network]
+Label=app=akkoma

installation/quadlet/caddy.container

@@ -0,0 +1,27 @@
+# Put me at either:
+# /usr/share/containers/systemd/caddy.container
+# /etc/containers/systemd/caddy.container
+# !!!! PLEASE NOTE !!!!
+# Caddy cannot run containerised in rootless podman, since it wants access
+# to privileged ports 80 and 443!
+# run caddy on your host if you're rootless!
+
+[Unit]
+Description=Akkoma's postgres database
+After=local-fs.target
+
+[Container]
+Image=docker.io/caddy:2-alpine
+PublishPort=80:80
+PublishPort=443:443
+ExposeHostPort=80
+ExposeHostPort=443
+Volume=/opt/akkoma/Caddyfile:/etc/caddy/Caddyfile
+Volume=/opt/akkoma/caddy-data:/data
+Volume=/opt/akkoma/caddy-config:/config
+AutoUpdate=registry
+Network=systemd-akkoma
+
+[Install]
+# Start by default on boot
+WantedBy=multi-user.target default.target

lib/mix/tasks/pleroma/instance.ex

@@ -20,7 +20,6 @@ defmodule Mix.Tasks.Pleroma.Instance do
           output: :string,
           output_psql: :string,
           domain: :string,
-          media_url: :string,
           instance_name: :string,
           admin_email: :string,
           notify_email: :string,
@@ -35,9 +34,9 @@ defmodule Mix.Tasks.Pleroma.Instance do
           static_dir: :string,
           listen_ip: :string,
           listen_port: :string,
-          strip_uploads_metadata: :string,
-          read_uploads_description: :string,
-          anonymize_uploads: :string
+          strip_uploads: :string,
+          anonymize_uploads: :string,
+          dedupe_uploads: :string
         ],
         aliases: [
           o: :output,
@@ -65,14 +64,6 @@ defmodule Mix.Tasks.Pleroma.Instance do
           ":"
         ) ++ [443]
 
-      media_url =
-        get_option(
-          options,
-          :media_url,
-          "What base url will uploads use? (e.g https://media.example.com/media)\n" <>
-            "  Generally this should NOT use the same domain as the instance       "
-        )
-
       name =
         get_option(
           options,
@@ -170,38 +161,21 @@ defmodule Mix.Tasks.Pleroma.Instance do
         )
         |> Path.expand()
 
-      {strip_uploads_metadata_message, strip_uploads_metadata_default} =
+      {strip_uploads_message, strip_uploads_default} =
         if Pleroma.Utils.command_available?("exiftool") do
-          {"Do you want to strip metadata from uploaded images? This requires exiftool, it was detected as installed. (y/n)",
+          {"Do you want to strip location (GPS) data from uploaded images? This requires exiftool, it was detected as installed. (y/n)",
            "y"}
         else
-          {"Do you want to strip metadata from uploaded images? This requires exiftool, it was detected as not installed, please install it if you answer yes. (y/n)",
+          {"Do you want to strip location (GPS) data from uploaded images? This requires exiftool, it was detected as not installed, please install it if you answer yes. (y/n)",
            "n"}
         end
 
-      strip_uploads_metadata =
+      strip_uploads =
         get_option(
           options,
-          :strip_uploads_metadata,
-          strip_uploads_metadata_message,
-          strip_uploads_metadata_default
-        ) === "y"
-
-      {read_uploads_description_message, read_uploads_description_default} =
-        if Pleroma.Utils.command_available?("exiftool") do
-          {"Do you want to read data from uploaded files so clients can use it to prefill fields like image description? This requires exiftool, it was detected as installed. (y/n)",
-           "y"}
-        else
-          {"Do you want to read data from uploaded files so clients can use it to prefill fields like image description? This requires exiftool, it was detected as not installed, please install it if you answer yes. (y/n)",
-           "n"}
-        end
-
-      read_uploads_description =
-        get_option(
-          options,
-          :read_uploads_description,
-          read_uploads_description_message,
-          read_uploads_description_default
+          :strip_uploads,
+          strip_uploads_message,
+          strip_uploads_default
         ) === "y"
 
       anonymize_uploads =
@@ -212,6 +186,14 @@ defmodule Mix.Tasks.Pleroma.Instance do
           "n"
         ) === "y"
 
+      dedupe_uploads =
+        get_option(
+          options,
+          :dedupe_uploads,
+          "Do you want to deduplicate uploaded files? (y/n)",
+          "n"
+        ) === "y"
+
       Config.put([:instance, :static_dir], static_dir)
 
       secret = :crypto.strong_rand_bytes(64) |> Base.encode64() |> binary_part(0, 64)
@@ -225,7 +207,6 @@ defmodule Mix.Tasks.Pleroma.Instance do
         EEx.eval_file(
           template_dir <> "/sample_config.eex",
           domain: domain,
-          media_url: media_url,
           port: port,
           email: email,
           notify_email: notify_email,
@@ -248,9 +229,9 @@ defmodule Mix.Tasks.Pleroma.Instance do
           listen_port: listen_port,
           upload_filters:
             upload_filters(%{
-              strip_metadata: strip_uploads_metadata,
-              read_description: read_uploads_description,
-              anonymize: anonymize_uploads
+              strip: strip_uploads,
+              anonymize: anonymize_uploads,
+              dedupe: dedupe_uploads
             })
         )
 
@@ -324,20 +305,11 @@ defmodule Mix.Tasks.Pleroma.Instance do
   end
 
   defp upload_filters(filters) when is_map(filters) do
-    enabled_filters = []
-
     enabled_filters =
-      if filters.read_description do
-        enabled_filters ++ [Pleroma.Upload.Filter.Exiftool.ReadDescription]
+      if filters.strip do
+        [Pleroma.Upload.Filter.Exiftool]
       else
-        enabled_filters
-      end
-
-    enabled_filters =
-      if filters.strip_metadata do
-        enabled_filters ++ [Pleroma.Upload.Filter.Exiftool.StripMetadata]
-      else
-        enabled_filters
+        []
       end
 
     enabled_filters =
@@ -347,6 +319,13 @@ defmodule Mix.Tasks.Pleroma.Instance do
         enabled_filters
       end
 
+    enabled_filters =
+      if filters.dedupe do
+        enabled_filters ++ [Pleroma.Upload.Filter.Dedupe]
+      else
+        enabled_filters
+      end
+
     enabled_filters
   end
 end

lib/mix/tasks/pleroma/security.ex

@@ -1,330 +0,0 @@
-# Akkoma: Magically expressive social media
-# Copyright © 2024 Akkoma Authors <https://akkoma.dev/>
-# SPDX-License-Identifier: AGPL-3.0-only
-
-defmodule Mix.Tasks.Pleroma.Security do
-  use Mix.Task
-  import Ecto.Query
-  import Mix.Pleroma
-
-  alias Pleroma.Config
-
-  require Logger
-
-  @shortdoc """
-  Security-related tasks, like e.g. checking for signs past exploits were abused.
-  """
-
-  # Constants etc
-  defp local_id_prefix(), do: Pleroma.Web.Endpoint.url() <> "/"
-
-  defp local_id_pattern(), do: local_id_prefix() <> "%"
-
-  @activity_exts ["activity+json", "activity%2Bjson"]
-
-  defp activity_ext_url_patterns() do
-    for e <- @activity_exts do
-      for suf <- ["", "?%"] do
-        # Escape literal % for use in SQL patterns
-        ee = String.replace(e, "%", "\\%")
-        "%.#{ee}#{suf}"
-      end
-    end
-    |> List.flatten()
-  end
-
-  # Search for malicious uploads exploiting the lack of Content-Type sanitisation from before 2024-03
-  def run(["spoof-uploaded"]) do
-    Logger.put_process_level(self(), :notice)
-    start_pleroma()
-
-    IO.puts("""
-    +------------------------+
-    |  SPOOF SEARCH UPLOADS  |
-    +------------------------+
-    Checking if any uploads are using privileged types.
-    NOTE if attachment deletion is enabled, payloads used
-         in the past may no longer exist.
-    """)
-
-    do_spoof_uploaded()
-  end
-
-  # Fuzzy search for potentially counterfeit activities in the database resulting from the same exploit
-  def run(["spoof-inserted"]) do
-    Logger.put_process_level(self(), :notice)
-    start_pleroma()
-
-    IO.puts("""
-    +----------------------+
-    |  SPOOF SEARCH NOTES  |
-    +----------------------+
-    Starting fuzzy search for counterfeit activities.
-    NOTE this can not guarantee detecting all counterfeits
-         and may yield a small percentage of false positives.
-    """)
-
-    do_spoof_inserted()
-  end
-
-  # +-----------------------------+
-  # | S P O O F - U P L O A D E D |
-  # +-----------------------------+
-  defp do_spoof_uploaded() do
-    files =
-      case Config.get!([Pleroma.Upload, :uploader]) do
-        Pleroma.Uploaders.Local ->
-          uploads_search_spoofs_local_dir(Config.get!([Pleroma.Uploaders.Local, :uploads]))
-
-        _ ->
-          IO.puts("""
-          NOTE:
-            Not using local uploader; thus not affected by this exploit.
-            It's impossible to check for files, but in case local uploader was used before
-            or to check if anyone futilely attempted a spoof, notes will still be scanned.
-          """)
-
-          []
-      end
-
-    emoji = uploads_search_spoofs_local_dir(Config.get!([:instance, :static_dir]))
-
-    post_attachs = uploads_search_spoofs_notes()
-
-    not_orphaned_urls =
-      post_attachs
-      |> Enum.map(fn {_u, _a, url} -> url end)
-      |> MapSet.new()
-
-    orphaned_attachs = upload_search_orphaned_attachments(not_orphaned_urls)
-
-    IO.puts("\nSearch concluded; here are the results:")
-    pretty_print_list_with_title(emoji, "Emoji")
-    pretty_print_list_with_title(files, "Uploaded Files")
-    pretty_print_list_with_title(post_attachs, "(Not Deleted) Post Attachments")
-    pretty_print_list_with_title(orphaned_attachs, "Orphaned Uploads")
-
-    IO.puts("""
-    In total found
-      #{length(emoji)} emoji
-      #{length(files)} uploads
-      #{length(post_attachs)} not deleted posts
-      #{length(orphaned_attachs)} orphaned attachments
-    """)
-  end
-
-  defp uploads_search_spoofs_local_dir(dir) do
-    local_dir = String.replace_suffix(dir, "/", "")
-
-    IO.puts("Searching for suspicious files in #{local_dir}...")
-
-    glob_ext = "{" <> Enum.join(@activity_exts, ",") <> "}"
-
-    Path.wildcard(local_dir <> "/**/*." <> glob_ext, match_dot: true)
-    |> Enum.map(fn path ->
-      String.replace_prefix(path, local_dir <> "/", "")
-    end)
-    |> Enum.sort()
-  end
-
-  defp uploads_search_spoofs_notes() do
-    IO.puts("Now querying DB for posts with spoofing attachments. This might take a while...")
-
-    patterns = [local_id_pattern() | activity_ext_url_patterns()]
-
-    # if jsonb_array_elemsts in FROM can be used with normal Ecto functions, idk how
-    """
-    SELECT DISTINCT a.data->>'actor', a.id, url->>'href'
-    FROM public.objects AS o JOIN public.activities AS a
-         ON o.data->>'id' = a.data->>'object',
-       jsonb_array_elements(o.data->'attachment') AS attachs,
-       jsonb_array_elements(attachs->'url') AS url
-    WHERE o.data->>'type' = 'Note' AND
-          o.data->>'id' LIKE $1::text AND (
-            url->>'href' LIKE $2::text OR
-            url->>'href' LIKE $3::text OR
-            url->>'href' LIKE $4::text OR
-            url->>'href' LIKE $5::text
-          )
-    ORDER BY a.data->>'actor', a.id, url->>'href';
-    """
-    |> Pleroma.Repo.query!(patterns, timeout: :infinity)
-    |> map_raw_id_apid_tuple()
-  end
-
-  defp upload_search_orphaned_attachments(not_orphaned_urls) do
-    IO.puts("""
-    Now querying DB for orphaned spoofing attachment (i.e. their post was deleted,
-    but if :cleanup_attachments was not enabled traces remain in the database)
-    This might take a bit...
-    """)
-
-    patterns = activity_ext_url_patterns()
-
-    """
-    SELECT DISTINCT attach.id, url->>'href'
-    FROM public.objects AS attach,
-         jsonb_array_elements(attach.data->'url') AS url
-    WHERE (attach.data->>'type' = 'Image' OR
-           attach.data->>'type' = 'Document')
-          AND (
-            url->>'href' LIKE $1::text OR
-            url->>'href' LIKE $2::text OR
-            url->>'href' LIKE $3::text OR
-            url->>'href' LIKE $4::text
-          )
-    ORDER BY attach.id, url->>'href';
-    """
-    |> Pleroma.Repo.query!(patterns, timeout: :infinity)
-    |> then(fn res -> Enum.map(res.rows, fn [id, url] -> {id, url} end) end)
-    |> Enum.filter(fn {_, url} -> !(url in not_orphaned_urls) end)
-  end
-
-  # +-----------------------------+
-  # | S P O O F - I N S E R T E D |
-  # +-----------------------------+
-  defp do_spoof_inserted() do
-    IO.puts("""
-    Searching for local posts whose Create activity has no ActivityPub id...
-      This is a pretty good indicator, but only for spoofs of local actors
-      and only if the spoofing happened after around late 2021.
-    """)
-
-    idless_create =
-      search_local_notes_without_create_id()
-      |> Enum.sort()
-
-    IO.puts("Done.\n")
-
-    IO.puts("""
-    Now trying to weed out other poorly hidden spoofs.
-    This can't detect all and may have some false positives.
-    """)
-
-    likely_spoofed_posts_set = MapSet.new(idless_create)
-
-    sus_pattern_posts =
-      search_sus_notes_by_id_patterns()
-      |> Enum.filter(fn r -> !(r in likely_spoofed_posts_set) end)
-
-    IO.puts("Done.\n")
-
-    IO.puts("""
-    Finally, searching for spoofed, local user accounts.
-    (It's impossible to detect spoofed remote users)
-    """)
-
-    spoofed_users = search_bogus_local_users()
-
-    pretty_print_list_with_title(sus_pattern_posts, "Maybe Spoofed Posts")
-    pretty_print_list_with_title(idless_create, "Likely Spoofed Posts")
-    pretty_print_list_with_title(spoofed_users, "Spoofed local user accounts")
-
-    IO.puts("""
-    In total found:
-      #{length(spoofed_users)} bogus users
-      #{length(idless_create)} likely spoofed posts
-      #{length(sus_pattern_posts)} maybe spoofed posts
-    """)
-  end
-
-  defp search_local_notes_without_create_id() do
-    Pleroma.Object
-    |> where([o], fragment("?->>'id' LIKE ?", o.data, ^local_id_pattern()))
-    |> join(:inner, [o], a in Pleroma.Activity,
-      on: fragment("?->>'object' = ?->>'id'", a.data, o.data)
-    )
-    |> where([o, a], fragment("NOT (? \\? 'id') OR ?->>'id' IS NULL", a.data, a.data))
-    |> select([o, a], {a.id, fragment("?->>'id'", o.data)})
-    |> order_by([o, a], a.id)
-    |> Pleroma.Repo.all(timeout: :infinity)
-  end
-
-  defp search_sus_notes_by_id_patterns() do
-    [ep1, ep2, ep3, ep4] = activity_ext_url_patterns()
-
-    Pleroma.Object
-    |> where(
-      [o],
-      # for local objects we know exactly how a genuine id looks like
-      # (though a thorough attacker can emulate this)
-      # for remote posts, use some best-effort patterns
-      fragment(
-        """
-         (?->>'id' LIKE ? AND ?->>'id' NOT SIMILAR TO
-          ? || 'objects/[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}')
-        """,
-        o.data,
-        ^local_id_pattern(),
-        o.data,
-        ^local_id_prefix()
-      ) or
-        fragment("?->>'id' LIKE ?", o.data, "%/emoji/%") or
-        fragment("?->>'id' LIKE ?", o.data, "%/media/%") or
-        fragment("?->>'id' LIKE ?", o.data, "%/proxy/%") or
-        fragment("?->>'id' LIKE ?", o.data, ^ep1) or
-        fragment("?->>'id' LIKE ?", o.data, ^ep2) or
-        fragment("?->>'id' LIKE ?", o.data, ^ep3) or
-        fragment("?->>'id' LIKE ?", o.data, ^ep4)
-    )
-    |> join(:inner, [o], a in Pleroma.Activity,
-      on: fragment("?->>'object' = ?->>'id'", a.data, o.data)
-    )
-    |> select([o, a], {a.id, fragment("?->>'id'", o.data)})
-    |> order_by([o, a], a.id)
-    |> Pleroma.Repo.all(timeout: :infinity)
-  end
-
-  defp search_bogus_local_users() do
-    Pleroma.User.Query.build(%{})
-    |> where([u], u.local == false and like(u.ap_id, ^local_id_pattern()))
-    |> order_by([u], u.ap_id)
-    |> select([u], u.ap_id)
-    |> Pleroma.Repo.all(timeout: :infinity)
-  end
-
-  # +-----------------------------------+
-  # | module-specific utility functions |
-  # +-----------------------------------+
-  defp pretty_print_list_with_title(list, title) do
-    title_len = String.length(title)
-    title_underline = String.duplicate("=", title_len)
-    IO.puts(title)
-    IO.puts(title_underline)
-    pretty_print_list(list)
-  end
-
-  defp pretty_print_list([]), do: IO.puts("")
-
-  defp pretty_print_list([{a, o} | rest])
-       when (is_binary(a) or is_number(a)) and is_binary(o) do
-    IO.puts("  {#{a}, #{o}}")
-    pretty_print_list(rest)
-  end
-
-  defp pretty_print_list([{u, a, o} | rest])
-       when is_binary(a) and is_binary(u) and is_binary(o) do
-    IO.puts("  {#{u}, #{a}, #{o}}")
-    pretty_print_list(rest)
-  end
-
-  defp pretty_print_list([e | rest]) when is_binary(e) do
-    IO.puts("  #{e}")
-    pretty_print_list(rest)
-  end
-
-  defp pretty_print_list([e | rest]), do: pretty_print_list([inspect(e) | rest])
-
-  defp map_raw_id_apid_tuple(res) do
-    user_prefix = local_id_prefix() <> "users/"
-
-    Enum.map(res.rows, fn
-      [uid, aid, oid] ->
-        {
-          String.replace_prefix(uid, user_prefix, ""),
-          FlakeId.to_string(aid),
-          oid
-        }
-    end)
-  end
-end

lib/pleroma/activity/pruner.ex

@@ -26,15 +26,6 @@ defmodule Pleroma.Activity.Pruner do
     |> Repo.delete_all(timeout: :infinity)
   end
 
-  def prune_updates do
-    before_time = cutoff()
-
-    from(a in Activity,
-      where: fragment("?->>'type' = ?", a.data, "Update") and a.inserted_at < ^before_time
-    )
-    |> Repo.delete_all(timeout: :infinity)
-  end
-
   def prune_removes do
     before_time = cutoff()
 

lib/pleroma/application.ex

@@ -179,8 +179,7 @@ defmodule Pleroma.Application do
       build_cachex("translations", default_ttl: :timer.hours(24 * 30), limit: 2500),
       build_cachex("instances", default_ttl: :timer.hours(24), ttl_interval: 1000, limit: 2500),
       build_cachex("request_signatures", default_ttl: :timer.hours(24 * 30), limit: 3000),
-      build_cachex("rel_me", default_ttl: :timer.hours(24 * 30), limit: 300),
-      build_cachex("http_backoff", default_ttl: :timer.hours(24 * 30), limit: 10000)
+      build_cachex("rel_me", default_ttl: :timer.hours(24 * 30), limit: 300)
     ]
   end
 
@@ -289,7 +288,6 @@ defmodule Pleroma.Application do
       |> Config.get([])
       |> Pleroma.HTTP.AdapterHelper.add_pool_size(pool_size)
       |> Pleroma.HTTP.AdapterHelper.maybe_add_proxy_pool(proxy)
-      |> Pleroma.HTTP.AdapterHelper.ensure_ipv6()
       |> Keyword.put(:name, MyFinch)
 
     [{Finch, config}]

lib/pleroma/application_requirements.ex

@@ -164,8 +164,7 @@ defmodule Pleroma.ApplicationRequirements do
 
   defp check_system_commands!(:ok) do
     filter_commands_statuses = [
-      check_filter(Pleroma.Upload.Filter.Exiftool.StripMetadata, "exiftool"),
-      check_filter(Pleroma.Upload.Filter.Exiftool.ReadDescription, "exiftool"),
+      check_filter(Pleroma.Upload.Filter.Exiftool, "exiftool"),
       check_filter(Pleroma.Upload.Filter.Mogrify, "mogrify"),
       check_filter(Pleroma.Upload.Filter.Mogrifun, "mogrify"),
       check_filter(Pleroma.Upload.Filter.AnalyzeMetadata, "mogrify"),

lib/pleroma/collections/fetcher.ex

@@ -68,10 +68,7 @@ defmodule Akkoma.Collections.Fetcher do
           items
         end
       else
-        {:error, :not_found} ->
-          items
-
-        {:error, :forbidden} ->
+        {:error, {"Object has been deleted", _, _}} ->
           items
 
         {:error, error} ->

lib/pleroma/config/deprecation_warnings.ex

@@ -22,43 +22,6 @@ defmodule Pleroma.Config.DeprecationWarnings do
      "\n* `config :pleroma, :instance, :quarantined_instances` is now covered by `:pleroma, :mrf_simple, :reject`"}
   ]
 
-  def check_exiftool_filter do
-    filters = Config.get([Pleroma.Upload]) |> Keyword.get(:filters, [])
-
-    if Pleroma.Upload.Filter.Exiftool in filters do
-      Logger.warning("""
-      !!!DEPRECATION WARNING!!!
-      Your config is using Exiftool as a filter instead of Exiftool.StripMetadata. This should work for now, but you are advised to change to the new configuration to prevent possible issues later:
-
-      ```
-      config :pleroma, Pleroma.Upload,
-        filters: [Pleroma.Upload.Filter.Exiftool]
-      ```
-
-      Is now
-
-
-      ```
-      config :pleroma, Pleroma.Upload,
-        filters: [Pleroma.Upload.Filter.Exiftool.StripMetadata]
-      ```
-      """)
-
-      new_config =
-        filters
-        |> Enum.map(fn
-          Pleroma.Upload.Filter.Exiftool -> Pleroma.Upload.Filter.Exiftool.StripMetadata
-          filter -> filter
-        end)
-
-      Config.put([Pleroma.Upload, :filters], new_config)
-
-      :error
-    else
-      :ok
-    end
-  end
-
   def check_simple_policy_tuples do
     has_strings =
       Config.get([:mrf_simple])
@@ -219,10 +182,7 @@ defmodule Pleroma.Config.DeprecationWarnings do
       check_quarantined_instances_tuples(),
       check_transparency_exclusions_tuples(),
       check_simple_policy_tuples(),
-      check_http_adapter(),
-      check_uploader_base_url_set(),
-      check_uploader_base_url_is_not_base_domain(),
-      check_exiftool_filter()
+      check_http_adapter()
     ]
     |> Enum.reduce(:ok, fn
       :ok, :ok -> :ok
@@ -377,54 +337,4 @@ defmodule Pleroma.Config.DeprecationWarnings do
       :ok
     end
   end
-
-  def check_uploader_base_url_set() do
-    uses_local_uploader? = Config.get([Pleroma.Upload, :uploader]) == Pleroma.Uploaders.Local
-    base_url = Pleroma.Config.get([Pleroma.Upload, :base_url])
-
-    if base_url || !uses_local_uploader? do
-      :ok
-    else
-      Logger.error("""
-      !!!WARNING!!!
-      Your config does not specify a base_url for uploads!
-      Please make the following change:\n
-      \n* `config :pleroma, Pleroma.Upload, base_url: "https://example.com/media/`
-      \n
-      \nPlease note that it is HEAVILY recommended to use a subdomain to host user-uploaded media!
-      """)
-
-      # This is a hard exit - the uploader will not work without a base_url
-      raise ArgumentError, message: "No base_url set for uploads - please set one in your config!"
-    end
-  end
-
-  def check_uploader_base_url_is_not_base_domain() do
-    uses_local_uploader? = Config.get([Pleroma.Upload, :uploader]) == Pleroma.Uploaders.Local
-
-    uploader_host =
-      [Pleroma.Upload, :base_url]
-      |> Pleroma.Config.get()
-      |> URI.parse()
-      |> Map.get(:host)
-
-    akkoma_host =
-      [Pleroma.Web.Endpoint, :url]
-      |> Pleroma.Config.get()
-      |> Keyword.get(:host)
-
-    if uploader_host == akkoma_host && uses_local_uploader? do
-      Logger.error("""
-      !!!WARNING!!!
-      Your Akkoma Host and your Upload base_url's host are the same!
-      This can potentially be insecure!
-
-      It is HIGHLY recommended that you migrate your media uploads
-      to a subdomain at your earliest convenience
-      """)
-    end
-
-    # This isn't actually an error condition, just a warning
-    :ok
-  end
 end

lib/pleroma/config/release_runtime_provider.ex

@@ -23,7 +23,7 @@ defmodule Pleroma.Config.ReleaseRuntimeProvider do
     with_runtime_config =
       if File.exists?(config_path) do
         # <https://git.pleroma.social/pleroma/pleroma/-/issues/3135>
-        %File.Stat{mode: mode} = File.stat!(config_path)
+        %File.Stat{mode: mode} = File.lstat!(config_path)
 
         if Bitwise.band(mode, 0o007) > 0 do
           raise "Configuration at #{config_path} has world-permissions, execute the following: chmod o= #{config_path}"

lib/pleroma/emails/mailer.ex

@@ -55,61 +55,12 @@ defmodule Pleroma.Emails.Mailer do
 
   @doc false
   def validate_dependency do
-    parse_config([], defaults: false)
+    parse_config([])
     |> Keyword.get(:adapter)
     |> Swoosh.Mailer.validate_dependency()
   end
 
-  defp ensure_charlist(input) do
-    case input do
-      i when is_binary(i) -> String.to_charlist(input)
-      i when is_list(i) -> i
-    end
-  end
-
-  defp default_config(adapter, conf, opts)
-
-  defp default_config(_, _, defaults: false) do
-    []
-  end
-
-  defp default_config(Swoosh.Adapters.SMTP, conf, _) do
-    # gen_smtp and Erlang's tls defaults are very barebones, if nothing is set.
-    # Add sane defaults for our usecase to make config less painful for admins
-    relay = ensure_charlist(Keyword.get(conf, :relay))
-    ssl_disabled = Keyword.get(conf, :ssl) === false
-    os_cacerts = :public_key.cacerts_get()
-
-    common_tls_opts = [
-      cacerts: os_cacerts,
-      versions: [:"tlsv1.2", :"tlsv1.3"],
-      verify: :verify_peer,
-      # some versions have supposedly issues verifying wildcard certs without this
-      server_name_indication: relay,
-      # the default of 10 is too restrictive
-      depth: 32
-    ]
-
-    [
-      auth: :always,
-      no_mx_lookups: false,
-      # Direct SSL/TLS
-      # (if ssl was explicitly disabled, we must not pass TLS options to the socket)
-      ssl: true,
-      sockopts: if(ssl_disabled, do: [], else: common_tls_opts),
-      # STARTTLS upgrade (can't be set to :always when already using direct TLS)
-      tls: :if_available,
-      tls_options: common_tls_opts
-    ]
-  end
-
-  defp default_config(_, _, _), do: []
-
-  defp parse_config(config, opts \\ []) do
-    conf = Swoosh.Mailer.parse_config(@otp_app, __MODULE__, @mailer_config, config)
-    adapter = Keyword.get(conf, :adapter)
-
-    default_config(adapter, conf, opts)
-    |> Keyword.merge(conf)
+  defp parse_config(config) do
+    Swoosh.Mailer.parse_config(@otp_app, __MODULE__, @mailer_config, config)
   end
 end

lib/pleroma/emoji/pack.ex

@@ -26,37 +26,12 @@ defmodule Pleroma.Emoji.Pack do
   alias Pleroma.Emoji.Pack
   alias Pleroma.Utils
 
-  # Invalid/Malicious names are supposed to be filtered out before path joining,
-  # but there are many entrypoints to affected functions so as the code changes
-  # we might accidentally let an unsanitised name slip through.
-  # To make sure, use the below which crash the process otherwise.
-
-  # ALWAYS use this when constructing paths from external name!
-  # (name meaning it must be only a single path component)
-  defp path_join_name_safe(dir, name) do
-    if to_string(name) != Path.basename(name) or name in ["..", ".", ""] do
-      raise "Invalid or malicious pack name: #{name}"
-    else
-      Path.join(dir, name)
-    end
-  end
-
-  # ALWAYS use this to join external paths
-  # (which are allowed to have several components)
-  defp path_join_safe(dir, path) do
-    {:ok, safe_path} = Path.safe_relative(path)
-    Path.join(dir, safe_path)
-  end
-
   @spec create(String.t()) :: {:ok, t()} | {:error, File.posix()} | {:error, :empty_values}
   def create(name) do
     with :ok <- validate_not_empty([name]),
-         dir <- path_join_name_safe(emoji_path(), name),
+         dir <- Path.join(emoji_path(), name),
          :ok <- File.mkdir(dir) do
-      save_pack(%__MODULE__{
-        path: dir,
-        pack_file: Path.join(dir, "pack.json")
-      })
+      save_pack(%__MODULE__{pack_file: Path.join(dir, "pack.json")})
     end
   end
 
@@ -90,7 +65,7 @@ defmodule Pleroma.Emoji.Pack do
           {:ok, [binary()]} | {:error, File.posix(), binary()} | {:error, :empty_values}
   def delete(name) do
     with :ok <- validate_not_empty([name]),
-         pack_path <- path_join_name_safe(emoji_path(), name) do
+         pack_path <- Path.join(emoji_path(), name) do
       File.rm_rf(pack_path)
     end
   end
@@ -114,7 +89,7 @@ defmodule Pleroma.Emoji.Pack do
     end)
   end
 
-  @spec add_file(t(), String.t(), Path.t(), Plug.Upload.t() | binary()) ::
+  @spec add_file(t(), String.t(), Path.t(), Plug.Upload.t()) ::
           {:ok, t()}
           | {:error, File.posix() | atom()}
   def add_file(%Pack{} = pack, _, _, %Plug.Upload{content_type: "application/zip"} = file) do
@@ -132,7 +107,7 @@ defmodule Pleroma.Emoji.Pack do
           Enum.map_reduce(emojies, pack, fn item, emoji_pack ->
             emoji_file = %Plug.Upload{
               filename: item[:filename],
-              path: path_join_safe(tmp_dir, item[:path])
+              path: Path.join(tmp_dir, item[:path])
             }
 
             {:ok, updated_pack} =
@@ -162,14 +137,6 @@ defmodule Pleroma.Emoji.Pack do
   end
 
   def add_file(%Pack{} = pack, shortcode, filename, %Plug.Upload{} = file) do
-    try_add_file(pack, shortcode, filename, file)
-  end
-
-  def add_file(%Pack{} = pack, shortcode, filename, filedata) when is_binary(filedata) do
-    try_add_file(pack, shortcode, filename, filedata)
-  end
-
-  defp try_add_file(%Pack{} = pack, shortcode, filename, file) do
     with :ok <- validate_not_empty([shortcode, filename]),
          :ok <- validate_emoji_not_exists(shortcode),
          {:ok, updated_pack} <- do_add_file(pack, shortcode, filename, file) do
@@ -222,7 +189,6 @@ defmodule Pleroma.Emoji.Pack do
          {:ok, results} <- File.ls(emoji_path) do
       names =
         results
-        # items come from File.ls, thus safe
         |> Enum.map(&Path.join(emoji_path, &1))
         |> Enum.reject(fn path ->
           File.dir?(path) and File.exists?(Path.join(path, "pack.json"))
@@ -321,8 +287,8 @@ defmodule Pleroma.Emoji.Pack do
 
   @spec load_pack(String.t()) :: {:ok, t()} | {:error, :file.posix()}
   def load_pack(name) do
-    pack_dir = path_join_name_safe(emoji_path(), name)
-    pack_file = Path.join(pack_dir, "pack.json")
+    name = Path.basename(name)
+    pack_file = Path.join([emoji_path(), name, "pack.json"])
 
     with {:ok, _} <- File.stat(pack_file),
          {:ok, pack_data} <- File.read(pack_file) do
@@ -446,13 +412,7 @@ defmodule Pleroma.Emoji.Pack do
   end
 
   defp create_archive_and_cache(pack, hash) do
-    files = [
-      ~c"pack.json"
-      | Enum.map(pack.files, fn {_, file} ->
-          {:ok, file} = Path.safe_relative(file)
-          to_charlist(file)
-        end)
-    ]
+    files = [~c"pack.json" | Enum.map(pack.files, fn {_, file} -> to_charlist(file) end)]
 
     {:ok, {_, result}} =
       :zip.zip(~c"#{pack.name}.zip", files, [:memory, cwd: to_charlist(pack.path)])
@@ -514,7 +474,7 @@ defmodule Pleroma.Emoji.Pack do
   end
 
   defp save_file(%Plug.Upload{path: upload_path}, pack, filename) do
-    file_path = path_join_safe(pack.path, filename)
+    file_path = Path.join(pack.path, filename)
     create_subdirs(file_path)
 
     with {:ok, _} <- File.copy(upload_path, file_path) do
@@ -522,12 +482,6 @@ defmodule Pleroma.Emoji.Pack do
     end
   end
 
-  defp save_file(file_data, pack, filename) when is_binary(file_data) do
-    file_path = path_join_safe(pack.path, filename)
-    create_subdirs(file_path)
-    File.write(file_path, file_data, [:binary])
-  end
-
   defp put_emoji(pack, shortcode, filename) do
     files = Map.put(pack.files, shortcode, filename)
     %{pack | files: files, files_count: length(Map.keys(files))}
@@ -539,8 +493,8 @@ defmodule Pleroma.Emoji.Pack do
   end
 
   defp rename_file(pack, filename, new_filename) do
-    old_path = path_join_safe(pack.path, filename)
-    new_path = path_join_safe(pack.path, new_filename)
+    old_path = Path.join(pack.path, filename)
+    new_path = Path.join(pack.path, new_filename)
     create_subdirs(new_path)
 
     with :ok <- File.rename(old_path, new_path) do
@@ -558,7 +512,7 @@ defmodule Pleroma.Emoji.Pack do
 
   defp remove_file(pack, shortcode) do
     with {:ok, filename} <- get_filename(pack, shortcode),
-         emoji <- path_join_safe(pack.path, filename),
+         emoji <- Path.join(pack.path, filename),
          :ok <- File.rm(emoji) do
       remove_dir_if_empty(emoji, filename)
     end
@@ -576,7 +530,7 @@ defmodule Pleroma.Emoji.Pack do
 
   defp get_filename(pack, shortcode) do
     with %{^shortcode => filename} when is_binary(filename) <- pack.files,
-         file_path <- path_join_safe(pack.path, filename),
+         file_path <- Path.join(pack.path, filename),
          {:ok, _} <- File.stat(file_path) do
       {:ok, filename}
     else
@@ -614,7 +568,7 @@ defmodule Pleroma.Emoji.Pack do
   end
 
   defp copy_as(remote_pack, local_name) do
-    path = path_join_name_safe(emoji_path(), local_name)
+    path = Path.join(emoji_path(), local_name)
 
     %__MODULE__{
       name: local_name,

lib/pleroma/http/adapter_helper.ex

@@ -65,15 +65,6 @@ defmodule Pleroma.HTTP.AdapterHelper do
     |> put_in([:pools, :default, :size], pool_size)
   end
 
-  def ensure_ipv6(opts) do
-    # Default transport opts already enable IPv6, so just ensure they're loaded
-    opts
-    |> maybe_add_pools()
-    |> maybe_add_default_pool()
-    |> maybe_add_conn_opts()
-    |> maybe_add_transport_opts()
-  end
-
   defp maybe_add_pools(opts) do
     if Keyword.has_key?(opts, :pools) do
       opts
@@ -105,15 +96,11 @@ defmodule Pleroma.HTTP.AdapterHelper do
   defp maybe_add_transport_opts(opts) do
     transport_opts = get_in(opts, [:pools, :default, :conn_opts, :transport_opts])
 
-    opts =
-      unless is_nil(transport_opts) do
-        opts
-      else
-        put_in(opts, [:pools, :default, :conn_opts, :transport_opts], [])
-      end
-
-    # IPv6 is disabled and IPv4 enabled by default; ensure we can use both
-    put_in(opts, [:pools, :default, :conn_opts, :transport_opts, :inet6], true)
+    unless is_nil(transport_opts) do
+      opts
+    else
+      put_in(opts, [:pools, :default, :conn_opts, :transport_opts], [])
+    end
   end
 
   @doc """

lib/pleroma/http/backoff.ex

@@ -1,121 +0,0 @@
-defmodule Pleroma.HTTP.Backoff do
-  alias Pleroma.HTTP
-  require Logger
-
-  @cachex Pleroma.Config.get([:cachex, :provider], Cachex)
-  @backoff_cache :http_backoff_cache
-
-  # attempt to parse a timestamp from a header
-  # returns nil if it can't parse the timestamp
-  @spec timestamp_or_nil(binary) :: DateTime.t() | nil
-  defp timestamp_or_nil(header) do
-    case DateTime.from_iso8601(header) do
-      {:ok, stamp, _} ->
-        stamp
-
-      _ ->
-        nil
-    end
-  end
-
-  # attempt to parse the x-ratelimit-reset header from the headers
-  @spec x_ratelimit_reset(headers :: list) :: DateTime.t() | nil
-  defp x_ratelimit_reset(headers) do
-    with {_header, value} <- List.keyfind(headers, "x-ratelimit-reset", 0),
-         true <- is_binary(value) do
-      timestamp_or_nil(value)
-    else
-      _ ->
-        nil
-    end
-  end
-
-  # attempt to parse the Retry-After header from the headers
-  # this can be either a timestamp _or_ a number of seconds to wait!
-  # we'll return a datetime if we can parse it, or nil if we can't
-  @spec retry_after(headers :: list) :: DateTime.t() | nil
-  defp retry_after(headers) do
-    with {_header, value} <- List.keyfind(headers, "retry-after", 0),
-         true <- is_binary(value) do
-      # first, see if it's an integer
-      case Integer.parse(value) do
-        {seconds, ""} ->
-          Logger.debug("Parsed Retry-After header: #{seconds} seconds")
-          DateTime.utc_now() |> Timex.shift(seconds: seconds)
-
-        _ ->
-          # if it's not an integer, try to parse it as a timestamp
-          timestamp_or_nil(value)
-      end
-    else
-      _ ->
-        nil
-    end
-  end
-
-  # given a set of headers, will attempt to find the next backoff timestamp
-  # if it can't find one, it will default to 5 minutes from now
-  @spec next_backoff_timestamp(%{headers: list}) :: DateTime.t()
-  defp next_backoff_timestamp(%{headers: headers}) when is_list(headers) do
-    default_5_minute_backoff =
-      DateTime.utc_now()
-      |> Timex.shift(seconds: 5 * 60)
-
-    backoff =
-      [&x_ratelimit_reset/1, &retry_after/1]
-      |> Enum.map(& &1.(headers))
-      |> Enum.find(&(&1 != nil))
-
-    if is_nil(backoff) do
-      Logger.debug("No backoff headers found, defaulting to 5 minutes from now")
-      default_5_minute_backoff
-    else
-      Logger.debug("Found backoff header, will back off until: #{backoff}")
-      backoff
-    end
-  end
-
-  defp next_backoff_timestamp(_), do: DateTime.utc_now() |> Timex.shift(seconds: 5 * 60)
-
-  # utility function to check the HTTP response for potential backoff headers
-  # will check if we get a 429 or 503 response, and if we do, will back off for a bit
-  @spec check_backoff({:ok | :error, HTTP.Env.t()}, binary()) ::
-          {:ok | :error, HTTP.Env.t()} | {:error, :ratelimit}
-  defp check_backoff({:ok, env}, host) do
-    case env.status do
-      status when status in [429, 503] ->
-        Logger.error("Rate limited on #{host}! Backing off...")
-        timestamp = next_backoff_timestamp(env)
-        ttl = Timex.diff(timestamp, DateTime.utc_now(), :seconds)
-        # we will cache the host for 5 minutes
-        @cachex.put(@backoff_cache, host, true, ttl: ttl)
-        {:error, :ratelimit}
-
-      _ ->
-        {:ok, env}
-    end
-  end
-
-  defp check_backoff(env, _), do: env
-
-  @doc """
-  this acts as a single throughput for all GET requests
-  we will check if the host is in the cache, and if it is, we will automatically fail the request
-  this ensures that we don't hammer the server with requests, and instead wait for the backoff to expire
-  this is a very simple implementation, and can be improved upon!
-  """
-  @spec get(binary, list, list) :: {:ok | :error, HTTP.Env.t()} | {:error, :ratelimit}
-  def get(url, headers \\ [], options \\ []) do
-    %{host: host} = URI.parse(url)
-
-    case @cachex.get(@backoff_cache, host) do
-      {:ok, nil} ->
-        url
-        |> HTTP.get(headers, options)
-        |> check_backoff(host)
-
-      _ ->
-        {:error, :ratelimit}
-    end
-  end
-end

lib/pleroma/job_queue_monitor.ex

@@ -15,19 +15,8 @@ defmodule Pleroma.JobQueueMonitor do
 
   @impl true
   def init(state) do
-    :telemetry.attach(
-      "oban-monitor-failure",
-      [:oban, :job, :exception],
-      &Pleroma.JobQueueMonitor.handle_event/4,
-      nil
-    )
-
-    :telemetry.attach(
-      "oban-monitor-success",
-      [:oban, :job, :stop],
-      &Pleroma.JobQueueMonitor.handle_event/4,
-      nil
-    )
+    :telemetry.attach("oban-monitor-failure", [:oban, :job, :exception], &handle_event/4, nil)
+    :telemetry.attach("oban-monitor-success", [:oban, :job, :stop], &handle_event/4, nil)
 
     {:ok, state}
   end

lib/pleroma/object.ex

@@ -178,10 +178,7 @@ defmodule Pleroma.Object do
         ap_id
 
       Keyword.get(options, :fetch) ->
-        case Fetcher.fetch_object_from_id(ap_id, options) do
-          {:ok, object} -> object
-          _ -> nil
-        end
+        Fetcher.fetch_object_from_id!(ap_id, options)
 
       true ->
         get_cached_by_ap_id(ap_id)

lib/pleroma/object/containment.ex

@@ -11,9 +11,6 @@ defmodule Pleroma.Object.Containment do
   Object containment is an important step in validating remote objects to prevent
   spoofing, therefore removal of object containment functions is NOT recommended.
   """
-
-  alias Pleroma.Web.ActivityPub.Transmogrifier
-
   def get_actor(%{"actor" => actor}) when is_binary(actor) do
     actor
   end
@@ -50,31 +47,6 @@ defmodule Pleroma.Object.Containment do
   defp compare_uris(%URI{host: host} = _id_uri, %URI{host: host} = _other_uri), do: :ok
   defp compare_uris(_id_uri, _other_uri), do: :error
 
-  defp compare_uris_exact(uri, uri), do: :ok
-
-  defp compare_uris_exact(%URI{} = id, %URI{} = other),
-    do: compare_uris_exact(URI.to_string(id), URI.to_string(other))
-
-  defp compare_uris_exact(id_uri, other_uri)
-       when is_binary(id_uri) and is_binary(other_uri) do
-    norm_id = String.replace_suffix(id_uri, "/", "")
-    norm_other = String.replace_suffix(other_uri, "/", "")
-    if norm_id == norm_other, do: :ok, else: :error
-  end
-
-  @doc """
-  Checks whether an URL to fetch from is from the local server.
-
-  We never want to fetch from ourselves; if it’s not in the database
-  it can’t be authentic and must be a counterfeit.
-  """
-  def contain_local_fetch(id) do
-    case compare_uris(URI.parse(id), Pleroma.Web.Endpoint.struct_url()) do
-      :ok -> :error
-      _ -> :ok
-    end
-  end
-
   @doc """
   Checks that an imported AP object's actor matches the host it came from.
   """
@@ -90,31 +62,8 @@ defmodule Pleroma.Object.Containment do
   def contain_origin(id, %{"attributedTo" => actor} = params),
     do: contain_origin(id, Map.put(params, "actor", actor))
 
-  def contain_origin(_id, _data), do: :ok
+  def contain_origin(_id, _data), do: :error
 
-  @doc """
-  Check whether the fetch URL (after redirects) exactly (sans tralining slash) matches either
-  the canonical ActivityPub id or the objects url field (for display URLs from *key and Mastodon)
-
-  Since this is meant to be used for fetches, anonymous or transient objects are not accepted here.
-  """
-  def contain_id_to_fetch(url, %{"id" => id} = data) when is_binary(id) do
-    with {:id, :error} <- {:id, compare_uris_exact(id, url)},
-         # "url" can be a "Link" object and this is checked before full normalisation
-         display_url <- Transmogrifier.fix_url(data)["url"],
-         true <- display_url != nil do
-      compare_uris_exact(display_url, url)
-    else
-      {:id, :ok} -> :ok
-      _ -> :error
-    end
-  end
-
-  def contain_id_to_fetch(_url, _data), do: :error
-
-  @doc """
-  Check whether the object id is from the same host as another id
-  """
   def contain_origin_from_id(id, %{"id" => other_id} = _params) when is_binary(other_id) do
     id_uri = URI.parse(id)
     other_uri = URI.parse(other_id)
@@ -136,12 +85,4 @@ defmodule Pleroma.Object.Containment do
     do: contain_origin(id, object)
 
   def contain_child(_), do: :ok
-
-  @doc "Checks whether two URIs belong to the same domain"
-  def same_origin(id1, id2) do
-    uri1 = URI.parse(id1)
-    uri2 = URI.parse(id2)
-
-    compare_uris(uri1, uri2)
-  end
 end

lib/pleroma/object/fetcher.ex

@@ -18,16 +18,6 @@ defmodule Pleroma.Object.Fetcher do
   require Logger
   require Pleroma.Constants
 
-  @moduledoc """
-  This module deals with correctly fetching Acitivity Pub objects in a safe way.
-
-  The core function is `fetch_and_contain_remote_object_from_id/1` which performs
-  the actual fetch and common safety and authenticity checks. Other `fetch_*`
-  function use the former and perform some additional tasks
-  """
-
-  @mix_env Mix.env()
-
   defp touch_changeset(changeset) do
     updated_at =
       NaiveDateTime.utc_now()
@@ -113,78 +103,54 @@ defmodule Pleroma.Object.Fetcher do
     end
   end
 
-  @doc "Assumes object already is in our database and refetches from remote to update (e.g. for polls)"
   def refetch_object(%Object{data: %{"id" => id}} = object) do
     with {:local, false} <- {:local, Object.local?(object)},
          {:ok, new_data} <- fetch_and_contain_remote_object_from_id(id),
-         {:id, true} <- {:id, new_data["id"] == id},
          {:ok, object} <- reinject_object(object, new_data) do
       {:ok, object}
     else
       {:local, true} -> {:ok, object}
-      {:id, false} -> {:error, :id_mismatch}
       e -> {:error, e}
     end
   end
 
-  @doc """
-    Fetches a new object and puts it through the processing pipeline for inbound objects
-
-    Note: will also insert a fake Create activity, since atm we internally
-    need everything to be traced back to a Create activity.
-  """
+  # Note: will create a Create activity, which we need internally at the moment.
   def fetch_object_from_id(id, options \\ []) do
     with %URI{} = uri <- URI.parse(id),
          # let's check the URI is even vaguely valid first
-         {:valid_uri_scheme, true} <-
-           {:valid_uri_scheme, uri.scheme == "http" or uri.scheme == "https"},
+         {:scheme, true} <- {:scheme, uri.scheme == "http" or uri.scheme == "https"},
          # If we have instance restrictions, apply them here to prevent fetching from unwanted instances
-         {:mrf_reject_check, {:ok, nil}} <-
-           {:mrf_reject_check, Pleroma.Web.ActivityPub.MRF.SimplePolicy.check_reject(uri)},
-         {:mrf_accept_check, {:ok, _}} <-
-           {:mrf_accept_check, Pleroma.Web.ActivityPub.MRF.SimplePolicy.check_accept(uri)},
+         {:ok, nil} <- Pleroma.Web.ActivityPub.MRF.SimplePolicy.check_reject(uri),
+         {:ok, _} <- Pleroma.Web.ActivityPub.MRF.SimplePolicy.check_accept(uri),
          {_, nil} <- {:fetch_object, Object.get_cached_by_ap_id(id)},
          {_, true} <- {:allowed_depth, Federator.allowed_thread_distance?(options[:depth])},
          {_, {:ok, data}} <- {:fetch, fetch_and_contain_remote_object_from_id(id)},
          {_, nil} <- {:normalize, Object.normalize(data, fetch: false)},
          params <- prepare_activity_params(data),
+         {_, :ok} <- {:containment, Containment.contain_origin(id, params)},
          {_, {:ok, activity}} <-
            {:transmogrifier, Transmogrifier.handle_incoming(params, options)},
          {_, _data, %Object{} = object} <-
            {:object, data, Object.normalize(activity, fetch: false)} do
       {:ok, object}
     else
-      {:allowed_depth, false} = e ->
-        log_fetch_error(id, e)
-        {:error, :allowed_depth}
+      {:allowed_depth, false} ->
+        {:error, "Max thread distance exceeded."}
 
-      {:valid_uri_scheme, _} = e ->
-        log_fetch_error(id, e)
-        {:error, :invalid_uri_scheme}
+      {:scheme, false} ->
+        {:error, "URI Scheme Invalid"}
 
-      {:mrf_reject_check, _} = e ->
-        log_fetch_error(id, e)
-        {:reject, :mrf}
+      {:containment, _} ->
+        {:error, "Object containment failed."}
 
-      {:mrf_accept_check, _} = e ->
-        log_fetch_error(id, e)
-        {:reject, :mrf}
+      {:transmogrifier, {:error, {:reject, e}}} ->
+        {:reject, e}
 
-      {:containment, reason} = e ->
-        log_fetch_error(id, e)
-        {:error, reason}
+      {:transmogrifier, {:reject, e}} ->
+        {:reject, e}
 
-      {:transmogrifier, {:error, {:reject, reason}}} = e ->
-        log_fetch_error(id, e)
-        {:reject, reason}
-
-      {:transmogrifier, {:reject, reason}} = e ->
-        log_fetch_error(id, e)
-        {:reject, reason}
-
-      {:transmogrifier, reason} = e ->
-        log_fetch_error(id, e)
-        {:error, reason}
+      {:transmogrifier, _} = e ->
+        {:error, e}
 
       {:object, data, nil} ->
         reinject_object(%Object{}, data)
@@ -195,21 +161,17 @@ defmodule Pleroma.Object.Fetcher do
       {:fetch_object, %Object{} = object} ->
         {:ok, object}
 
-      {:fetch, {:error, reason}} = e ->
-        log_fetch_error(id, e)
-        {:error, reason}
+      {:fetch, {:error, error}} ->
+        {:error, error}
+
+      {:reject, reason} ->
+        {:reject, reason}
 
       e ->
-        log_fetch_error(id, e)
-        {:error, e}
+        e
     end
   end
 
-  defp log_fetch_error(id, error) do
-    Logger.metadata(object: id)
-    Logger.error("Object rejected while fetching #{id} #{inspect(error)}")
-  end
-
   defp prepare_activity_params(data) do
     %{
       "type" => "Create",
@@ -223,6 +185,26 @@ defmodule Pleroma.Object.Fetcher do
     |> Maps.put_if_present("bcc", data["bcc"])
   end
 
+  def fetch_object_from_id!(id, options \\ []) do
+    with {:ok, object} <- fetch_object_from_id(id, options) do
+      object
+    else
+      {:error, %Tesla.Mock.Error{}} ->
+        nil
+
+      {:error, {"Object has been deleted", _id, _code}} ->
+        nil
+
+      {:reject, reason} ->
+        Logger.debug("Rejected #{id} while fetching: #{inspect(reason)}")
+        nil
+
+      e ->
+        Logger.error("Error while fetching #{id}: #{inspect(e)}")
+        nil
+    end
+  end
+
   defp make_signature(id, date) do
     uri = URI.parse(id)
 
@@ -253,7 +235,6 @@ defmodule Pleroma.Object.Fetcher do
     end
   end
 
-  @doc "Fetches arbitrary remote object and performs basic safety and authenticity checks"
   def fetch_and_contain_remote_object_from_id(id)
 
   def fetch_and_contain_remote_object_from_id(%{"id" => id}),
@@ -262,46 +243,18 @@ defmodule Pleroma.Object.Fetcher do
   def fetch_and_contain_remote_object_from_id(id) when is_binary(id) do
     Logger.debug("Fetching object #{id} via AP")
 
-    with {:valid_uri_scheme, true} <- {:valid_uri_scheme, String.starts_with?(id, "http")},
-         %URI{} = uri <- URI.parse(id),
-         {:mrf_reject_check, {:ok, nil}} <-
-           {:mrf_reject_check, Pleroma.Web.ActivityPub.MRF.SimplePolicy.check_reject(uri)},
-         {:mrf_accept_check, {:ok, _}} <-
-           {:mrf_accept_check, Pleroma.Web.ActivityPub.MRF.SimplePolicy.check_accept(uri)},
-         {:local_fetch, :ok} <- {:local_fetch, Containment.contain_local_fetch(id)},
-         {:ok, final_id, body} <- get_object(id),
+    with {:scheme, true} <- {:scheme, String.starts_with?(id, "http")},
+         {:ok, body} <- get_object(id),
          {:ok, data} <- safe_json_decode(body),
-         {_, :ok} <- {:strict_id, Containment.contain_id_to_fetch(final_id, data)},
-         {_, :ok} <- {:containment, Containment.contain_origin(final_id, data)} do
-      unless Instances.reachable?(final_id) do
-        Instances.set_reachable(final_id)
+         :ok <- Containment.contain_origin_from_id(id, data) do
+      unless Instances.reachable?(id) do
+        Instances.set_reachable(id)
       end
 
       {:ok, data}
     else
-      {:strict_id, _} = e ->
-        log_fetch_error(id, e)
-        {:error, :id_mismatch}
-
-      {:mrf_reject_check, _} = e ->
-        log_fetch_error(id, e)
-        {:reject, :mrf}
-
-      {:mrf_accept_check, _} = e ->
-        log_fetch_error(id, e)
-        {:reject, :mrf}
-
-      {:valid_uri_scheme, _} = e ->
-        log_fetch_error(id, e)
-        {:error, :invalid_uri_scheme}
-
-      {:local_fetch, _} = e ->
-        log_fetch_error(id, e)
-        {:error, :local_resource}
-
-      {:containment, reason} ->
-        log_fetch_error(id, reason)
-        {:error, reason}
+      {:scheme, _} ->
+        {:error, "Unsupported URI scheme"}
 
       {:error, e} ->
         {:error, e}
@@ -312,85 +265,47 @@ defmodule Pleroma.Object.Fetcher do
   end
 
   def fetch_and_contain_remote_object_from_id(_id),
-    do: {:error, :invalid_id}
+    do: {:error, "id must be a string"}
 
-  defp check_crossdomain_redirect(final_host, original_url)
-
-  # HOPEFULLY TEMPORARY
-  # Basically none of our Tesla mocks in tests set the (supposed to
-  # exist for Tesla proper) url parameter for their responses
-  # causing almost every fetch in test to fail otherwise
-  if @mix_env == :test do
-    defp check_crossdomain_redirect(nil, _) do
-      {:cross_domain_redirect, false}
-    end
-  end
-
-  defp check_crossdomain_redirect(final_host, original_url) do
-    {:cross_domain_redirect, final_host != URI.parse(original_url).host}
-  end
-
-  if @mix_env == :test do
-    defp get_final_id(nil, initial_url), do: initial_url
-    defp get_final_id("", initial_url), do: initial_url
-  end
-
-  defp get_final_id(final_url, _intial_url) do
-    final_url
-  end
-
-  @doc "Do NOT use; only public for use in tests"
   def get_object(id) do
     date = Pleroma.Signature.signed_date()
 
     headers =
-      [
-        # The first is required by spec, the second provided as a fallback for buggy implementations
-        {"accept", "application/ld+json; profile=\"https://www.w3.org/ns/activitystreams\""},
-        {"accept", "application/activity+json"}
-      ]
+      [{"accept", "application/activity+json"}]
       |> maybe_date_fetch(date)
       |> sign_fetch(id, date)
 
-    with {:ok, %{body: body, status: code, headers: headers, url: final_url}}
-         when code in 200..299 <-
-           HTTP.Backoff.get(id, headers),
-         remote_host <-
-           URI.parse(final_url).host,
-         {:cross_domain_redirect, false} <-
-           check_crossdomain_redirect(remote_host, id),
-         {:has_content_type, {_, content_type}} <-
-           {:has_content_type, List.keyfind(headers, "content-type", 0)},
-         {:parse_content_type, {:ok, "application", subtype, type_params}} <-
-           {:parse_content_type, Plug.Conn.Utils.media_type(content_type)} do
-      final_id = get_final_id(final_url, id)
+    case HTTP.get(id, headers) do
+      {:ok, %{body: body, status: code, headers: headers}} when code in 200..299 ->
+        case List.keyfind(headers, "content-type", 0) do
+          {_, content_type} ->
+            case Plug.Conn.Utils.media_type(content_type) do
+              {:ok, "application", "activity+json", _} ->
+                {:ok, body}
 
-      case {subtype, type_params} do
-        {"activity+json", _} ->
-          {:ok, final_id, body}
+              {:ok, "application", "ld+json",
+               %{"profile" => "https://www.w3.org/ns/activitystreams"}} ->
+                {:ok, body}
 
-        {"ld+json", %{"profile" => "https://www.w3.org/ns/activitystreams"}} ->
-          {:ok, final_id, body}
+              # pixelfed sometimes (and only sometimes) responds with http instead of https
+              {:ok, "application", "ld+json",
+               %{"profile" => "http://www.w3.org/ns/activitystreams"}} ->
+                {:ok, body}
 
-        _ ->
-          {:error, {:content_type, content_type}}
-      end
-    else
-      {:ok, %{status: code}} when code in [401, 403] ->
-        {:error, :forbidden}
+              _ ->
+                {:error, {:content_type, content_type}}
+            end
+
+          _ ->
+            {:error, {:content_type, nil}}
+        end
 
       {:ok, %{status: code}} when code in [404, 410] ->
-        {:error, :not_found}
+        {:error, {"Object has been deleted", id, code}}
 
       {:error, e} ->
         {:error, e}
 
-      {:has_content_type, _} ->
-        {:error, {:content_type, nil}}
-
-      {:parse_content_type, e} ->
-        {:error, {:content_type, e}}
-
       e ->
         {:error, e}
     end

lib/pleroma/reverse_proxy.ex

@@ -17,8 +17,6 @@ defmodule Pleroma.ReverseProxy do
   @failed_request_ttl :timer.seconds(60)
   @methods ~w(GET HEAD)
 
-  @allowed_mime_types Pleroma.Config.get([Pleroma.Upload, :allowed_mime_types], [])
-
   @cachex Pleroma.Config.get([:cachex, :provider], Cachex)
 
   def max_read_duration_default, do: @max_read_duration
@@ -255,7 +253,6 @@ defmodule Pleroma.ReverseProxy do
     headers
     |> Enum.filter(fn {k, _} -> k in @keep_resp_headers end)
     |> build_resp_cache_headers(opts)
-    |> sanitise_content_type()
     |> build_resp_content_disposition_header(opts)
     |> build_csp_headers()
     |> Keyword.merge(Keyword.get(opts, :resp_headers, []))
@@ -285,21 +282,6 @@ defmodule Pleroma.ReverseProxy do
     end
   end
 
-  defp sanitise_content_type(headers) do
-    original_ct = get_content_type(headers)
-
-    safe_ct =
-      Pleroma.Web.Plugs.Utils.get_safe_mime_type(
-        %{allowed_mime_types: @allowed_mime_types},
-        original_ct
-      )
-
-    [
-      {"content-type", safe_ct}
-      | Enum.filter(headers, fn {k, _v} -> k != "content-type" end)
-    ]
-  end
-
   defp build_resp_content_disposition_header(headers, opts) do
     opt = Keyword.get(opts, :inline_content_types, @inline_content_types)
 

lib/pleroma/signature.ex

@@ -10,7 +10,7 @@ defmodule Pleroma.Signature do
   alias Pleroma.User
   alias Pleroma.Web.ActivityPub.ActivityPub
 
-  @known_suffixes ["/publickey", "/main-key", "#key"]
+  @known_suffixes ["/publickey", "/main-key"]
 
   def key_id_to_actor_id(key_id) do
     uri =

lib/pleroma/upload.ex

@@ -61,23 +61,12 @@ defmodule Pleroma.Upload do
           width: integer(),
           height: integer(),
           blurhash: String.t(),
-          description: String.t(),
           path: String.t()
         }
 
-  @always_enabled_filters [Pleroma.Upload.Filter.Dedupe]
+  @always_enabled_filters [Pleroma.Upload.Filter.AnonymizeFilename]
 
-  defstruct [
-    :id,
-    :name,
-    :tempfile,
-    :content_type,
-    :width,
-    :height,
-    :blurhash,
-    :description,
-    :path
-  ]
+  defstruct [:id, :name, :tempfile, :content_type, :width, :height, :blurhash, :path]
 
   @spec store(source, options :: [option()]) :: {:ok, Map.t()} | {:error, any()}
   @doc "Store a file. If using a `Plug.Upload{}` as the source, be sure to use `Majic.Plug` to ensure its content_type and filename is correct."
@@ -87,7 +76,7 @@ defmodule Pleroma.Upload do
     with {:ok, upload} <- prepare_upload(upload, opts),
          upload = %__MODULE__{upload | path: upload.path || "#{upload.id}/#{upload.name}"},
          {:ok, upload} <- Pleroma.Upload.Filter.filter(opts.filters, upload),
-         description = Map.get(upload, :description) || "",
+         description = Map.get(opts, :description) || "",
          {_, true} <-
            {:description_limit,
             String.length(description) <= Pleroma.Config.get([:instance, :description_limit])},
@@ -163,8 +152,7 @@ defmodule Pleroma.Upload do
          id: UUID.generate(),
          name: file.filename,
          tempfile: file.path,
-         content_type: file.content_type,
-         description: opts.description
+         content_type: file.content_type
        }}
     end
   end
@@ -184,8 +172,7 @@ defmodule Pleroma.Upload do
          id: UUID.generate(),
          name: hash <> "." <> ext,
          tempfile: tmp_path,
-         content_type: content_type,
-         description: opts.description
+         content_type: content_type
        }}
     end
   end
@@ -248,7 +235,7 @@ defmodule Pleroma.Upload do
 
     case uploader do
       Pleroma.Uploaders.Local ->
-        upload_base_url
+        upload_base_url || Pleroma.Web.Endpoint.url() <> "/media/"
 
       Pleroma.Uploaders.S3 ->
         bucket = Config.get([Pleroma.Uploaders.S3, :bucket])
@@ -274,7 +261,7 @@ defmodule Pleroma.Upload do
         end
 
       _ ->
-        public_endpoint || upload_base_url
+        public_endpoint || upload_base_url || Pleroma.Web.Endpoint.url() <> "/media/"
     end
   end
 end

lib/pleroma/upload/filter/exiftool.ex

@@ -2,42 +2,24 @@
 # Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
 # SPDX-License-Identifier: AGPL-3.0-only
 
-defmodule Pleroma.Upload.Filter.Exiftool.StripMetadata do
+defmodule Pleroma.Upload.Filter.Exiftool do
   @moduledoc """
-  Tries to strip all image metadata but colorspace and orientation overwriting the file in place.
+  Strips GPS related EXIF tags and overwrites the file in place.
   Also strips or replaces filesystem metadata e.g., timestamps.
   """
   @behaviour Pleroma.Upload.Filter
 
-  alias Pleroma.Config
-
-  @purge_default ["all", "CommonIFD0"]
-  @preserve_default ["ColorSpaceTags", "Orientation"]
-
   @spec filter(Pleroma.Upload.t()) :: {:ok, :noop} | {:ok, :filtered} | {:error, String.t()}
 
   # Formats not compatible with exiftool at this time
+  def filter(%Pleroma.Upload{content_type: "image/heic"}), do: {:ok, :noop}
   def filter(%Pleroma.Upload{content_type: "image/webp"}), do: {:ok, :noop}
   def filter(%Pleroma.Upload{content_type: "image/svg+xml"}), do: {:ok, :noop}
+  def filter(%Pleroma.Upload{content_type: "image/jxl"}), do: {:ok, :noop}
 
   def filter(%Pleroma.Upload{tempfile: file, content_type: "image" <> _}) do
-    purge_args =
-      Config.get([__MODULE__, :purge], @purge_default)
-      |> Enum.map(fn mgroup -> "-" <> mgroup <> "=" end)
-
-    preserve_args =
-      Config.get([__MODULE__, :preserve], @preserve_default)
-      |> Enum.map(fn mgroup -> "-" <> mgroup end)
-      |> then(fn
-        # If -TagsFromFile is not followed by tag selectors, it will copy most available tags
-        [] -> []
-        args -> ["-TagsFromFile", "@" | args]
-      end)
-
-    args = ["-ignoreMinorErrors", "-overwrite_original" | purge_args] ++ preserve_args ++ [file]
-
     try do
-      case System.cmd("exiftool", args, parallelism: true) do
+      case System.cmd("exiftool", ["-overwrite_original", "-gps:all=", file], parallelism: true) do
         {_response, 0} -> {:ok, :filtered}
         {error, 1} -> {:error, error}
       end

lib/pleroma/upload/filter/exiftool/read_description.ex

@@ -1,52 +0,0 @@
-# Pleroma: A lightweight social networking server
-# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
-# SPDX-License-Identifier: AGPL-3.0-only
-
-defmodule Pleroma.Upload.Filter.Exiftool.ReadDescription do
-  @moduledoc """
-  Gets a valid description from the related EXIF tags and provides them in the response if no description is provided yet.
-  It will first check ImageDescription, when that doesn't probide a valid description, it will check iptc:Caption-Abstract.
-  A valid description means the fields are filled in and not too long (see `:instance, :description_limit`).
-  """
-  @behaviour Pleroma.Upload.Filter
-
-  @spec filter(Pleroma.Upload.t()) :: {:ok, any()} | {:error, String.t()}
-
-  def filter(%Pleroma.Upload{description: description})
-      when is_binary(description),
-      do: {:ok, :noop}
-
-  def filter(%Pleroma.Upload{tempfile: file} = upload),
-    do: {:ok, :filtered, upload |> Map.put(:description, read_description_from_exif_data(file))}
-
-  def filter(_, _), do: {:ok, :noop}
-
-  defp read_description_from_exif_data(file) do
-    nil
-    |> read_when_empty(file, "-ImageDescription")
-    |> read_when_empty(file, "-iptc:Caption-Abstract")
-  end
-
-  defp read_when_empty(current_description, _, _) when is_binary(current_description),
-    do: current_description
-
-  defp read_when_empty(_, file, tag) do
-    try do
-      {tag_content, 0} =
-        System.cmd("exiftool", ["-b", "-s3", tag, file],
-          stderr_to_stdout: true,
-          parallelism: true
-        )
-
-      tag_content = String.trim(tag_content)
-
-      if tag_content != "" and
-           String.length(tag_content) <=
-             Pleroma.Config.get([:instance, :description_limit]),
-         do: tag_content,
-         else: nil
-    rescue
-      _ in ErlangError -> nil
-    end
-  end
-end

lib/pleroma/user.ex

@@ -160,7 +160,6 @@ defmodule Pleroma.User do
     field(:last_status_at, :naive_datetime)
     field(:language, :string)
     field(:status_ttl_days, :integer, default: nil)
-    field(:permit_followback, :boolean, default: false)
 
     field(:accepts_direct_messages_from, Ecto.Enum,
       values: [:everybody, :people_i_follow, :nobody],
@@ -382,10 +381,6 @@ defmodule Pleroma.User do
     do_optional_url(user.banner, "#{Endpoint.url()}/images/banner.png", options)
   end
 
-  def background_url(user) do
-    do_optional_url(user.background, nil, no_default: true)
-  end
-
   defp do_optional_url(field, default, options) do
     case field do
       %{"url" => [%{"href" => href} | _]} when is_binary(href) ->
@@ -470,7 +465,6 @@ defmodule Pleroma.User do
         :avatar,
         :ap_enabled,
         :banner,
-        :background,
         :is_locked,
         :last_refreshed_at,
         :uri,
@@ -550,7 +544,6 @@ defmodule Pleroma.User do
         :actor_type,
         :disclose_client,
         :status_ttl_days,
-        :permit_followback,
         :accepts_direct_messages_from
       ]
     )
@@ -969,32 +962,26 @@ defmodule Pleroma.User do
 
   defp maybe_send_registration_email(_), do: {:ok, :noop}
 
-  def needs_update?(user, options \\ [])
-  def needs_update?(%User{local: true}, _options), do: false
-  def needs_update?(%User{local: false, last_refreshed_at: nil}, _options), do: true
+  def needs_update?(%User{local: true}), do: false
 
-  def needs_update?(%User{local: false} = user, options) do
-    NaiveDateTime.diff(NaiveDateTime.utc_now(), user.last_refreshed_at) >=
-      Keyword.get(options, :maximum_age, 86_400)
+  def needs_update?(%User{local: false, last_refreshed_at: nil}), do: true
+
+  def needs_update?(%User{local: false} = user) do
+    NaiveDateTime.diff(NaiveDateTime.utc_now(), user.last_refreshed_at) >= 86_400
   end
 
-  def needs_update?(_, _options), do: true
-
-  # "Locked" (self-locked) users demand explicit authorization of follow requests
-  @spec can_direct_follow_local(User.t(), User.t()) :: true | false
-  def can_direct_follow_local(%User{} = follower, %User{local: true} = followed) do
-    !followed.is_locked || (followed.permit_followback and is_friend_of(follower, followed))
-  end
+  def needs_update?(_), do: true
 
   @spec maybe_direct_follow(User.t(), User.t()) ::
           {:ok, User.t(), User.t()} | {:error, String.t()}
 
+  # "Locked" (self-locked) users demand explicit authorization of follow requests
+  def maybe_direct_follow(%User{} = follower, %User{local: true, is_locked: true} = followed) do
+    follow(follower, followed, :follow_pending)
+  end
+
   def maybe_direct_follow(%User{} = follower, %User{local: true} = followed) do
-    if can_direct_follow_local(follower, followed) do
-      follow(follower, followed)
-    else
-      follow(follower, followed, :follow_pending)
-    end
+    follow(follower, followed)
   end
 
   def maybe_direct_follow(%User{} = follower, %User{} = followed) do
@@ -1344,13 +1331,6 @@ defmodule Pleroma.User do
     |> Repo.all()
   end
 
-  def is_friend_of(%User{} = potential_friend, %User{local: true} = user) do
-    user
-    |> get_friends_query()
-    |> where(id: ^potential_friend.id)
-    |> Repo.exists?()
-  end
-
   def increase_note_count(%User{} = user) do
     User
     |> where(id: ^user.id)
@@ -1981,10 +1961,10 @@ defmodule Pleroma.User do
 
   def fetch_by_ap_id(ap_id), do: ActivityPub.make_user_from_ap_id(ap_id)
 
-  def get_or_fetch_by_ap_id(ap_id, options \\ []) do
+  def get_or_fetch_by_ap_id(ap_id) do
     cached_user = get_cached_by_ap_id(ap_id)
 
-    maybe_fetched_user = needs_update?(cached_user, options) && fetch_by_ap_id(ap_id)
+    maybe_fetched_user = needs_update?(cached_user) && fetch_by_ap_id(ap_id)
 
     case {cached_user, maybe_fetched_user} do
       {_, {:ok, %User{} = user}} ->

lib/pleroma/web/activity_pub/activity_pub.ex

@@ -22,7 +22,6 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
   alias Pleroma.Upload
   alias Pleroma.User
   alias Pleroma.Web.ActivityPub.MRF
-  alias Pleroma.Web.ActivityPub.ObjectValidators.UserValidator
   alias Pleroma.Web.ActivityPub.Transmogrifier
   alias Pleroma.Web.Streamer
   alias Pleroma.Web.WebFinger
@@ -1604,7 +1603,6 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
       uri: get_actor_url(data["url"]),
       ap_enabled: true,
       banner: normalize_image(data["image"]),
-      background: normalize_image(data["backgroundUrl"]),
       fields: fields,
       emoji: emojis,
       is_locked: is_locked,
@@ -1705,7 +1703,9 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
            Fetcher.fetch_and_contain_remote_object_from_id(first) do
       {:ok, false}
     else
-      {:error, _} -> {:ok, true}
+      {:error, {:ok, %{status: code}}} when code in [401, 403] -> {:ok, true}
+      {:error, _} = e -> e
+      e -> {:error, e}
     end
   end
 
@@ -1721,7 +1721,6 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
 
   def fetch_and_prepare_user_from_ap_id(ap_id, additional \\ []) do
     with {:ok, data} <- Fetcher.fetch_and_contain_remote_object_from_id(ap_id),
-         {:valid, {:ok, _, _}} <- {:valid, UserValidator.validate(data, [])},
          {:ok, data} <- user_data_from_user_object(data, additional) do
       {:ok, maybe_update_follow_information(data)}
     else
@@ -1730,14 +1729,10 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
         Logger.debug("Could not decode user at fetch #{ap_id}, #{inspect(e)}")
         {:error, e}
 
-      {:reject, reason} = e ->
+      {:error, {:reject, reason} = e} ->
         Logger.debug("Rejected user #{ap_id}: #{inspect(reason)}")
         {:error, e}
 
-      {:valid, reason} ->
-        Logger.debug("Data is not a valid user #{ap_id}: #{inspect(reason)}")
-        {:error, "Not a user"}
-
       {:error, e} ->
         Logger.error("Could not decode user at fetch #{ap_id}, #{inspect(e)}")
         {:error, e}
@@ -1838,13 +1833,6 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
       with {:ok, data} <- fetch_and_prepare_user_from_ap_id(ap_id, additional) do
         {:ok, _pid} = Task.start(fn -> pinned_fetch_task(data) end)
 
-        user =
-          if data.ap_id != ap_id do
-            User.get_cached_by_ap_id(data.ap_id)
-          else
-            user
-          end
-
         if user do
           user
           |> User.remote_user_changeset(data)

lib/pleroma/web/activity_pub/activity_pub_controller.ex

@@ -12,7 +12,9 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubController do
   alias Pleroma.Web.ActivityPub.ActivityPub
   alias Pleroma.Web.ActivityPub.InternalFetchActor
   alias Pleroma.Web.ActivityPub.ObjectView
+  alias Pleroma.Web.ActivityPub.Pipeline
   alias Pleroma.Web.ActivityPub.Relay
+  alias Pleroma.Web.ActivityPub.Transmogrifier
   alias Pleroma.Web.ActivityPub.UserView
   alias Pleroma.Web.ActivityPub.Utils
   alias Pleroma.Web.ActivityPub.Visibility
@@ -38,9 +40,11 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubController do
   # Note: :following and :followers must be served even without authentication (as via :api)
   plug(
     EnsureAuthenticatedPlug
-    when action in [:read_inbox]
+    when action in [:read_inbox, :update_outbox, :whoami, :upload_media]
   )
 
+  plug(Majic.Plug, [pool: Pleroma.MajicPool] when action in [:upload_media])
+
   plug(
     Pleroma.Web.Plugs.Cache,
     [query_params: false, tracking_fun: &__MODULE__.track_object_fetch/2]
@@ -156,9 +160,7 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubController do
     end
   end
 
-  @doc """
-  GET /relay/following
-  """
+  # GET /relay/following
   def relay_following(conn, _params) do
     with %{halted: false} = conn <- FederatingPlug.call(conn, []) do
       conn
@@ -195,9 +197,7 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubController do
     end
   end
 
-  @doc """
-  GET /relay/followers
-  """
+  # GET /relay/followers
   def relay_followers(conn, _params) do
     with %{halted: false} = conn <- FederatingPlug.call(conn, []) do
       conn
@@ -317,6 +317,14 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubController do
     |> represent_service_actor(conn)
   end
 
+  @doc "Returns the authenticated user's ActivityPub User object or a 404 Not Found if non-authenticated"
+  def whoami(%{assigns: %{user: %User{} = user}} = conn, _params) do
+    conn
+    |> put_resp_content_type("application/activity+json")
+    |> put_view(UserView)
+    |> render("user.json", %{user: user})
+  end
+
   def read_inbox(
         %{assigns: %{user: %User{nickname: nickname} = user}} = conn,
         %{"nickname" => nickname, "page" => page?} = params
@@ -367,6 +375,105 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubController do
     |> json(err)
   end
 
+  defp fix_user_message(%User{ap_id: actor}, %{"type" => "Create", "object" => object} = activity)
+       when is_map(object) do
+    length =
+      [object["content"], object["summary"], object["name"]]
+      |> Enum.filter(&is_binary(&1))
+      |> Enum.join("")
+      |> String.length()
+
+    limit = Pleroma.Config.get([:instance, :limit])
+
+    if length < limit do
+      object =
+        object
+        |> Transmogrifier.strip_internal_fields()
+        |> Map.put("attributedTo", actor)
+        |> Map.put("actor", actor)
+        |> Map.put("id", Utils.generate_object_id())
+
+      {:ok, Map.put(activity, "object", object)}
+    else
+      {:error,
+       dgettext(
+         "errors",
+         "Character limit (%{limit} characters) exceeded, contains %{length} characters",
+         limit: limit,
+         length: length
+       )}
+    end
+  end
+
+  defp fix_user_message(
+         %User{ap_id: actor} = user,
+         %{"type" => "Delete", "object" => object} = activity
+       ) do
+    with {_, %Object{data: object_data}} <- {:normalize, Object.normalize(object, fetch: false)},
+         {_, true} <- {:permission, user.is_moderator || actor == object_data["actor"]} do
+      {:ok, activity}
+    else
+      {:normalize, _} ->
+        {:error, "No such object found"}
+
+      {:permission, _} ->
+        {:forbidden, "You can't delete this object"}
+    end
+  end
+
+  defp fix_user_message(%User{}, activity) do
+    {:ok, activity}
+  end
+
+  def update_outbox(
+        %{assigns: %{user: %User{nickname: nickname, ap_id: actor} = user}} = conn,
+        %{"nickname" => nickname} = params
+      ) do
+    params =
+      params
+      |> Map.drop(["nickname"])
+      |> Map.put("id", Utils.generate_activity_id())
+      |> Map.put("actor", actor)
+
+    with {:ok, params} <- fix_user_message(user, params),
+         {:ok, activity, _} <- Pipeline.common_pipeline(params, local: true),
+         %Activity{data: activity_data} <- Activity.normalize(activity) do
+      conn
+      |> put_status(:created)
+      |> put_resp_header("location", activity_data["id"])
+      |> json(activity_data)
+    else
+      {:forbidden, message} ->
+        conn
+        |> put_status(:forbidden)
+        |> json(message)
+
+      {:error, message} ->
+        conn
+        |> put_status(:bad_request)
+        |> json(message)
+
+      e ->
+        Logger.warning(fn -> "AP C2S: #{inspect(e)}" end)
+
+        conn
+        |> put_status(:bad_request)
+        |> json("Bad Request")
+    end
+  end
+
+  def update_outbox(%{assigns: %{user: %User{} = user}} = conn, %{"nickname" => nickname}) do
+    err =
+      dgettext("errors", "can't update outbox of %{nickname} as %{as_nickname}",
+        nickname: nickname,
+        as_nickname: user.nickname
+      )
+
+    conn
+    |> put_status(:forbidden)
+    |> json(err)
+  end
+
   defp errors(conn, {:error, :not_found}) do
     conn
     |> put_status(:not_found)
@@ -388,6 +495,21 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubController do
     conn
   end
 
+  def upload_media(%{assigns: %{user: %User{} = user}} = conn, %{"file" => file} = data) do
+    with {:ok, object} <-
+           ActivityPub.upload(
+             file,
+             actor: User.ap_id(user),
+             description: Map.get(data, "description")
+           ) do
+      Logger.debug(inspect(object))
+
+      conn
+      |> put_status(:created)
+      |> json(object.data)
+    end
+  end
+
   def pinned(conn, %{"nickname" => nickname}) do
     with %User{} = user <- User.get_cached_by_nickname(nickname) do
       conn

lib/pleroma/web/activity_pub/mrf/inline_quote_policy.ex

@@ -6,29 +6,14 @@ defmodule Pleroma.Web.ActivityPub.MRF.InlineQuotePolicy do
   @moduledoc "Force a quote line into the message content."
   @behaviour Pleroma.Web.ActivityPub.MRF.Policy
 
-  alias Pleroma.Object
-
   defp build_inline_quote(prefix, url) do
     "<span class=\"quote-inline\"><br/><br/>#{prefix}: <a href=\"#{url}\">#{url}</a></span>"
   end
 
-  defp resolve_urls(quote_url) do
-    # Fetching here can cause infinite recursion as we run this logic on inbound objects too
-    # This is probably not a problem - its an exceptional corner case for a local user to quote
-    # a post which doesn't exist
-    with %Object{} = obj <- Object.normalize(quote_url, fetch: false) do
-      id = obj.data["id"]
-      url = Map.get(obj.data, "url", id)
-      {id, url, [id, url, quote_url]}
-    else
-      _ -> {quote_url, quote_url, [quote_url]}
-    end
-  end
-
-  defp has_inline_quote?(content, urls) do
+  defp has_inline_quote?(content, quote_url) do
     cond do
       # Does the quote URL exist in the content?
-      Enum.any?(urls, fn url -> content =~ url end) -> true
+      content =~ quote_url -> true
       # Does the content already have a .quote-inline span?
       content =~ "<span class=\"quote-inline\">" -> true
       # No inline quote found
@@ -37,22 +22,18 @@ defmodule Pleroma.Web.ActivityPub.MRF.InlineQuotePolicy do
   end
 
   defp filter_object(%{"quoteUri" => quote_url} = object) do
-    {id, preferred_url, all_urls} = resolve_urls(quote_url)
-    object = Map.put(object, "quoteUri", id)
-
     content = object["content"] || ""
 
-    if has_inline_quote?(content, all_urls) do
+    if has_inline_quote?(content, quote_url) do
       object
     else
       prefix = Pleroma.Config.get([:mrf_inline_quote, :prefix])
 
       content =
         if String.ends_with?(content, "</p>") do
-          String.trim_trailing(content, "</p>") <>
-            build_inline_quote(prefix, preferred_url) <> "</p>"
+          String.trim_trailing(content, "</p>") <> build_inline_quote(prefix, quote_url) <> "</p>"
         else
-          content <> build_inline_quote(prefix, preferred_url)
+          content <> build_inline_quote(prefix, quote_url)
         end
 
       Map.put(object, "content", content)

lib/pleroma/web/activity_pub/mrf/simple_policy.ex

@@ -178,23 +178,6 @@ defmodule Pleroma.Web.ActivityPub.MRF.SimplePolicy do
 
   defp check_banner_removal(_actor_info, object), do: {:ok, object}
 
-  defp check_background_removal(
-         %{host: actor_host} = _actor_info,
-         %{"backgroundUrl" => _bg} = object
-       ) do
-    background_removal =
-      instance_list(:background_removal)
-      |> MRF.subdomains_regex()
-
-    if MRF.subdomain_match?(background_removal, actor_host) do
-      {:ok, Map.delete(object, "backgroundUrl")}
-    else
-      {:ok, object}
-    end
-  end
-
-  defp check_background_removal(_actor_info, object), do: {:ok, object}
-
   defp extract_context_uri(%{"conversation" => "tag:" <> rest}) do
     rest
     |> String.split(",", parts: 2, trim: true)
@@ -300,8 +283,7 @@ defmodule Pleroma.Web.ActivityPub.MRF.SimplePolicy do
     with {:ok, _} <- check_accept(actor_info),
          {:ok, _} <- check_reject(actor_info),
          {:ok, object} <- check_avatar_removal(actor_info, object),
-         {:ok, object} <- check_banner_removal(actor_info, object),
-         {:ok, object} <- check_background_removal(actor_info, object) do
+         {:ok, object} <- check_banner_removal(actor_info, object) do
       {:ok, object}
     else
       {:reject, nil} -> {:reject, "[SimplePolicy]"}
@@ -332,20 +314,6 @@ defmodule Pleroma.Web.ActivityPub.MRF.SimplePolicy do
   def filter(object), do: {:ok, object}
 
   defp obfuscate(string) when is_binary(string) do
-    # Want to strip at least two neighbouring chars
-    # to ensure at least one non-dot char is in the obfuscation area
-    stripped = String.length(string) - 6
-
-    {keepstart, keepend} =
-      if stripped > 1 do
-        {3, 3}
-      else
-        {
-          2 - div(1 - stripped, 2),
-          2 + div(stripped, 2)
-        }
-      end
-
     string
     |> to_charlist()
     |> Enum.with_index()
@@ -354,7 +322,7 @@ defmodule Pleroma.Web.ActivityPub.MRF.SimplePolicy do
         ?.
 
       {char, index} ->
-        if keepstart <= index && index < String.length(string) - keepend, do: ?*, else: char
+        if 3 <= index && index < String.length(string) - 3, do: ?*, else: char
     end)
     |> to_string()
   end
@@ -465,11 +433,6 @@ defmodule Pleroma.Web.ActivityPub.MRF.SimplePolicy do
              key: :banner_removal,
              description: "List of instances to strip banners from and the reason for doing so"
            },
-           %{
-             key: :background_removal,
-             description:
-               "List of instances to strip user backgrounds from and the reason for doing so"
-           },
            %{
              key: :reject_deletes,
              description: "List of instances to reject deletions from and the reason for doing so"

lib/pleroma/web/activity_pub/mrf/steal_emoji_policy.ex

@@ -6,54 +6,10 @@ defmodule Pleroma.Web.ActivityPub.MRF.StealEmojiPolicy do
   require Logger
 
   alias Pleroma.Config
-  alias Pleroma.Emoji.Pack
 
   @moduledoc "Detect new emojis by their shortcode and steals them"
   @behaviour Pleroma.Web.ActivityPub.MRF.Policy
 
-  @pack_name "stolen"
-
-  # Config defaults
-  @size_limit 50_000
-  @download_unknown_size false
-
-  defp create_pack() do
-    with {:ok, pack} = Pack.create(@pack_name) do
-      Pack.save_metadata(
-        %{
-          "description" => "Collection of emoji auto-stolen from other instances",
-          "homepage" => Pleroma.Web.Endpoint.url(),
-          "can-download" => false,
-          "share-files" => false
-        },
-        pack
-      )
-    end
-  end
-
-  defp load_or_create_pack() do
-    case Pack.load_pack(@pack_name) do
-      {:ok, pack} -> {:ok, pack}
-      {:error, :enoent} -> create_pack()
-      e -> e
-    end
-  end
-
-  defp add_emoji(shortcode, extension, filedata) do
-    {:ok, pack} = load_or_create_pack()
-    # Make final path infeasible to predict to thwart certain kinds of attacks
-    # (48 bits is slighty more than 8 base62 chars, thus 9 chars)
-    salt =
-      :crypto.strong_rand_bytes(6)
-      |> :crypto.bytes_to_integer()
-      |> Base62.encode()
-      |> String.pad_leading(9, "0")
-
-    filename = shortcode <> "-" <> salt <> "." <> extension
-
-    Pack.add_file(pack, shortcode, filename, filedata)
-  end
-
   defp accept_host?(host), do: host in Config.get([:mrf_steal_emoji, :hosts], [])
 
   defp shortcode_matches?(shortcode, pattern) when is_binary(pattern) do
@@ -64,69 +20,30 @@ defmodule Pleroma.Web.ActivityPub.MRF.StealEmojiPolicy do
     String.match?(shortcode, pattern)
   end
 
-  defp reject_emoji?({shortcode, _url}, installed_emoji) do
-    valid_shortcode? = String.match?(shortcode, ~r/^[a-zA-Z0-9_-]+$/)
-
-    rejected_shortcode? =
-      [:mrf_steal_emoji, :rejected_shortcodes]
-      |> Config.get([])
-      |> Enum.any?(fn pattern -> shortcode_matches?(shortcode, pattern) end)
-
-    emoji_installed? = Enum.member?(installed_emoji, shortcode)
-
-    !valid_shortcode? or rejected_shortcode? or emoji_installed?
-  end
-
-  defp steal_emoji(%{} = response, {shortcode, extension}) do
-    case add_emoji(shortcode, extension, response.body) do
-      {:ok, _} ->
-        shortcode
-
-      e ->
-        Logger.warning(
-          "MRF.StealEmojiPolicy: Failed to add #{shortcode} as #{extension}: #{inspect(e)}"
-        )
-
-        nil
-    end
-  end
-
-  defp get_extension_if_safe(response) do
-    content_type =
-      :proplists.get_value("content-type", response.headers, MIME.from_path(response.url))
-
-    case content_type do
-      "image/" <> _ -> List.first(MIME.extensions(content_type))
-      _ -> nil
-    end
-  end
-
-  defp is_remote_size_within_limit?(url) do
-    with {:ok, %{status: status, headers: headers} = _response} when status in 200..299 <-
-           Pleroma.HTTP.request(:head, url, nil, [], []) do
-      content_length = :proplists.get_value("content-length", headers, nil)
-      size_limit = Config.get([:mrf_steal_emoji, :size_limit], @size_limit)
-
-      accept_unknown =
-        Config.get([:mrf_steal_emoji, :download_unknown_size], @download_unknown_size)
-
-      content_length <= size_limit or
-        (content_length == nil and accept_unknown)
-    else
-      _ -> false
-    end
-  end
-
-  defp maybe_steal_emoji({shortcode, url}) do
+  defp steal_emoji({shortcode, url}, emoji_dir_path) do
     url = Pleroma.Web.MediaProxy.url(url)
 
-    with {:remote_size, true} <- {:remote_size, is_remote_size_within_limit?(url)},
-         {:ok, %{status: status} = response} when status in 200..299 <- Pleroma.HTTP.get(url) do
-      size_limit = Config.get([:mrf_steal_emoji, :size_limit], @size_limit)
-      extension = get_extension_if_safe(response)
+    with {:ok, %{status: status} = response} when status in 200..299 <- Pleroma.HTTP.get(url) do
+      size_limit = Config.get([:mrf_steal_emoji, :size_limit], 50_000)
 
-      if byte_size(response.body) <= size_limit and extension do
-        steal_emoji(response, {shortcode, extension})
+      if byte_size(response.body) <= size_limit do
+        extension =
+          url
+          |> URI.parse()
+          |> Map.get(:path)
+          |> Path.basename()
+          |> Path.extname()
+
+        file_path = Path.join(emoji_dir_path, shortcode <> (extension || ".png"))
+
+        case File.write(file_path, response.body) do
+          :ok ->
+            shortcode
+
+          e ->
+            Logger.warning("MRF.StealEmojiPolicy: Failed to write to #{file_path}: #{inspect(e)}")
+            nil
+        end
       else
         Logger.debug(
           "MRF.StealEmojiPolicy: :#{shortcode}: at #{url} (#{byte_size(response.body)} B) over size limit (#{size_limit} B)"
@@ -148,10 +65,26 @@ defmodule Pleroma.Web.ActivityPub.MRF.StealEmojiPolicy do
     if host != Pleroma.Web.Endpoint.host() and accept_host?(host) do
       installed_emoji = Pleroma.Emoji.get_all() |> Enum.map(fn {k, _} -> k end)
 
+      emoji_dir_path =
+        Config.get(
+          [:mrf_steal_emoji, :path],
+          Path.join(Config.get([:instance, :static_dir]), "emoji/stolen")
+        )
+
+      File.mkdir_p(emoji_dir_path)
+
       new_emojis =
         foreign_emojis
-        |> Enum.reject(&reject_emoji?(&1, installed_emoji))
-        |> Enum.map(&maybe_steal_emoji(&1))
+        |> Enum.reject(fn {shortcode, _url} -> shortcode in installed_emoji end)
+        |> Enum.filter(fn {shortcode, _url} ->
+          reject_emoji? =
+            [:mrf_steal_emoji, :rejected_shortcodes]
+            |> Config.get([])
+            |> Enum.find(false, fn pattern -> shortcode_matches?(shortcode, pattern) end)
+
+          !reject_emoji?
+        end)
+        |> Enum.map(&steal_emoji(&1, emoji_dir_path))
         |> Enum.filter(& &1)
 
       if !Enum.empty?(new_emojis) do

lib/pleroma/web/activity_pub/object_validators/article_note_page_validator.ex

@@ -53,13 +53,6 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.ArticleNotePageValidator do
 
   defp fix_url(%{"url" => url} = data) when is_bitstring(url), do: data
   defp fix_url(%{"url" => url} = data) when is_map(url), do: Map.put(data, "url", url["href"])
-
-  defp fix_url(%{"url" => url} = data) when is_list(url) do
-    data
-    |> Map.put("url", List.first(url))
-    |> fix_url()
-  end
-
   defp fix_url(data), do: data
 
   defp fix_tag(%{"tag" => tag} = data) when is_list(tag) do

lib/pleroma/web/activity_pub/object_validators/emoji_react_validator.ex

@@ -8,7 +8,6 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.EmojiReactValidator do
   alias Pleroma.Emoji
   alias Pleroma.Object
   alias Pleroma.Web.ActivityPub.ObjectValidators.CommonFixes
-  alias Pleroma.Web.ActivityPub.Transmogrifier
 
   import Ecto.Changeset
   import Pleroma.Web.ActivityPub.ObjectValidators.CommonValidations
@@ -53,7 +52,6 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.EmojiReactValidator do
   defp fix(data) do
     data =
       data
-      |> Transmogrifier.fix_tag()
       |> fix_emoji_qualification()
       |> CommonFixes.fix_actor()
       |> CommonFixes.fix_activity_addressing()

lib/pleroma/web/activity_pub/object_validators/user_validator.ex

@@ -1,94 +0,0 @@
-# Akkoma: Magically expressive social media
-# Copyright © 2024 Akkoma Authors <https://akkoma.dev/>
-# SPDX-License-Identifier: AGPL-3.0-only
-
-defmodule Pleroma.Web.ActivityPub.ObjectValidators.UserValidator do
-  @moduledoc """
-  Checks whether ActivityPub data represents a valid user
-
-  Users don't go through the same ingest pipeline like activities or other objects.
-  To ensure this can only match a user and no users match in the other pipeline,
-  this is a separate from the generic ObjectValidator.
-  """
-
-  @behaviour Pleroma.Web.ActivityPub.ObjectValidator.Validating
-
-  alias Pleroma.Object.Containment
-  alias Pleroma.Signature
-
-  require Pleroma.Constants
-
-  @impl true
-  def validate(object, meta)
-
-  def validate(%{"type" => type, "id" => _id} = data, meta)
-      when type in Pleroma.Constants.actor_types() do
-    with :ok <- validate_pubkey(data),
-         :ok <- validate_inbox(data),
-         :ok <- contain_collection_origin(data) do
-      {:ok, data, meta}
-    else
-      {:error, e} -> {:error, e}
-      e -> {:error, e}
-    end
-  end
-
-  def validate(_, _), do: {:error, "Not a user object"}
-
-  defp mabye_validate_owner(nil, _actor), do: :ok
-  defp mabye_validate_owner(actor, actor), do: :ok
-  defp mabye_validate_owner(_owner, _actor), do: :error
-
-  defp validate_pubkey(
-         %{"id" => id, "publicKey" => %{"id" => pk_id, "publicKeyPem" => _key}} = data
-       )
-       when id != nil do
-    with {_, {:ok, kactor}} <- {:key, Signature.key_id_to_actor_id(pk_id)},
-         true <- id == kactor,
-         :ok <- mabye_validate_owner(Map.get(data, "owner"), id) do
-      :ok
-    else
-      {:key, _} ->
-        {:error, "Unable to determine actor id from key id"}
-
-      false ->
-        {:error, "Key id does not relate to user id"}
-
-      _ ->
-        {:error, "Actor does not own its public key"}
-    end
-  end
-
-  # pubkey is optional atm
-  defp validate_pubkey(_data), do: :ok
-
-  defp validate_inbox(%{"id" => id, "inbox" => inbox}) do
-    case Containment.same_origin(id, inbox) do
-      :ok -> :ok
-      :error -> {:error, "Inbox on different doamin"}
-    end
-  end
-
-  defp validate_inbox(_), do: {:error, "No inbox"}
-
-  defp check_field_value(%{"id" => id} = _data, value) do
-    Containment.same_origin(id, value)
-  end
-
-  defp maybe_check_field(data, field) do
-    with val when val != nil <- data[field],
-         :ok <- check_field_value(data, val) do
-      :ok
-    else
-      nil -> :ok
-      _ -> {:error, "#{field} on different domain"}
-    end
-  end
-
-  defp contain_collection_origin(data) do
-    Enum.reduce(["followers", "following", "featured"], :ok, fn
-      field, :ok -> maybe_check_field(data, field)
-      _, error -> error
-    end)
-  end
-end

lib/pleroma/web/activity_pub/side_effects.ex

@@ -109,7 +109,7 @@ defmodule Pleroma.Web.ActivityPub.SideEffects do
          %User{} = followed <- User.get_cached_by_ap_id(followed_user),
          {_, {:ok, _, _}, _, _} <-
            {:following, User.follow(follower, followed, :follow_pending), follower, followed} do
-      if followed.local && User.can_direct_follow_local(follower, followed) do
+      if followed.local && !followed.is_locked do
         {:ok, accept_data, _} = Builder.accept(followed, object)
         {:ok, _activity, _} = Pipeline.common_pipeline(accept_data, local: true)
       end

lib/pleroma/web/activity_pub/transmogrifier.ex

@@ -25,8 +25,8 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
 
   import Ecto.Query
 
-  require Pleroma.Constants
   require Logger
+  require Pleroma.Constants
 
   @doc """
   Modifies an incoming AP object (mastodon format) to our internal format.
@@ -58,48 +58,21 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
 
   def fix_summary(object), do: Map.put(object, "summary", "")
 
-  defp fix_addressing_list(addrs) do
+  def fix_addressing_list(map, field) do
+    addrs = map[field]
+
     cond do
-      is_list(addrs) -> Enum.filter(addrs, &is_binary/1)
-      is_binary(addrs) -> [addrs]
-      true -> []
+      is_list(addrs) ->
+        Map.put(map, field, Enum.filter(addrs, &is_binary/1))
+
+      is_binary(addrs) ->
+        Map.put(map, field, [addrs])
+
+      true ->
+        Map.put(map, field, [])
     end
   end
 
-  # Due to JSON-LD simply "Public" and "as:Public" are equivalent to the full URI
-  # but to simplify later checks we only want to deal with one reperesentation internally
-  defp normalise_addressing_public_list(map, all_fields)
-
-  defp normalise_addressing_public_list(%{} = map, [field | fields]) do
-    full_uri = Pleroma.Constants.as_public()
-
-    map =
-      if map[field] != nil do
-        new_fval =
-          map[field]
-          |> fix_addressing_list()
-          |> Enum.map(fn
-            "Public" -> full_uri
-            "as:Public" -> full_uri
-            x -> x
-          end)
-
-        Map.put(map, field, new_fval)
-      else
-        map
-      end
-
-    normalise_addressing_public_list(map, fields)
-  end
-
-  defp normalise_addressing_public_list(map, _) do
-    map
-  end
-
-  defp normalise_addressing_public(map) do
-    normalise_addressing_public_list(map, ["to", "cc", "bto", "bcc"])
-  end
-
   # if directMessage flag is set to true, leave the addressing alone
   def fix_explicit_addressing(%{"directMessage" => true} = object, _follower_collection),
     do: object
@@ -123,10 +96,6 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     |> Map.put("cc", final_cc)
   end
 
-  def fix_addressing_list_key(map, field) do
-    Map.put(map, field, fix_addressing_list(map[field]))
-  end
-
   def fix_addressing(object) do
     {:ok, %User{follower_address: follower_collection}} =
       object
@@ -134,10 +103,10 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
       |> User.get_or_fetch_by_ap_id()
 
     object
-    |> fix_addressing_list_key("to")
-    |> fix_addressing_list_key("cc")
-    |> fix_addressing_list_key("bto")
-    |> fix_addressing_list_key("bcc")
+    |> fix_addressing_list("to")
+    |> fix_addressing_list("cc")
+    |> fix_addressing_list("bto")
+    |> fix_addressing_list("bcc")
     |> fix_explicit_addressing(follower_collection)
     |> CommonFixes.fix_implicit_addressing(follower_collection)
   end
@@ -166,7 +135,8 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
         |> Map.put("context", replied_object.data["context"] || object["conversation"])
         |> Map.drop(["conversation", "inReplyToAtomUri"])
       else
-        _ ->
+        e ->
+          Logger.warning("Couldn't fetch reply@#{inspect(in_reply_to_id)}, error: #{inspect(e)}")
           object
       end
     else
@@ -414,28 +384,11 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end)
   end
 
-  def handle_incoming(data, options \\ []) do
-    data = normalise_addressing_public(data)
-
-    data =
-      if data["object"] != nil do
-        object = normalise_addressing_public(data["object"])
-        Map.put(data, "object", object)
-      else
-        data
-      end
-
-    handle_incoming_normalised(data, options)
-  end
-
-  defp handle_incoming_normalised(data, options)
+  def handle_incoming(data, options \\ [])
 
   # Flag objects are placed ahead of the ID check because Mastodon 2.8 and earlier send them
   # with nil ID.
-  defp handle_incoming_normalised(
-         %{"type" => "Flag", "object" => objects, "actor" => actor} = data,
-         _options
-       ) do
+  def handle_incoming(%{"type" => "Flag", "object" => objects, "actor" => actor} = data, _options) do
     with context <- data["context"] || Utils.generate_context_id(),
          content <- data["content"] || "",
          %User{} = actor <- User.get_cached_by_ap_id(actor),
@@ -456,21 +409,20 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
   end
 
   # disallow objects with bogus IDs
-  defp handle_incoming_normalised(%{"id" => nil}, _options), do: :error
-  defp handle_incoming_normalised(%{"id" => ""}, _options), do: :error
+  def handle_incoming(%{"id" => nil}, _options), do: :error
+  def handle_incoming(%{"id" => ""}, _options), do: :error
   # length of https:// = 8, should validate better, but good enough for now.
-  defp handle_incoming_normalised(%{"id" => id}, _options)
-       when is_binary(id) and byte_size(id) < 8,
-       do: :error
+  def handle_incoming(%{"id" => id}, _options) when is_binary(id) and byte_size(id) < 8,
+    do: :error
 
-  # Rewrite misskey likes into EmojiReacts
-  defp handle_incoming_normalised(
-         %{
-           "type" => "Like",
-           "content" => reaction
-         } = data,
-         options
-       ) do
+  @doc "Rewrite misskey likes into EmojiReacts"
+  def handle_incoming(
+        %{
+          "type" => "Like",
+          "content" => reaction
+        } = data,
+        options
+      ) do
     if Pleroma.Emoji.is_unicode_emoji?(reaction) || Pleroma.Emoji.matches_shortcode?(reaction) do
       data
       |> Map.put("type", "EmojiReact")
@@ -482,11 +434,11 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  defp handle_incoming_normalised(
-         %{"type" => "Create", "object" => %{"type" => objtype, "id" => obj_id}} = data,
-         options
-       )
-       when objtype in ~w{Question Answer Audio Video Event Article Note Page} do
+  def handle_incoming(
+        %{"type" => "Create", "object" => %{"type" => objtype, "id" => obj_id}} = data,
+        options
+      )
+      when objtype in ~w{Question Answer Audio Video Event Article Note Page} do
     fetch_options = Keyword.put(options, :depth, (options[:depth] || 0) + 1)
 
     object =
@@ -518,8 +470,8 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  defp handle_incoming_normalised(%{"type" => type} = data, _options)
-       when type in ~w{Like EmojiReact Announce Add Remove} do
+  def handle_incoming(%{"type" => type} = data, _options)
+      when type in ~w{Like EmojiReact Announce Add Remove} do
     with :ok <- ObjectValidator.fetch_actor_and_object(data),
          {:ok, activity, _meta} <- Pipeline.common_pipeline(data, local: false) do
       {:ok, activity}
@@ -529,11 +481,11 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  defp handle_incoming_normalised(
-         %{"type" => type} = data,
-         _options
-       )
-       when type in ~w{Update Block Follow Accept Reject} do
+  def handle_incoming(
+        %{"type" => type} = data,
+        _options
+      )
+      when type in ~w{Update Block Follow Accept Reject} do
     with {:ok, %User{}} <- ObjectValidator.fetch_actor(data),
          {:ok, activity, _} <-
            Pipeline.common_pipeline(data, local: false) do
@@ -541,10 +493,10 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  defp handle_incoming_normalised(
-         %{"type" => "Delete"} = data,
-         _options
-       ) do
+  def handle_incoming(
+        %{"type" => "Delete"} = data,
+        _options
+      ) do
     with {:ok, activity, _} <-
            Pipeline.common_pipeline(data, local: false) do
       {:ok, activity}
@@ -564,15 +516,15 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  defp handle_incoming_normalised(
-         %{
-           "type" => "Undo",
-           "object" => %{"type" => "Follow", "object" => followed},
-           "actor" => follower,
-           "id" => id
-         } = _data,
-         _options
-       ) do
+  def handle_incoming(
+        %{
+          "type" => "Undo",
+          "object" => %{"type" => "Follow", "object" => followed},
+          "actor" => follower,
+          "id" => id
+        } = _data,
+        _options
+      ) do
     with %User{local: true} = followed <- User.get_cached_by_ap_id(followed),
          {:ok, %User{} = follower} <- User.get_or_fetch_by_ap_id(follower),
          {:ok, activity} <- ActivityPub.unfollow(follower, followed, id, false) do
@@ -583,28 +535,28 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  defp handle_incoming_normalised(
-         %{
-           "type" => "Undo",
-           "object" => %{"type" => type}
-         } = data,
-         _options
-       )
-       when type in ["Like", "EmojiReact", "Announce", "Block"] do
+  def handle_incoming(
+        %{
+          "type" => "Undo",
+          "object" => %{"type" => type}
+        } = data,
+        _options
+      )
+      when type in ["Like", "EmojiReact", "Announce", "Block"] do
     with {:ok, activity, _} <- Pipeline.common_pipeline(data, local: false) do
       {:ok, activity}
     end
   end
 
   # For Undos that don't have the complete object attached, try to find it in our database.
-  defp handle_incoming_normalised(
-         %{
-           "type" => "Undo",
-           "object" => object
-         } = activity,
-         options
-       )
-       when is_binary(object) do
+  def handle_incoming(
+        %{
+          "type" => "Undo",
+          "object" => object
+        } = activity,
+        options
+      )
+      when is_binary(object) do
     with %Activity{data: data} <- Activity.get_by_ap_id(object) do
       activity
       |> Map.put("object", data)
@@ -614,22 +566,17 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  defp handle_incoming_normalised(
-         %{
-           "type" => "Move",
-           "actor" => origin_actor,
-           "object" => origin_actor,
-           "target" => target_actor
-         },
-         _options
-       ) do
+  def handle_incoming(
+        %{
+          "type" => "Move",
+          "actor" => origin_actor,
+          "object" => origin_actor,
+          "target" => target_actor
+        },
+        _options
+      ) do
     with %User{} = origin_user <- User.get_cached_by_ap_id(origin_actor),
-         # Use a dramatically shortened maximum age before refresh here because it is reasonable
-         # for a user to
-         # 1. Add the alias to their new account and then
-         # 2. Press the button on their new account
-         # within a very short period of time and expect it to work
-         {:ok, %User{} = target_user} <- User.get_or_fetch_by_ap_id(target_actor, maximum_age: 5),
+         {:ok, %User{} = target_user} <- User.get_or_fetch_by_ap_id(target_actor),
          true <- origin_actor in target_user.also_known_as do
       ActivityPub.move(origin_user, target_user, false)
     else
@@ -637,7 +584,7 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  defp handle_incoming_normalised(_, _), do: :error
+  def handle_incoming(_, _), do: :error
 
   @spec get_obj_helper(String.t(), Keyword.t()) :: {:ok, Object.t()} | nil
   def get_obj_helper(id, options \\ []) do
@@ -881,7 +828,8 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
            relative_object do
       Map.put(data, "object", external_url)
     else
-      {:fetch, _} ->
+      {:fetch, e} ->
+        Logger.error("Couldn't fetch fixed_object@#{object} #{inspect(e)}")
         data
 
       _ ->

lib/pleroma/web/activity_pub/views/user_view.ex

@@ -26,7 +26,8 @@ defmodule Pleroma.Web.ActivityPub.UserView do
       "oauthAuthorizationEndpoint" => url(~p"/oauth/authorize"),
       "oauthRegistrationEndpoint" => url(~p"/api/v1/apps"),
       "oauthTokenEndpoint" => url(~p"/oauth/token"),
-      "sharedInbox" => url(~p"/inbox")
+      "sharedInbox" => url(~p"/inbox"),
+      "uploadMedia" => url(~p"/api/ap/upload_media")
     }
   end
 
@@ -111,8 +112,6 @@ defmodule Pleroma.Web.ActivityPub.UserView do
     }
     |> Map.merge(maybe_make_image(&User.avatar_url/2, "icon", user))
     |> Map.merge(maybe_make_image(&User.banner_url/2, "image", user))
-    # Yes, the key is named ...Url eventhough it is a whole 'Image' object
-    |> Map.merge(maybe_insert_image("backgroundUrl", User.background_url(user)))
     |> Map.merge(Utils.make_json_ld_header())
   end
 
@@ -288,12 +287,7 @@ defmodule Pleroma.Web.ActivityPub.UserView do
   end
 
   defp maybe_make_image(func, key, user) do
-    image = func.(user, no_default: true)
-    maybe_insert_image(key, image)
-  end
-
-  defp maybe_insert_image(key, image) do
-    if image do
+    if image = func.(user, no_default: true) do
       %{
         key => %{
           "type" => "Image",

lib/pleroma/web/api_spec/operations/account_operation.ex

@@ -723,12 +723,6 @@ defmodule Pleroma.Web.ApiSpec.AccountOperation do
           description:
             "Number of days after which statuses will be deleted. Set to -1 to disable."
         },
-        permit_followback: %Schema{
-          allOf: [BooleanLike],
-          nullable: true,
-          description:
-            "Whether follow requests from accounts the user is already following are auto-approved (when locked)."
-        },
         accepts_direct_messages_from: %Schema{
           type: :string,
           enum: [
@@ -760,7 +754,6 @@ defmodule Pleroma.Web.ApiSpec.AccountOperation do
         discoverable: false,
         actor_type: "Person",
         status_ttl_days: 30,
-        permit_followback: true,
         accepts_direct_messages_from: "everybody"
       }
     }

lib/pleroma/web/api_spec/operations/frontend_settings_operation.ex

@@ -111,9 +111,9 @@ defmodule Pleroma.Web.ApiSpec.FrontendSettingsOperation do
   def update_preferred_frontend_operation() do
     %Operation{
       tags: ["Frontends"],
-      summary: "Update preferred frontend setting",
-      description: "Store preferred frontend in cookies",
-      operationId: "AkkomaAPI.FrontendSettingsController.update_preferred_frontend",
+      summary: "Frontend Settings Profiles",
+      description: "List frontend setting profiles",
+      operationId: "AkkomaAPI.FrontendSettingsController.available_frontends",
       requestBody:
         request_body(
           "Frontend",
@@ -132,11 +132,9 @@ defmodule Pleroma.Web.ApiSpec.FrontendSettingsOperation do
       responses: %{
         200 =>
           Operation.response("Frontends", "application/json", %Schema{
-            type: :object,
-            properties: %{
-              frontend_name: %Schema{
-                type: :string
-              }
+            type: :array,
+            items: %Schema{
+              type: :string
             }
           })
       }

lib/pleroma/web/api_spec/operations/instance_operation.ex

@@ -137,7 +137,7 @@ defmodule Pleroma.Web.ApiSpec.InstanceOperation do
         "background_upload_limit" => 4_000_000,
         "background_image" => "/static/image.png",
         "banner_upload_limit" => 4_000_000,
-        "description" => "Akkoma: The cooler fediverse server",
+        "description" => "Pleroma: An efficient and flexible fediverse server",
         "email" => "lain@lain.com",
         "languages" => ["en"],
         "max_toot_chars" => 5000,
@@ -160,7 +160,7 @@ defmodule Pleroma.Web.ApiSpec.InstanceOperation do
         "urls" => %{
           "streaming_api" => "wss://lain.com"
         },
-        "version" => "2.7.2 (compatible; Akkoma 3.9.3-232-g6fde75e1-develop)"
+        "version" => "2.7.2 (compatible; Pleroma 2.0.50-536-g25eec6d7-develop)"
       }
     }
   end

lib/pleroma/web/api_spec/operations/twitter_util_operation.ex

@@ -150,7 +150,7 @@ defmodule Pleroma.Web.ApiSpec.TwitterUtilOperation do
           "removes the contents of a message from the push notification"
         )
       ],
-      requestBody: request_body("Parameters", update_notification_settings_request()),
+      requestBody: nil,
       responses: %{
         200 =>
           Operation.response("Success", "application/json", %Schema{
@@ -432,22 +432,4 @@ defmodule Pleroma.Web.ApiSpec.TwitterUtilOperation do
       }
     }
   end
-
-  defp update_notification_settings_request do
-    %Schema{
-      title: "UpdateNotificationSettings",
-      description: "PUT paramenters (query, form or JSON) for updating notification settings",
-      type: :object,
-      properties: %{
-        block_from_strangers: %Schema{
-          type: :boolean,
-          description: "blocks notifications from accounts you do not follow"
-        },
-        hide_notification_contents: %Schema{
-          type: :boolean,
-          description: "removes the contents of a message from the push notification"
-        }
-      }
-    }
-  end
 end

lib/pleroma/web/api_spec/schemas/account.ex

@@ -112,18 +112,7 @@ defmodule Pleroma.Web.ApiSpec.Schemas.Account do
       akkoma: %Schema{
         type: :object,
         properties: %{
-          instance: %Schema{
-            type: :object,
-            nullable: true,
-            properties: %{
-              name: %Schema{type: :string},
-              favicon: %Schema{type: :string, format: :uri, nullable: true},
-              # XXX: proper nodeinfo schema
-              nodeinfo: %Schema{type: :object, nullable: true}
-            }
-          },
-          status_ttl_days: %Schema{type: :integer, nullable: true},
-          permit_followback: %Schema{type: :boolean}
+          note_ttl_days: %Schema{type: :integer}
         }
       },
       source: %Schema{
@@ -216,18 +205,6 @@ defmodule Pleroma.Web.ApiSpec.Schemas.Account do
           "pleroma-fe" => %{}
         }
       },
-      "akkoma" => %{
-        "instance" => %{
-          "name" => "ihatebeinga.live",
-          "favicon" => "https://ihatebeinga.live/favicon.png",
-          "nodeinfo" =>
-            %{
-              # XXX: nodeinfo schema
-            }
-        },
-        "status_ttl_days" => nil,
-        "permit_followback" => true
-      },
       "source" => %{
         "fields" => [],
         "note" => "foobar",

lib/pleroma/web/endpoint.ex

@@ -98,10 +98,6 @@ defmodule Pleroma.Web.Endpoint do
     at: "/",
     from: :pleroma,
     only: Pleroma.Web.static_paths(),
-    # JSON-LD is accepted by some servers for AP objects and activities,
-    # thus only enable it here instead of a global extension mapping
-    # (it's our only *.jsonld file anyway)
-    content_types: %{"litepub-0.1.jsonld" => "application/ld+json"},
     # credo:disable-for-previous-line Credo.Check.Readability.MaxLineLength
     gzip: true,
     cache_control_for_etags: @static_cache_control,

lib/pleroma/web/feed/feed_view.ex

@@ -78,7 +78,9 @@ defmodule Pleroma.Web.Feed.FeedView do
   end
 
   def activity_content(%{"content" => content}) do
-    escape(content)
+    content
+    |> String.replace(~r/[\n\r]/, "")
+    |> escape()
   end
 
   def activity_content(_), do: ""

lib/pleroma/web/mastodon_api/controllers/account_controller.ex

@@ -222,7 +222,6 @@ defmodule Pleroma.Web.MastodonAPI.AccountController do
       |> Maps.put_if_present(:language, Pleroma.Web.Gettext.normalize_locale(params[:language]))
       |> Maps.put_if_present(:status_ttl_days, params[:status_ttl_days], status_ttl_days_value)
       |> Maps.put_if_present(:accepts_direct_messages_from, params[:accepts_direct_messages_from])
-      |> Maps.put_if_present(:permit_followback, params[:permit_followback])
 
     # What happens here:
     #

lib/pleroma/web/mastodon_api/views/account_view.ex

@@ -261,9 +261,6 @@ defmodule Pleroma.Web.MastodonAPI.AccountView do
         |> MediaProxy.url()
       end
 
-    last_status_at =
-      if is_nil(user.last_status_at), do: nil, else: NaiveDateTime.to_date(user.last_status_at)
-
     %{
       id: to_string(user.id),
       username: username_from_nickname(user.nickname),
@@ -292,11 +289,10 @@ defmodule Pleroma.Web.MastodonAPI.AccountView do
           actor_type: user.actor_type
         }
       },
-      last_status_at: last_status_at,
+      last_status_at: user.last_status_at,
       akkoma: %{
         instance: render("instance.json", %{instance: instance}),
-        status_ttl_days: user.status_ttl_days,
-        permit_followback: user.permit_followback
+        status_ttl_days: user.status_ttl_days
       },
       # Pleroma extensions
       # Note: it's insecure to output :email but fully-qualified nickname may serve as safe stub

lib/pleroma/web/media_proxy.ex

@@ -145,7 +145,7 @@ defmodule Pleroma.Web.MediaProxy do
   end
 
   def base_url do
-    Config.get!([:media_proxy, :base_url])
+    Config.get([:media_proxy, :base_url], Endpoint.url())
   end
 
   defp proxy_url(path, sig_base64, url_base64, filename) do

lib/pleroma/web/metadata/providers/open_graph.ex

@@ -12,38 +12,14 @@ defmodule Pleroma.Web.Metadata.Providers.OpenGraph do
   @behaviour Provider
   @media_types ["image", "audio", "video"]
 
-  defp user_avatar_tags(user) do
-    if Utils.visible?(user) do
-      [
-        {:meta, [property: "og:image", content: MediaProxy.preview_url(User.avatar_url(user))],
-         []},
-        {:meta, [property: "og:image:width", content: 150], []},
-        {:meta, [property: "og:image:height", content: 150], []}
-      ]
-    else
-      []
-    end
-  end
-
   @impl Provider
   def build_tags(%{
         object: object,
         url: url,
         user: user
       }) do
-    attachments =
-      if Utils.visible?(object) do
-        build_attachments(object)
-      else
-        []
-      end
-
-    scrubbed_content =
-      if Utils.visible?(object) do
-        Utils.scrub_html_and_truncate(object)
-      else
-        "Content cannot be displayed."
-      end
+    attachments = build_attachments(object)
+    scrubbed_content = Utils.scrub_html_and_truncate(object)
 
     [
       {:meta,
@@ -60,7 +36,12 @@ defmodule Pleroma.Web.Metadata.Providers.OpenGraph do
       {:meta, [property: "og:type", content: "article"], []}
     ] ++
       if attachments == [] or Metadata.activity_nsfw?(object) do
-        user_avatar_tags(user)
+        [
+          {:meta, [property: "og:image", content: MediaProxy.preview_url(User.avatar_url(user))],
+           []},
+          {:meta, [property: "og:image:width", content: 150], []},
+          {:meta, [property: "og:image:height", content: 150], []}
+        ]
       else
         attachments
       end
@@ -68,9 +49,7 @@ defmodule Pleroma.Web.Metadata.Providers.OpenGraph do
 
   @impl Provider
   def build_tags(%{user: user}) do
-    if Utils.visible?(user) do
-      truncated_bio = Utils.scrub_html_and_truncate(user.bio)
-
+    with truncated_bio = Utils.scrub_html_and_truncate(user.bio) do
       [
         {:meta,
          [
@@ -79,10 +58,12 @@ defmodule Pleroma.Web.Metadata.Providers.OpenGraph do
          ], []},
         {:meta, [property: "og:url", content: user.uri || user.ap_id], []},
         {:meta, [property: "og:description", content: truncated_bio], []},
-        {:meta, [property: "og:type", content: "article"], []}
-      ] ++ user_avatar_tags(user)
-    else
-      []
+        {:meta, [property: "og:type", content: "article"], []},
+        {:meta, [property: "og:image", content: MediaProxy.preview_url(User.avatar_url(user))],
+         []},
+        {:meta, [property: "og:image:width", content: 150], []},
+        {:meta, [property: "og:image:height", content: 150], []}
+      ]
     end
   end
 

lib/pleroma/web/metadata/providers/twitter_card.ex

@@ -17,19 +17,8 @@ defmodule Pleroma.Web.Metadata.Providers.TwitterCard do
 
   @impl Provider
   def build_tags(%{activity_id: id, object: object, user: user}) do
-    attachments =
-      if Utils.visible?(object) do
-        build_attachments(id, object)
-      else
-        []
-      end
-
-    scrubbed_content =
-      if Utils.visible?(object) do
-        Utils.scrub_html_and_truncate(object)
-      else
-        "Content cannot be displayed."
-      end
+    attachments = build_attachments(id, object)
+    scrubbed_content = Utils.scrub_html_and_truncate(object)
 
     [
       title_tag(user),
@@ -47,17 +36,13 @@ defmodule Pleroma.Web.Metadata.Providers.TwitterCard do
 
   @impl Provider
   def build_tags(%{user: user}) do
-    if Utils.visible?(user) do
-      with truncated_bio = Utils.scrub_html_and_truncate(user.bio) do
-        [
-          title_tag(user),
-          {:meta, [name: "twitter:description", content: truncated_bio], []},
-          image_tag(user),
-          {:meta, [name: "twitter:card", content: "summary"], []}
-        ]
-      end
-    else
-      []
+    with truncated_bio = Utils.scrub_html_and_truncate(user.bio) do
+      [
+        title_tag(user),
+        {:meta, [name: "twitter:description", content: truncated_bio], []},
+        image_tag(user),
+        {:meta, [name: "twitter:card", content: "summary"], []}
+      ]
     end
   end
 
@@ -66,11 +51,7 @@ defmodule Pleroma.Web.Metadata.Providers.TwitterCard do
   end
 
   def image_tag(user) do
-    if Utils.visible?(user) do
-      {:meta, [name: "twitter:image", content: MediaProxy.preview_url(User.avatar_url(user))], []}
-    else
-      {:meta, [name: "twitter:image", content: ""], []}
-    end
+    {:meta, [name: "twitter:image", content: MediaProxy.preview_url(User.avatar_url(user))], []}
   end
 
   defp build_attachments(id, %{data: %{"attachment" => attachments}}) do

lib/pleroma/web/metadata/utils.ex

@@ -7,15 +7,6 @@ defmodule Pleroma.Web.Metadata.Utils do
   alias Pleroma.Emoji
   alias Pleroma.Formatter
   alias Pleroma.HTML
-  alias Pleroma.Web.ActivityPub.Visibility
-
-  def visible?(%Pleroma.User{} = object) do
-    Visibility.restrict_unauthenticated_access?(object) == :visible
-  end
-
-  def visible?(object) do
-    Visibility.visible_for_user?(object, nil)
-  end
 
   defp scrub_html_and_truncate_object_field(field, object) do
     field

lib/pleroma/web/o_auth/o_auth_controller.ex

@@ -39,7 +39,6 @@ defmodule Pleroma.Web.OAuth.OAuthController do
   action_fallback(Pleroma.Web.OAuth.FallbackController)
 
   @oob_token_redirect_uri "urn:ietf:wg:oauth:2.0:oob"
-  @state_cookie_name "akkoma_oauth_state"
 
   # Note: this definition is only called from error-handling methods with `conn.params` as 2nd arg
   def authorize(%Plug.Conn{} = conn, %{"authorization" => _} = params) do
@@ -444,10 +443,13 @@ defmodule Pleroma.Web.OAuth.OAuthController do
       |> Map.put("scope", scope)
       |> Jason.encode!()
 
+    params =
+      auth_attrs
+      |> Map.drop(~w(scope scopes client_id redirect_uri))
+      |> Map.put("state", state)
+
     # Handing the request to Ueberauth
-    conn
-    |> put_resp_cookie(@state_cookie_name, state)
-    |> redirect(to: ~p"/oauth/#{provider}")
+    redirect(conn, to: ~p"/oauth/#{provider}?#{params}")
   end
 
   def request(%Plug.Conn{} = conn, params) do
@@ -466,26 +468,20 @@ defmodule Pleroma.Web.OAuth.OAuthController do
   end
 
   def callback(%Plug.Conn{assigns: %{ueberauth_failure: failure}} = conn, params) do
-    params = callback_params(conn, params)
+    params = callback_params(params)
     messages = for e <- Map.get(failure, :errors, []), do: e.message
     message = Enum.join(messages, "; ")
 
-    error_message = dgettext("errors", "Failed to authenticate: %{message}.", message: message)
-
-    if params["redirect_uri"] do
-      conn
-      |> put_flash(
-        :error,
-        error_message
-      )
-      |> redirect(external: redirect_uri(conn, params["redirect_uri"]))
-    else
-      send_resp(conn, :bad_request, error_message)
-    end
+    conn
+    |> put_flash(
+      :error,
+      dgettext("errors", "Failed to authenticate: %{message}.", message: message)
+    )
+    |> redirect(external: redirect_uri(conn, params["redirect_uri"]))
   end
 
   def callback(%Plug.Conn{} = conn, params) do
-    params = callback_params(conn, params)
+    params = callback_params(params)
 
     with {:ok, registration} <- Authenticator.get_registration(conn) do
       auth_attrs = Map.take(params, ~w(client_id redirect_uri scope scopes state))
@@ -515,9 +511,8 @@ defmodule Pleroma.Web.OAuth.OAuthController do
     end
   end
 
-  defp callback_params(%Plug.Conn{} = conn, params) do
-    fetch_cookies(conn)
-    Map.merge(params, Jason.decode!(Map.get(conn.req_cookies, @state_cookie_name, "{}")))
+  defp callback_params(%{"state" => state} = params) do
+    Map.merge(params, Jason.decode!(state))
   end
 
   def registration_details(%Plug.Conn{} = conn, %{"authorization" => auth_attrs}) do

lib/pleroma/web/plugs/instance_static.ex

@@ -3,12 +3,8 @@
 # SPDX-License-Identifier: AGPL-3.0-only
 
 defmodule Pleroma.Web.Plugs.InstanceStatic do
-  import Plug.Conn
-
   require Pleroma.Constants
 
-  alias Pleroma.Web.Plugs.Utils
-
   @moduledoc """
   This is a shim to call `Plug.Static` but with runtime `from` configuration.
 
@@ -47,25 +43,11 @@ defmodule Pleroma.Web.Plugs.InstanceStatic do
     conn
   end
 
-  defp set_static_content_type(conn, "/emoji/" <> _ = request_path) do
-    real_mime = MIME.from_path(request_path)
-    safe_mime = Utils.get_safe_mime_type(%{allowed_mime_types: ["image"]}, real_mime)
-
-    put_resp_header(conn, "content-type", safe_mime)
-  end
-
-  defp set_static_content_type(conn, request_path) do
-    put_resp_header(conn, "content-type", MIME.from_path(request_path))
-  end
-
-  defp call_static(%{request_path: request_path} = conn, opts, from) do
+  defp call_static(conn, opts, from) do
     opts =
       opts
       |> Map.put(:from, from)
-      |> Map.put(:set_content_type, false)
 
-    conn
-    |> set_static_content_type(request_path)
-    |> Pleroma.Web.Plugs.StaticNoCT.call(opts)
+    Plug.Static.call(conn, opts)
   end
 end

lib/pleroma/web/plugs/static_no_content_type.ex

@@ -1,469 +0,0 @@
-# This is almost identical to Plug.Static from Plug 1.15.3 (2024-01-16)
-# It being copied is a temporary measure to fix an urgent bug without
-# needing to wait for merge of a suitable patch upstream
-# The differences are:
-#  - this leading comment
-#  - renaming of the module from 'Plug.Static' to 'Pleroma.Web.Plugs.StaticNoCT'
-#  - additon of set_content_type option
-
-defmodule Pleroma.Web.Plugs.StaticNoCT do
-  @moduledoc """
-  A plug for serving static assets.
-
-  It requires two options:
-
-    * `:at` - the request path to reach for static assets.
-      It must be a string.
-
-    * `:from` - the file system path to read static assets from.
-      It can be either: a string containing a file system path, an
-      atom representing the application name (where assets will
-      be served from `priv/static`), a tuple containing the
-      application name and the directory to serve assets from (besides
-      `priv/static`), or an MFA tuple.
-
-  The preferred form is to use `:from` with an atom or tuple, since
-  it will make your application independent from the starting directory.
-  For example, if you pass:
-
-      plug Plug.Static, from: "priv/app/path"
-
-  Plug.Static will be unable to serve assets if you build releases
-  or if you change the current directory. Instead do:
-
-      plug Plug.Static, from: {:app_name, "priv/app/path"}
-
-  If a static asset cannot be found, `Plug.Static` simply forwards
-  the connection to the rest of the pipeline.
-
-  ## Cache mechanisms
-
-  `Plug.Static` uses etags for HTTP caching. This means browsers/clients
-  should cache assets on the first request and validate the cache on
-  following requests, not downloading the static asset once again if it
-  has not changed. The cache-control for etags is specified by the
-  `cache_control_for_etags` option and defaults to `"public"`.
-
-  However, `Plug.Static` also supports direct cache control by using
-  versioned query strings. If the request query string starts with
-  "?vsn=", `Plug.Static` assumes the application is versioning assets
-  and does not set the `ETag` header, meaning the cache behaviour will
-  be specified solely by the `cache_control_for_vsn_requests` config,
-  which defaults to `"public, max-age=31536000"`.
-
-  ## Options
-
-    * `:encodings` - list of 2-ary tuples where first value is value of
-      the `Accept-Encoding` header and second is extension of the file to
-      be served if given encoding is accepted by client. Entries will be tested
-      in order in list, so entries higher in list will be preferred. Defaults
-      to: `[]`.
-
-      In addition to setting this value directly it supports 2 additional
-      options for compatibility reasons:
-
-        + `:brotli` - will append `{"br", ".br"}` to the encodings list.
-        + `:gzip` - will append `{"gzip", ".gz"}` to the encodings list.
-
-      Additional options will be added in the above order (Brotli takes
-      preference over Gzip) to reflect older behaviour which was set due
-      to fact that Brotli in general provides better compression ratio than
-      Gzip.
-
-    * `:cache_control_for_etags` - sets the cache header for requests
-      that use etags. Defaults to `"public"`.
-
-    * `:etag_generation` - specify a `{module, function, args}` to be used
-      to generate   an etag. The `path` of the resource will be passed to
-      the function, as well as the `args`. If this option is not supplied,
-      etags will be generated based off of file size and modification time.
-      Note it is [recommended for the etag value to be quoted](https://tools.ietf.org/html/rfc7232#section-2.3),
-      which Plug won't do automatically.
-
-    * `:cache_control_for_vsn_requests` - sets the cache header for
-      requests starting with "?vsn=" in the query string. Defaults to
-      `"public, max-age=31536000"`.
-
-    * `:only` - filters which requests to serve. This is useful to avoid
-      file system access on every request when this plug is mounted
-      at `"/"`. For example, if `only: ["images", "favicon.ico"]` is
-      specified, only files in the "images" directory and the
-      "favicon.ico" file will be served by `Plug.Static`.
-      Note that `Plug.Static` matches these filters against request
-      uri and not against the filesystem. When requesting
-      a file with name containing non-ascii or special characters,
-      you should use urlencoded form. For example, you should write
-      `only: ["file%20name"]` instead of `only: ["file name"]`.
-      Defaults to `nil` (no filtering).
-
-    * `:only_matching` - a relaxed version of `:only` that will
-      serve any request as long as one of the given values matches the
-      given path. For example, `only_matching: ["images", "favicon"]`
-      will match any request that starts at "images" or "favicon",
-      be it "/images/foo.png", "/images-high/foo.png", "/favicon.ico"
-      or "/favicon-high.ico". Such matches are useful when serving
-      digested files at the root. Defaults to `nil` (no filtering).
-
-    * `:headers` - other headers to be set when serving static assets. Specify either
-      an enum of key-value pairs or a `{module, function, args}` to return an enum. The
-      `conn` will be passed to the function, as well as the `args`.
-
-    * `:content_types` - custom MIME type mapping. As a map with filename as key
-      and content type as value. For example:
-      `content_types: %{"apple-app-site-association" => "application/json"}`.
-
-    * `:set_content_type` - by default Plug.Static (re)sets the content type header
-      using auto-detection and the `:content_types` map. But when set to `false`
-      no content-type header will be inserted instead retaining the original
-      value or lack thereof. This can be useful when custom logic for appropiate
-      content types is needed which cannot be reasonably expressed as a static
-      filename map.
-
-  ## Examples
-
-  This plug can be mounted in a `Plug.Builder` pipeline as follows:
-
-      defmodule MyPlug do
-        use Plug.Builder
-
-        plug Plug.Static,
-          at: "/public",
-          from: :my_app,
-          only: ~w(images robots.txt)
-        plug :not_found
-
-        def not_found(conn, _) do
-          send_resp(conn, 404, "not found")
-        end
-      end
-
-  """
-
-  @behaviour Plug
-  @allowed_methods ~w(GET HEAD)
-
-  import Plug.Conn
-  alias Plug.Conn
-
-  # In this module, the `:prim_file` Erlang module along with the `:file_info`
-  # record are used instead of the more common and Elixir-y `File` module and
-  # `File.Stat` struct, respectively. The reason behind this is performance: all
-  # the `File` operations pass through a single process in order to support node
-  # operations that we simply don't need when serving assets.
-
-  require Record
-  Record.defrecordp(:file_info, Record.extract(:file_info, from_lib: "kernel/include/file.hrl"))
-
-  defmodule InvalidPathError do
-    defexception message: "invalid path for static asset", plug_status: 400
-  end
-
-  @impl true
-  def init(opts) do
-    from =
-      case Keyword.fetch!(opts, :from) do
-        {_, _} = from -> from
-        {_, _, _} = from -> from
-        from when is_atom(from) -> {from, "priv/static"}
-        from when is_binary(from) -> from
-        _ -> raise ArgumentError, ":from must be an atom, a binary or a tuple"
-      end
-
-    encodings =
-      opts
-      |> Keyword.get(:encodings, [])
-      |> maybe_add("br", ".br", Keyword.get(opts, :brotli, false))
-      |> maybe_add("gzip", ".gz", Keyword.get(opts, :gzip, false))
-
-    %{
-      encodings: encodings,
-      only_rules: {Keyword.get(opts, :only, []), Keyword.get(opts, :only_matching, [])},
-      qs_cache: Keyword.get(opts, :cache_control_for_vsn_requests, "public, max-age=31536000"),
-      et_cache: Keyword.get(opts, :cache_control_for_etags, "public"),
-      et_generation: Keyword.get(opts, :etag_generation, nil),
-      headers: Keyword.get(opts, :headers, %{}),
-      content_types: Keyword.get(opts, :content_types, %{}),
-      set_content_type: Keyword.get(opts, :set_content_type, true),
-      from: from,
-      at: opts |> Keyword.fetch!(:at) |> Plug.Router.Utils.split()
-    }
-  end
-
-  @impl true
-  def call(
-        conn = %Conn{method: meth},
-        %{at: at, only_rules: only_rules, from: from, encodings: encodings} = options
-      )
-      when meth in @allowed_methods do
-    segments = subset(at, conn.path_info)
-
-    if allowed?(only_rules, segments) do
-      segments = Enum.map(segments, &uri_decode/1)
-
-      if invalid_path?(segments) do
-        raise InvalidPathError, "invalid path for static asset: #{conn.request_path}"
-      end
-
-      path = path(from, segments)
-      range = get_req_header(conn, "range")
-      encoding = file_encoding(conn, path, range, encodings)
-      serve_static(encoding, conn, segments, range, options)
-    else
-      conn
-    end
-  end
-
-  def call(conn, _options) do
-    conn
-  end
-
-  defp uri_decode(path) do
-    # TODO: Remove rescue as this can't fail from Elixir v1.13
-    try do
-      URI.decode(path)
-    rescue
-      ArgumentError ->
-        raise InvalidPathError
-    end
-  end
-
-  defp allowed?(_only_rules, []), do: false
-  defp allowed?({[], []}, _list), do: true
-
-  defp allowed?({full, prefix}, [h | _]) do
-    h in full or (prefix != [] and match?({0, _}, :binary.match(h, prefix)))
-  end
-
-  defp maybe_put_content_type(conn, false, _, _), do: conn
-
-  defp maybe_put_content_type(conn, _, types, filename) do
-    content_type = Map.get(types, filename) || MIME.from_path(filename)
-
-    conn
-    |> put_resp_header("content-type", content_type)
-  end
-
-  defp serve_static({content_encoding, file_info, path}, conn, segments, range, options) do
-    %{
-      qs_cache: qs_cache,
-      et_cache: et_cache,
-      et_generation: et_generation,
-      headers: headers,
-      content_types: types,
-      set_content_type: set_content_type
-    } = options
-
-    case put_cache_header(conn, qs_cache, et_cache, et_generation, file_info, path) do
-      {:stale, conn} ->
-        filename = List.last(segments)
-
-        conn
-        |> maybe_put_content_type(set_content_type, types, filename)
-        |> put_resp_header("accept-ranges", "bytes")
-        |> maybe_add_encoding(content_encoding)
-        |> merge_headers(headers)
-        |> serve_range(file_info, path, range, options)
-
-      {:fresh, conn} ->
-        conn
-        |> maybe_add_vary(options)
-        |> send_resp(304, "")
-        |> halt()
-    end
-  end
-
-  defp serve_static(:error, conn, _segments, _range, _options) do
-    conn
-  end
-
-  defp serve_range(conn, file_info, path, [range], options) do
-    file_info(size: file_size) = file_info
-
-    with %{"bytes" => bytes} <- Plug.Conn.Utils.params(range),
-         {range_start, range_end} <- start_and_end(bytes, file_size) do
-      send_range(conn, path, range_start, range_end, file_size, options)
-    else
-      _ -> send_entire_file(conn, path, options)
-    end
-  end
-
-  defp serve_range(conn, _file_info, path, _range, options) do
-    send_entire_file(conn, path, options)
-  end
-
-  defp start_and_end("-" <> rest, file_size) do
-    case Integer.parse(rest) do
-      {last, ""} when last > 0 and last <= file_size -> {file_size - last, file_size - 1}
-      _ -> :error
-    end
-  end
-
-  defp start_and_end(range, file_size) do
-    case Integer.parse(range) do
-      {first, "-"} when first >= 0 ->
-        {first, file_size - 1}
-
-      {first, "-" <> rest} when first >= 0 ->
-        case Integer.parse(rest) do
-          {last, ""} when last >= first -> {first, min(last, file_size - 1)}
-          _ -> :error
-        end
-
-      _ ->
-        :error
-    end
-  end
-
-  defp send_range(conn, path, 0, range_end, file_size, options) when range_end == file_size - 1 do
-    send_entire_file(conn, path, options)
-  end
-
-  defp send_range(conn, path, range_start, range_end, file_size, _options) do
-    length = range_end - range_start + 1
-
-    conn
-    |> put_resp_header("content-range", "bytes #{range_start}-#{range_end}/#{file_size}")
-    |> send_file(206, path, range_start, length)
-    |> halt()
-  end
-
-  defp send_entire_file(conn, path, options) do
-    conn
-    |> maybe_add_vary(options)
-    |> send_file(200, path)
-    |> halt()
-  end
-
-  defp maybe_add_encoding(conn, nil), do: conn
-  defp maybe_add_encoding(conn, ce), do: put_resp_header(conn, "content-encoding", ce)
-
-  defp maybe_add_vary(conn, %{encodings: encodings}) do
-    # If we serve gzip or brotli at any moment, we need to set the proper vary
-    # header regardless of whether we are serving gzip content right now.
-    # See: http://www.fastly.com/blog/best-practices-for-using-the-vary-header/
-    if encodings != [] do
-      update_in(conn.resp_headers, &[{"vary", "Accept-Encoding"} | &1])
-    else
-      conn
-    end
-  end
-
-  defp put_cache_header(
-         %Conn{query_string: "vsn=" <> _} = conn,
-         qs_cache,
-         _et_cache,
-         _et_generation,
-         _file_info,
-         _path
-       )
-       when is_binary(qs_cache) do
-    {:stale, put_resp_header(conn, "cache-control", qs_cache)}
-  end
-
-  defp put_cache_header(conn, _qs_cache, et_cache, et_generation, file_info, path)
-       when is_binary(et_cache) do
-    etag = etag_for_path(file_info, et_generation, path)
-
-    conn =
-      conn
-      |> put_resp_header("cache-control", et_cache)
-      |> put_resp_header("etag", etag)
-
-    if etag in get_req_header(conn, "if-none-match") do
-      {:fresh, conn}
-    else
-      {:stale, conn}
-    end
-  end
-
-  defp put_cache_header(conn, _, _, _, _, _) do
-    {:stale, conn}
-  end
-
-  defp etag_for_path(file_info, et_generation, path) do
-    case et_generation do
-      {module, function, args} ->
-        apply(module, function, [path | args])
-
-      nil ->
-        file_info(size: size, mtime: mtime) = file_info
-        <<?", {size, mtime} |> :erlang.phash2() |> Integer.to_string(16)::binary, ?">>
-    end
-  end
-
-  defp file_encoding(conn, path, [_range], _encodings) do
-    # We do not support compression for range queries.
-    file_encoding(conn, path, nil, [])
-  end
-
-  defp file_encoding(conn, path, _range, encodings) do
-    encoded =
-      Enum.find_value(encodings, fn {encoding, ext} ->
-        if file_info = accept_encoding?(conn, encoding) && regular_file_info(path <> ext) do
-          {encoding, file_info, path <> ext}
-        end
-      end)
-
-    cond do
-      not is_nil(encoded) ->
-        encoded
-
-      file_info = regular_file_info(path) ->
-        {nil, file_info, path}
-
-      true ->
-        :error
-    end
-  end
-
-  defp regular_file_info(path) do
-    case :prim_file.read_file_info(path) do
-      {:ok, file_info(type: :regular) = file_info} ->
-        file_info
-
-      _ ->
-        nil
-    end
-  end
-
-  defp accept_encoding?(conn, encoding) do
-    encoding? = &String.contains?(&1, [encoding, "*"])
-
-    Enum.any?(get_req_header(conn, "accept-encoding"), fn accept ->
-      accept |> Plug.Conn.Utils.list() |> Enum.any?(encoding?)
-    end)
-  end
-
-  defp maybe_add(list, key, value, true), do: list ++ [{key, value}]
-  defp maybe_add(list, _key, _value, false), do: list
-
-  defp path({module, function, arguments}, segments)
-       when is_atom(module) and is_atom(function) and is_list(arguments),
-       do: Enum.join([apply(module, function, arguments) | segments], "/")
-
-  defp path({app, from}, segments) when is_atom(app) and is_binary(from),
-    do: Enum.join([Application.app_dir(app), from | segments], "/")
-
-  defp path(from, segments),
-    do: Enum.join([from | segments], "/")
-
-  defp subset([h | expected], [h | actual]), do: subset(expected, actual)
-  defp subset([], actual), do: actual
-  defp subset(_, _), do: []
-
-  defp invalid_path?(list) do
-    invalid_path?(list, :binary.compile_pattern(["/", "\\", ":", "\0"]))
-  end
-
-  defp invalid_path?([h | _], _match) when h in [".", "..", ""], do: true
-  defp invalid_path?([h | t], match), do: String.contains?(h, match) or invalid_path?(t)
-  defp invalid_path?([], _match), do: false
-
-  defp merge_headers(conn, {module, function, args}) do
-    merge_headers(conn, apply(module, function, [conn | args]))
-  end
-
-  defp merge_headers(conn, headers) do
-    merge_resp_headers(conn, headers)
-  end
-end

lib/pleroma/web/plugs/uploaded_media.ex

@@ -11,7 +11,6 @@ defmodule Pleroma.Web.Plugs.UploadedMedia do
   require Logger
 
   alias Pleroma.Web.MediaProxy
-  alias Pleroma.Web.Plugs.Utils
 
   @behaviour Plug
   # no slashes
@@ -29,21 +28,10 @@ defmodule Pleroma.Web.Plugs.UploadedMedia do
       |> Keyword.put(:at, "/__unconfigured_media_plug")
       |> Plug.Static.init()
 
-    config = Pleroma.Config.get(Pleroma.Upload)
-    allowed_mime_types = Keyword.fetch!(config, :allowed_mime_types)
-    uploader = Keyword.fetch!(config, :uploader)
-
-    %{
-      static_plug_opts: static_plug_opts,
-      allowed_mime_types: allowed_mime_types,
-      uploader: uploader
-    }
+    %{static_plug_opts: static_plug_opts}
   end
 
-  def call(
-        %{request_path: <<"/", @path, "/", file::binary>>} = conn,
-        %{uploader: uploader} = opts
-      ) do
+  def call(%{request_path: <<"/", @path, "/", file::binary>>} = conn, opts) do
     conn =
       case fetch_query_params(conn) do
         %{query_params: %{"name" => name}} = conn ->
@@ -56,7 +44,10 @@ defmodule Pleroma.Web.Plugs.UploadedMedia do
       end
       |> merge_resp_headers([{"content-security-policy", "sandbox"}])
 
-    with {:ok, get_method} <- uploader.get_file(file),
+    config = Pleroma.Config.get(Pleroma.Upload)
+
+    with uploader <- Keyword.fetch!(config, :uploader),
+         {:ok, get_method} <- uploader.get_file(file),
          false <- media_is_banned(conn, get_method) do
       get_media(conn, get_method, opts)
     else
@@ -77,23 +68,13 @@ defmodule Pleroma.Web.Plugs.UploadedMedia do
 
   defp media_is_banned(_, _), do: false
 
-  defp set_content_type(conn, opts, filepath) do
-    real_mime = MIME.from_path(filepath)
-    clean_mime = Utils.get_safe_mime_type(opts, real_mime)
-    put_resp_header(conn, "content-type", clean_mime)
-  end
-
   defp get_media(conn, {:static_dir, directory}, opts) do
     static_opts =
       Map.get(opts, :static_plug_opts)
       |> Map.put(:at, [@path])
       |> Map.put(:from, directory)
-      |> Map.put(:set_content_type, false)
 
-    conn =
-      conn
-      |> set_content_type(opts, conn.request_path)
-      |> Pleroma.Web.Plugs.StaticNoCT.call(static_opts)
+    conn = Plug.Static.call(conn, static_opts)
 
     if conn.halted do
       conn

lib/pleroma/web/plugs/utils.ex

@@ -1,14 +0,0 @@
-# Akkoma: Magically expressive social media
-# Copyright © 2024 Akkoma Authors <https://akkoma.dev>
-# SPDX-License-Identifier: AGPL-3.0-only
-
-defmodule Pleroma.Web.Plugs.Utils do
-  @moduledoc """
-  Some helper functions shared across several plugs
-  """
-
-  def get_safe_mime_type(%{allowed_mime_types: allowed_mime_types} = _opts, mime) do
-    [maintype | _] = String.split(mime, "/", parts: 2)
-    if maintype in allowed_mime_types, do: mime, else: "application/octet-stream"
-  end
-end

lib/pleroma/web/router.ex

@@ -800,9 +800,13 @@ defmodule Pleroma.Web.Router do
   scope "/", Pleroma.Web.ActivityPub do
     pipe_through([:activitypub_client])
 
+    get("/api/ap/whoami", ActivityPubController, :whoami)
     get("/users/:nickname/inbox", ActivityPubController, :read_inbox)
 
     get("/users/:nickname/outbox", ActivityPubController, :outbox)
+    post("/users/:nickname/outbox", ActivityPubController, :update_outbox)
+    post("/api/ap/upload_media", ActivityPubController, :upload_media)
+
     get("/users/:nickname/collections/featured", ActivityPubController, :pinned)
   end
 

lib/pleroma/web/static_fe/static_fe_controller.ex

@@ -24,13 +24,7 @@ defmodule Pleroma.Web.StaticFE.StaticFEController do
          true <- Visibility.is_public?(activity.object),
          {_, true} <- {:visible?, Visibility.visible_for_user?(activity, _reading_user = nil)},
          %User{} = user <- User.get_by_ap_id(activity.object.data["actor"]) do
-      meta =
-        Metadata.build_tags(%{
-          activity_id: notice_id,
-          url: activity.data["id"],
-          object: activity.object,
-          user: user
-        })
+      meta = Metadata.build_tags(%{url: activity.data["id"], object: activity.object, user: user})
 
       timeline =
         activity.object.data["context"]

lib/pleroma/web/telemetry.ex

@@ -101,8 +101,7 @@ defmodule Pleroma.Web.Telemetry do
     ]
   end
 
-  # Summary metrics are currently not (yet) supported by the prometheus exporter
-  defp summary_metrics(byte_unit) do
+  defp summary_metrics do
     [
       # Phoenix Metrics
       summary("phoenix.endpoint.stop.duration",
@@ -119,97 +118,10 @@ defmodule Pleroma.Web.Telemetry do
       summary("pleroma.repo.query.idle_time", unit: {:native, :millisecond}),
 
       # VM Metrics
-      summary("vm.memory.total", unit: {:byte, byte_unit}),
+      summary("vm.memory.total", unit: {:byte, :kilobyte}),
       summary("vm.total_run_queue_lengths.total"),
       summary("vm.total_run_queue_lengths.cpu"),
-      summary("vm.total_run_queue_lengths.io")
-    ]
-  end
-
-  defp sum_counter_pair(basename, opts) do
-    [
-      sum(basename <> ".psum", opts),
-      counter(basename <> ".pcount", opts)
-    ]
-  end
-
-  # Prometheus exporter doesn't support summaries, so provide fallbacks
-  defp summary_fallback_metrics(byte_unit \\ :byte) do
-    # Summary metrics are not supported by the Prometheus exporter
-    #   https://github.com/beam-telemetry/telemetry_metrics_prometheus_core/issues/11
-    # and sum metrics currently only work with integers
-    #   https://github.com/beam-telemetry/telemetry_metrics_prometheus_core/issues/35
-    #
-    # For VM metrics this is kindof ok as they appear to always be integers
-    # and we can use sum + counter to get the average between polls from their change
-    # But for repo query times we need to use a full distribution
-
-    simple_buckets = [0, 1, 2, 4, 8, 16]
-    simple_buckets_quick = for t <- simple_buckets, do: t / 100.0
-
-    # Already included in distribution metrics anyway:
-    #   phoenix.router_dispatch.stop.duration
-    #   pleroma.repo.query.total_time
-    #   pleroma.repo.query.queue_time
-    dist_metrics = [
-      distribution("phoenix.endpoint.stop.duration.fdist",
-        event_name: [:phoenix, :endpoint, :stop],
-        measurement: :duration,
-        unit: {:native, :millisecond},
-        reporter_options: [
-          buckets: simple_buckets
-        ]
-      ),
-      distribution("pleroma.repo.query.decode_time.fdist",
-        event_name: [:pleroma, :repo, :query],
-        measurement: :decode_time,
-        unit: {:native, :millisecond},
-        reporter_options: [
-          buckets: simple_buckets_quick
-        ]
-      ),
-      distribution("pleroma.repo.query.query_time.fdist",
-        event_name: [:pleroma, :repo, :query],
-        measurement: :query_time,
-        unit: {:native, :millisecond},
-        reporter_options: [
-          buckets: simple_buckets
-        ]
-      ),
-      distribution("pleroma.repo.query.idle_time.fdist",
-        event_name: [:pleroma, :repo, :query],
-        measurement: :idle_time,
-        unit: {:native, :millisecond},
-        reporter_options: [
-          buckets: simple_buckets
-        ]
-      )
-    ]
-
-    vm_metrics =
-      sum_counter_pair("vm.memory.total",
-        event_name: [:vm, :memory],
-        measurement: :total,
-        unit: {:byte, byte_unit}
-      ) ++
-        sum_counter_pair("vm.total_run_queue_lengths.total",
-          event_name: [:vm, :total_run_queue_lengths],
-          measurement: :total
-        ) ++
-        sum_counter_pair("vm.total_run_queue_lengths.cpu",
-          event_name: [:vm, :total_run_queue_lengths],
-          measurement: :cpu
-        ) ++
-        sum_counter_pair("vm.total_run_queue_lengths.io.fsum",
-          event_name: [:vm, :total_run_queue_lengths],
-          measurement: :io
-        )
-
-    dist_metrics ++ vm_metrics
-  end
-
-  defp common_metrics do
-    [
+      summary("vm.total_run_queue_lengths.io"),
       last_value("pleroma.local_users.total"),
       last_value("pleroma.domains.total"),
       last_value("pleroma.local_statuses.total"),
@@ -217,10 +129,8 @@ defmodule Pleroma.Web.Telemetry do
     ]
   end
 
-  def prometheus_metrics,
-    do: common_metrics() ++ distribution_metrics() ++ summary_fallback_metrics()
-
-  def live_dashboard_metrics, do: common_metrics() ++ summary_metrics(:megabyte)
+  def prometheus_metrics, do: summary_metrics() ++ distribution_metrics()
+  def live_dashboard_metrics, do: summary_metrics()
 
   defp periodic_measurements do
     [