MRF SimplePolicy string deprecation warning wrong? #199

New Issue

Closed

opened 2022-09-04 19:51:36 +00:00 by YokaiRick · 4 comments

YokaiRick commented

2022-09-04 19:51:36 +00:00

Contributor

Hi,

at startup of akkoma i get the following deprication warning:

Sep 04 19:36:33 rick-akkoma-1 mix[29534]: 19:36:33.158 [warn] !!!DEPRECATION WARNING!!!
Sep 04 19:36:33 rick-akkoma-1 mix[29534]: Your config is using strings in the SimplePolicy configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:
Sep 04 19:36:33 rick-akkoma-1 mix[29534]: ```
Sep 04 19:36:33 rick-akkoma-1 mix[29534]: config :pleroma, :mrf_simple,
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   media_removal: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   media_nsfw: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   federated_timeline_removal: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   report_removal: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   reject: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   followers_only: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   accept: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   avatar_removal: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   banner_removal: ["instance.tld"],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   reject_deletes: ["instance.tld"]
Sep 04 19:36:33 rick-akkoma-1 mix[29534]: ```
Sep 04 19:36:33 rick-akkoma-1 mix[29534]: Is now
Sep 04 19:36:33 rick-akkoma-1 mix[29534]: ```
Sep 04 19:36:33 rick-akkoma-1 mix[29534]: config :pleroma, :mrf_simple,
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   media_removal: [{"instance.tld", "Reason for media removal"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   media_nsfw: [{"instance.tld", "Reason for media nsfw"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   federated_timeline_removal: [{"instance.tld", "Reason for federated timeline removal"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   report_removal: [{"instance.tld", "Reason for report removal"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   reject: [{"instance.tld", "Reason for reject"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   followers_only: [{"instance.tld", "Reason for followers only"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   accept: [{"instance.tld", "Reason for accept"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   avatar_removal: [{"instance.tld", "Reason for avatar removal"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   banner_removal: [{"instance.tld", "Reason for banner removal"}],
Sep 04 19:36:33 rick-akkoma-1 mix[29534]:   reject_deletes: [{"instance.tld", "Reason for reject deletes"}]
Sep 04 19:36:33 rick-akkoma-1 mix[29534]: ``````

My config already uses tulpes thou:

config :pleroma, :mrf_simple,
  reject: [{"xxxx.social", "obvious"}, {"xxxx.cc", "obvious"}]

So, is my config still wrong? Did i oversee sth, or is the deprecation warning displayd for now reason?

PS: I did mask the domains, so if someone search them on the net, they don't land here on this gitlab lol XD

Hi, at startup of akkoma i get the following deprication warning: ``` Sep 04 19:36:33 rick-akkoma-1 mix[29534]: 19:36:33.158 [warn] !!!DEPRECATION WARNING!!! Sep 04 19:36:33 rick-akkoma-1 mix[29534]: Your config is using strings in the SimplePolicy configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later: Sep 04 19:36:33 rick-akkoma-1 mix[29534]: ``` Sep 04 19:36:33 rick-akkoma-1 mix[29534]: config :pleroma, :mrf_simple, Sep 04 19:36:33 rick-akkoma-1 mix[29534]: media_removal: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: media_nsfw: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: federated_timeline_removal: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: report_removal: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: reject: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: followers_only: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: accept: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: avatar_removal: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: banner_removal: ["instance.tld"], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: reject_deletes: ["instance.tld"] Sep 04 19:36:33 rick-akkoma-1 mix[29534]: ``` Sep 04 19:36:33 rick-akkoma-1 mix[29534]: Is now Sep 04 19:36:33 rick-akkoma-1 mix[29534]: ``` Sep 04 19:36:33 rick-akkoma-1 mix[29534]: config :pleroma, :mrf_simple, Sep 04 19:36:33 rick-akkoma-1 mix[29534]: media_removal: [{"instance.tld", "Reason for media removal"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: media_nsfw: [{"instance.tld", "Reason for media nsfw"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: federated_timeline_removal: [{"instance.tld", "Reason for federated timeline removal"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: report_removal: [{"instance.tld", "Reason for report removal"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: reject: [{"instance.tld", "Reason for reject"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: followers_only: [{"instance.tld", "Reason for followers only"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: accept: [{"instance.tld", "Reason for accept"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: avatar_removal: [{"instance.tld", "Reason for avatar removal"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: banner_removal: [{"instance.tld", "Reason for banner removal"}], Sep 04 19:36:33 rick-akkoma-1 mix[29534]: reject_deletes: [{"instance.tld", "Reason for reject deletes"}] Sep 04 19:36:33 rick-akkoma-1 mix[29534]: `````` ``` My config already uses tulpes thou: ``` config :pleroma, :mrf_simple, reject: [{"xxxx.social", "obvious"}, {"xxxx.cc", "obvious"}] ``` So, is my config still wrong? Did i oversee sth, or is the deprecation warning displayd for now reason? PS: I did mask the domains, so if someone search them on the net, they don't land here on this gitlab lol XD

floatingghost commented

2022-09-04 20:06:30 +00:00

Owner

do you have database configuration turned on? if so that might have the old schema

YokaiRick commented

2022-09-05 08:13:52 +00:00

Author

Contributor

Nope, config via database is turned off and i never did acticate it once.
I'm more of a fan from conifg files XD

Anyway, it does seem to work, at least my FE/about page tells me that.Just wanted to point that 'error' out, so that it doesn't become a problem in the future

Oh i want to point sth out, but that shouldn't be directly part of the problem. I've also quarantined the instances, i read you have merged these two options, but i didn't find anything in the docs, so i added it, just to be sure.

Nope, config via database is turned off and i never did acticate it once. I'm more of a fan from conifg files XD Anyway, it does seem to work, at least my FE/about page tells me that.Just wanted to point that 'error' out, so that it doesn't become a problem in the future Oh i want to point sth out, but that shouldn't be directly part of the problem. I've also quarantined the instances, i read you have merged these two options, but i didn't find anything in the docs, so i added it, just to be sure.

YokaiRick commented

2022-10-10 19:57:06 +00:00

Author

Contributor

btw i kinda fixed it.
i removed the quarantined_instances config entry.

now the error is gone and also the reason is displayed correctly in my about page ^^

but obvoisly the entry quarantined_instances is gone in my about page too.. you did merge these configs at some time am i right? so i assume if i reject an instance via mrf_simple it gets also quarantined?

btw i kinda fixed it. i removed the quarantined_instances config entry. now the error is gone and also the reason is displayed correctly in my about page ^^ but obvoisly the entry quarantined_instances is gone in my about page too.. you did merge these configs at some time am i right? so i assume if i reject an instance via mrf_simple it gets also quarantined?

floatingghost commented

2022-10-10 20:10:36 +00:00

Owner

ah yeah I did merge them, reject is what quarantine used to be

if you reject them, it's a total defederation

ah yeah I did merge them, reject is what quarantine used to be if you reject them, it's a total defederation

❤️ 1