Fix LDAP user registration

nullobsi commented

2022-10-13 06:25:56 +00:00

Contributor

Simple fix for LDAP user registration. I'm not sure what changed but I managed to get Akkoma running in a debug session and figured out it was missing a match for an extra value at the end. I don't know Elixir all that well so I'm not sure if this was the correct way to do it... but it works. :)

nullobsi added 1 commit 2022-10-13 06:25:56 +00:00

ci/woodpecker/pr/woodpecker Pipeline failed Details

e5401fb3d7 Update 'lib/pleroma/web/auth/ldap_authenticator.ex'

floatingghost commented

2022-10-14 09:24:16 +00:00

Owner

ah right, this apparently was a breaking change in erlang OTP 24.3

your fix is correct, thanks!

but unfortunately there is a test that needs updating - https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/test/pleroma/web/o_auth/ldap_authorization_test.exs#L74

you should just be able to change it to

  {:ok, {:eldap_search_result, [{:eldap_entry, '', []}], [], []}}

to make it pass

ah right, this apparently was a breaking change in erlang OTP 24.3 your fix is correct, thanks! but unfortunately there is a test that needs updating - https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/test/pleroma/web/o_auth/ldap_authorization_test.exs#L74 you should just be able to change it to ``` {:ok, {:eldap_search_result, [{:eldap_entry, '', []}], [], []}} ``` to make it pass

floatingghost commented

2022-11-01 14:17:48 +00:00

Owner

given by the lack of reply here i'll guess you didn't see this, i'll apply the patch before fixing the test

thanks~

given by the lack of reply here i'll guess you didn't see this, i'll apply the patch before fixing the test thanks~