AkkomaGang/akkoma
AkkomaGang/akkoma
15
66
Fork 94
Code Issues 180 Pull requests 28 Projects 2 Releases 14 Packages Wiki Activity

fix flaky test filter_controller_test.exs:200 #239

Merged
floatingghost merged 1 commit from ilja/akkoma:fix_flaky_filter_controller_test.exs_200 into develop 2022-11-01 14:42:43 +00:00
Conversation 1 Commits 1 Files changed 1 +25 -34
ilja commented 2022-10-23 11:12:18 +00:00
Contributor
Copy link

The flakyness was actually already fixed by adding a timediff. But here I'm mocking time which gives a more precise test. It does require the test to be sync. I add this PR here to be complete, feel free to discard if you think the current sollution was better/already good enough.

The flakyness was actually already fixed by adding a timediff. But here I'm mocking time which gives a more precise test. It does require the test to be sync. I add this PR here to be complete, feel free to discard if you think the current sollution was better/already good enough.
ilja added 1 commit 2022-10-23 11:12:19 +00:00
fix flaky test filter_controller_test.exs:200
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
a59d310982
floatingghost commented 2022-11-01 14:42:35 +00:00
Owner
Copy link

yeah i think i agree with you here, whilst the last solution does work, it does still rely on the system clock which is bound to go weird at points

yeah i think i agree with you here, whilst the last solution does work, it does still rely on the system clock which is bound to go weird at points
floatingghost merged commit d5bbc3eeb2 into develop 2022-11-01 14:42:43 +00:00
floatingghost deleted branch fix_flaky_filter_controller_test.exs_200 2022-11-01 14:42:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#239
No description provided.
Delete branch "ilja/akkoma:fix_flaky_filter_controller_test.exs_200"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?