Add Signed Fetch Statistics #312

luna · 2022-11-25T15:20:38Z

luna commented

2022-11-25 15:20:38 +00:00

Close #304.

Notes:

This patch was made on top of Pleroma develop, so I created a separate cachex worker for request signature actions, instead of Akkoma's instance cache. If that is a merge blocker, I can attempt to move logic around for that.
Regarding the has_request_signatures: true -> false state transition: I think that is a higher level thing (resetting instance state on new instance actor key) which is separate from the changes relevant to this one.

Close #304. Notes: - This patch was made on top of Pleroma develop, so I created a separate cachex worker for request signature actions, instead of Akkoma's instance cache. If that is a merge blocker, I can attempt to move logic around for that. - Regarding the `has_request_signatures: true -> false` state transition: I think that is a higher level thing (resetting instance state on new instance actor key) which is separate from the changes relevant to this one.

👍 2

luna added 1 commit 2022-11-25 15:20:39 +00:00

ci/woodpecker/pr/woodpecker Pipeline failed Details

dd92d0af61 Add Signed Fetch Statistics

floatingghost reviewed 2022-11-26 18:31:46 +00:00

floatingghost left a comment

in the main this looks good!

a few little bits to touch up, but otherwise seems ok to me - the error message is the main thing i'm concerned with

in the main this looks good! a few little bits to touch up, but otherwise seems ok to me - the error message is the main thing i'm concerned with

lib/pleroma/instances.ex Outdated

					
				@ -44,2 +44,4 @@

				    end

				  end

				  def set_request_signatures(url_or_host), do: Instance.set_request_signatures(url_or_host)

floatingghost commented

2022-11-26 18:17:18 +00:00

you could probably use a defdelegate set_request_signatures(url_or_host), to: Instance here

you could probably use a `defdelegate set_request_signatures(url_or_host), to: Instance` here

luna marked this conversation as resolved

lib/pleroma/web/plugs/http_signature_plug.ex Outdated

					
				@ -81,0 +104,4 @@

				          :noop

				        any ->

				          Logger.warn("expected request signature cache to run, got #{any}")

floatingghost commented

2022-11-26 18:22:54 +00:00

this is a nitpick, but this error message is a bit hard to parse

perhaps you want something like expected request signature cache to return a boolean, instead got ...?

this is a nitpick, but this error message is a bit hard to parse perhaps you want something like `expected request signature cache to return a boolean, instead got ...`?

luna marked this conversation as resolved

test/pleroma/instances_test.exs

					
				@ -124,0 +127,4 @@

				      host = "domain.com"

				      {:ok, instance} = Instances.set_request_signatures(host)

				      assert instance.has_request_signatures